search for: state_machine_generator

...t 07:27:53PM +0100, Richard W.M. Jones wrote: > Logging state transitions in debug mode produces huge amounts of > output which is not especially helpful. This change removes this > debugging output. This reduces the debug output by approximately two > thirds. > --- > generator/state_machine_generator.ml | 12 ------------ > 1 file changed, 12 deletions(-) > > diff --git a/generator/state_machine_generator.ml b/generator/state_machine_generator.ml > index 274e290952..52c497646d 100644 > --- a/generator/state_machine_generator.ml > +++ b/generator/state_machine_generator.ml &gt...

...tion failure causes a crash. There aren't any good ways to fix this. I chose to remove the assertions that might trigger, and ignore pthread_getspecific returning EINVAL. This reverts a small part of commit 831cbf7ee14c ("generator: Allow DEAD state actions to run"). --- generator/state_machine_generator.ml | 5 +---- generator/states.c | 2 -- lib/errors.c | 5 ++++- 3 files changed, 5 insertions(+), 7 deletions(-) diff --git a/generator/state_machine_generator.ml b/generator/state_machine_generator.ml index 43c1ce4c14..9f94bed1f3 100644 --- a/generator/s...

These patches aren't related to each other, but both are quite simple. The second one requires particular attention - it's my experience that printing out the state transitions in debug mode has never helped me to diagnose a bug, but it has made the debug logs huge and hard to follow. However that might just be me! Has it helped anyone else? Also I'm open to the concept of debug

...quot;generator: Allow DEAD state actions to run"). Thanks: Richard W.M. Jones <rjones at redhat.com> Signed-off-by: Eric Blake <eblake at redhat.com> --- Taking Rich's analysis and weakening of the assertions, but tweaking the errors.c to avoid undefined behavior. generator/state_machine_generator.ml | 5 +-- generator/states.c | 1 - lib/errors.c | 50 ++++++++++++++++++---------- 3 files changed, 34 insertions(+), 22 deletions(-) diff --git a/generator/state_machine_generator.ml b/generator/state_machine_generator.ml index 43c1ce4c..9f94bed1 100...

V3 was here: <http://mid.mail-archive.com/20230215141158.2426855-1-lersek at redhat.com>. See the Notes section on each patch for the v4 updates. The series is nearly ready for merging: every patch has at least one R-b tag, except "socket activation: avoid manipulating the sign bit". The series builds, and passes "make check" and "make check-valgrind", at