search for: state_count

Another bundle of issues from Coverity triage. The first one is in x86/mm, and looks scarier than it is. The others are all in xen/drivers and AFAICT are pretty minor. Cheers, Tim.

...= next_perf_state) { @@ -206,7 +206,7 @@ static int powernow_cpufreq_cpu_init(str result = -ENODEV; goto err_unreg; } - cpumask_copy(&policy->cpus, cpumask_of(cpu)); + cpumask_copy(policy->cpus, cpumask_of(cpu)); /* capability check */ if (perf->state_count <= 1) { --- 2011-09-20.orig/xen/drivers/acpi/pmstat.c 2011-09-21 16:37:46.000000000 +0200 +++ 2011-09-20/xen/drivers/acpi/pmstat.c 2011-10-14 14:53:51.000000000 +0200 @@ -211,11 +211,11 @@ static int get_cpufreq_para(struct xen_s list_for_each(pos, &cpufreq_governor_list) gov_n...

I hacked some command line options into imaptest. I dont think I broke it.. Place into dovecot-source root as usual and compile with: gcc imaptest.c -o imaptest -Wall -W -I. -Isrc/lib -DHAVE_CONFIG_H src/lib/liblib.a As per Timo's instructions. # imaptest -h imaptest [USER at IP:PORTNO] [pass=PASSWORD] [mbox=MBOX] [clients=CC] [msgs=NMSG] [use_authenticate] [PORTNO] USER = template for

...ed_cpu_map; - } else { - policy->cpus = cpumask_of_cpu(cpu); + printk("Unsupported sharing type\n"); + result = -ENODEV; + goto err_unreg; } + cpumask_copy(&policy->cpus, cpumask_of(cpu)); /* capability check */ if (perf->state_count <= 1) { --- a/xen/include/acpi/cpufreq/processor_perf.h +++ b/xen/include/acpi/cpufreq/processor_perf.h @@ -29,7 +29,6 @@ struct processor_performance { uint32_t state_count; struct xen_processor_px *states; struct xen_psd_package domain_info; - cpumask_t shared_cpu_map; u...

...element of a linked list) with flexible array members. Basically, this is a structure where the last component is an incomplete array type (e.g., Harbison & Steel, "C, a reference manual, 5th ed.", p. 159) such as: struct Sequence { struct Sequence *next; int len; unsigned int state_count[]; }; To create one such sequence, I allocate storage (following Harbison and Steel) in a C program as follows: struct Sequence *A; int n = 4; A = malloc( sizeof(struct Sequence) + n * sizeof(unsigned int)); If I understand correctly, however, it would be better to use R_alloc instead of mallo...

Hello, The following patches are a solution to a problem we have encountered when using the Xen hypervisor: - Need Pxx/Cxx states to save on power consumption when using Xen (we do want those datacenters to consume less power!), - Also need to figure out the Turbo mode so that the scheduler can properly boost a core for CPU bound guests. In essence the Xen hypervisor requires that

...eof(struct cpuidle_device), > + GFP_KERNEL); No checking to see if dev == NULL? > + int count = CPUIDLE_DRIVER_STATE_START; > + dev->cpu = cpu; > + dev->drv = &xen_idle_driver; > + > + dev->states[count] = state_default_idle; > + count++; > + > + dev->state_count = count; > + > + if (cpuidle_register_device(dev)) > + return -EIO; No cleanup of the ''dev'' so that we don''t leak memory? > + return 0; > +} > + > +static int xen_idle_init(void) > +{ > + int retval, i; > + retval = cpuidle_register_driver...

...w_table_pstate(struct powernow_k8_data *data, struct cpufreq_frequency_table *powernow_table) { int i; + u32 hi = 0, lo = 0; + rdmsr(MSR_PSTATE_CUR_LIMIT, hi, lo); + data->max_hw_pstate = (hi & HW_PSTATE_MAX_MASK) >> HW_PSTATE_MAX_SHIFT; for (i = 0; i < data->acpi_data->state_count; i++) { u32 index; - u32 hi = 0, lo = 0; - u32 fid; - u32 did; index = data->acpi_data->states[i].control & HW_PSTATE_MASK; - if (index > MAX_HW_PSTATE) { + if (index > data->max_hw_pstate) { printk(KERN_ERR PFX "invalid pstate %d - bad value %d.\n", i,...

Hi everyone, When I set CONFIG_ACPI_PROCESSOR, CONFIG_CPU_IDLE and CONFIG_INTEL_IDLE to y then I cannot boot Xen; there is a crash. If I turn CONFIG_INTEL_IDLE off then the boot goes well and, after dom0 has booted, xenpm works and gives some sane output, see below. I have tested this with kernels 3.2 to 3.4.6. Is it impossible to use INTEL_IDLE with Xen? If this is a known issue then maybe

Hi everyone, When I set CONFIG_ACPI_PROCESSOR, CONFIG_CPU_IDLE and CONFIG_INTEL_IDLE to y then I cannot boot Xen; there is a crash. If I turn CONFIG_INTEL_IDLE off then the boot goes well and, after dom0 has booted, xenpm works and gives some sane output, see below. I have tested this with kernels 3.2 to 3.4.6. Is it impossible to use INTEL_IDLE with Xen? If this is a known issue then maybe

Hi all, this patch series makes the necessary changes to make sure that the current ARM hypercall ABI can be used as-is on 64 bit ARM platforms: - it defines xen_ulong_t as uint64_t on ARM; - it introduces a new macro to handle guest pointers, called XEN_GUEST_HANDLE_PARAM (that has size 4 bytes on aarch and is going to have size 8 bytes on aarch64); - it replaces all the occurrences of