search for: start_progress_met

...=== RCS file: /cvs/src/usr.bin/ssh/sftp-client.c,v retrieving revision 1.46 diff -u -r1.46 sftp-client.c --- sftp-client.c 17 Feb 2004 05:39:51 -0000 1.46 +++ sftp-client.c 3 Mar 2004 03:05:36 -0000 @@ -805,13 +805,8 @@ max_req = 1; progress_counter = 0; - if (showprogress) { - if (size) - start_progress_meter(remote_path, size, - &progress_counter); - else - printf("Fetching %s to %s\n", remote_path, local_path); - } + if (showprogress && size != 0) + start_progress_meter(remote_path, size, &progress_counter); while (num_req > 0 || max_req > 0) { char *...

We are trying to enable large file support for everything built for ARM on ChromeOS and openssh uses mkstemp which has a 64-bit version for compatibility with open64. When looking into enabling the large file support flags, I noticed: `void start_progress_meter(const char *, off_t, off_t *);` in progressmeter.h which would have different ABIs with and without large file support. You all probably ought to avoid exposing off_t in any external-facing APIs. Allen

...2023, Allen Webb wrote: > We are trying to enable large file support for everything built for > ARM on ChromeOS and openssh uses mkstemp which has a 64-bit version > for compatibility with open64. When looking into enabling the large > file support flags, I noticed: > > `void start_progress_meter(const char *, off_t, off_t *);` > > in progressmeter.h which would have different ABIs with and without > large file support. You all probably ought to avoid exposing off_t in > any external-facing APIs. OpenSSH doesn't have any external-facing APIs though, we don't ship a l...

http://bugzilla.mindrot.org/show_bug.cgi?id=842 ------- Comment #2 from djm at mindrot.org 2005-11-06 03:51 ------- Is this still relevant? What compile warnings do you see? ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee.

I miss the stars when doing scp. My suggestion for progressmeter.c makes scp to display different fields on different terminal widths. Maybe this is useful for you. Once in "start_progress_meter()" the outlook of the progressline is calculated. In "draw_progress_meter()" sprintf() instead of snprintf() together with some strlen()'s can be used, because the buffersize has been respected before. The remaining time can now have the form "> 99 days", "11d...

...h-rand-helper.c:553: warning: int format, uid_t arg (arg 2) >ssh-rand-helper.c:592: warning: int format, uid_t arg (arg 2) All gone. >sftp-server.c:604: warning: implicit declaration of function `utimes' No prototypes for utimes either. >sftp-client.c:1046: warning: passing arg 3 of `start_progress_meter' from incompatible pointer type Still there. Since most of these are fixed, and most of what's left is due to missing prototypes, I'm closing this bug. ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee.

...esstype==0 Let me know your comments... Hans --- progressmeter.h ? ? 2006-03-26 05:30:02.000000000 +0200 +++ progressmeter_new.h 2009-10-24 20:35:35.168288539 +0200 @@ -23,5 +23,7 @@ ?* THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. ?*/ +extern int ? ? progresstype; + ?void ? start_progress_meter(char *, off_t, off_t *); ?void ? stop_progress_meter(void); --- progressmeter.c ? ? 2006-08-05 04:39:40.000000000 +0200 +++ progressmeter_new.c 2009-10-24 20:32:45.455788330 +0200 @@ -74,12 +74,15 @@ ?static int win_size; ? ? ? ? ? /* terminal window size */ ?static volatile sig_atomic_t win_re...

...cal file %s failed: %s\n", local_path, strerror(errno)); + close(local_fd); + buffer_free(&msg); + return(-1); + } + /* if (lseek(local_fd, offset, SEEK_SET) != 0) + lseek(local_fd, 0, SEEK_END); */ + } else { + offset = 0; + } +#else offset = 0; +#endif if (showprogress) start_progress_meter(local_path, sb.st_size, &offset); else diff -u -r openssh-3.7.1p2/sftp-client.h openssh-3.7.1p2_sftp/sftp-client.h --- openssh-3.7.1p2/sftp-client.h 2002-09-11 18:54:26.000000000 -0500 +++ openssh-3.7.1p2_sftp/sftp-client.h 2003-10-16 10:11:34.000000000 -0500 @@ -96,12 +96,24 @@ * Downloa...

Hey, So, I would be looking at type A. Forgive me if my understanding of how OpenSSH operates is not reflective of reality. I am assuming that, the file transfer is happening somewhat logically, with a name being known, content written, blah blah. >From reading scp.c, it appears that, the client end at least knows the file name so I must assume the server end must be given it. I am hoping to

https://bugzilla.mindrot.org/show_bug.cgi?id=2434 Bug ID: 2434 Summary: scp can send arbitrary control characters / escape sequences to the terminal Product: Portable OpenSSH Version: 6.7p1 Hardware: Other OS: Linux Status: NEW Severity: security Priority: P5