Displaying 3 results from an estimated 3 matches for "start_nbdkt".
Did you mean:
start_nbdkit
2018 Sep 11
2
Re: [PATCH nbdkit 4/4] tests: Add a helper function which waits for nbdkit to start up.
...econds (if the first
succeeded on the last iteration, but the second timed out). I don't see
anything wrong with the change, although it might be worth a mention in
the commit message as intentional.
I'm also seeing a common pattern of assigning pid=$(cat file.pid) right
after calling start_nbdkt. Would it be worth changing the signature of
start_nbdkit() to also populate a pid variable on success, as in:
start_nbdkit blocksize1.pid pid1 myarg1
start_nbdkit()
{
pidfile=$1
pidvar=$2
shift 2
...
pid=$(cat $pidfile)
eval $pidvar=$pid
which would also have the added benef...
2018 Sep 11
0
Re: [PATCH nbdkit 4/4] tests: Add a helper function which waits for nbdkit to start up.
...g wrong with the change,
> although it might be worth a mention in the commit message as
> intentional.
I'm not too worried about this since it should cause only a minor
increase in time.
> I'm also seeing a common pattern of assigning pid=$(cat file.pid)
> right after calling start_nbdkt. Would it be worth changing the
> signature of start_nbdkit() to also populate a pid variable on
> success, as in:
>
> start_nbdkit blocksize1.pid pid1 myarg1
>
> start_nbdkit()
> {
> pidfile=$1
> pidvar=$2
> shift 2
> ...
> pid=$(cat $pidfile)
>...
2018 Sep 11
7
[PATCH nbdkit 0/4] tests: Move common functions into tests/functions.sh
Combine much common code into tests/functions.sh.
Patch 1: Preparation for patch 3.
Patch 2: Fix a long-standing bug in how man pages links are generated.
Patch 3: Common code for iterating a test function over every plugin.
Patch 4: Common code for starting nbdkit in a test and waiting for the
PID file to appear. This is the largest and most complex of
the patches but is