search for: st_ex_mode

...ectory: stat struct differs for " > 3642 "directory %s.\n", > 3643 smb_fname_str_dbg(smb_dname))); > 3644 fd_close(fsp); > (gdb) p smb_dname->st > $1 = {st_ex_dev = 64512, st_ex_ino = 44701075, st_ex_mode = 16877, > st_ex_nlink = 2, st_ex_uid = 50133, st_ex_gid = 50133, st_ex_rdev = 0, > st_ex_size = 0, st_ex_atime = {tv_sec = 1457488009, tv_nsec = 820161188}, > st_ex_mtime = {tv_sec = 1457488009, tv_nsec = 820161188}, st_ex_ctime = { > tv_sec = 1457488009, tv_nsec = 820161188}...

...DEBUG(5,("open_directory: stat struct differs for " 3642 "directory %s.\n", 3643 smb_fname_str_dbg(smb_dname))); 3644 fd_close(fsp); (gdb) p smb_dname->st $1 = {st_ex_dev = 64512, st_ex_ino = 44701075, st_ex_mode = 16877, st_ex_nlink = 2, st_ex_uid = 50133, st_ex_gid = 50133, st_ex_rdev = 0, st_ex_size = 0, st_ex_atime = {tv_sec = 1457488009, tv_nsec = 820161188}, st_ex_mtime = {tv_sec = 1457488009, tv_nsec = 820161188}, st_ex_ctime = { tv_sec = 1457488009, tv_nsec = 820161188}, st_ex_btime = {...

...& - VALID_STAT(full_fname->st) && + if (lstat_ret == -1) { + /* Can't be a DFS link. */ + int saved_errno = errno; + TALLOC_FREE(full_fname); + errno = saved_errno; + return -1; + } + if (VALID_STAT(full_fname->st) && S_ISLNK(full_fname->st.st_ex_mode)) { fsp->fsp_name->st = full_fname->st; }

...??????????? int saved_errno = errno; > +??????????? TALLOC_FREE(full_fname); > +??????????? errno = saved_errno; Can TALLOC_FREE change errno? > +??????????? return -1; > +??????? } > +??????? if (VALID_STAT(full_fname->st) && > ???????????? S_ISLNK(full_fname->st.st_ex_mode)) { > ???????????? fsp->fsp_name->st = full_fname->st; > ???????? } > Thank you very much, Jeremy! /mjt -- GPG Key transition (from rsa2048 to rsa4096) since 2024-04-24. New key: rsa4096/61AD3D98ECDF2C8E 9D8B E14E 3F2A 9DD7 9199 28F1 61AD 3D98 ECDF 2C8E Old key: rsa2048/...

...filesystem SD. */ > - TALLOC_FREE(pdesc_next); > + TALLOC_FREE(psd_fs); > } else { > SMB_STRUCT_STAT sbuf; > SMB_STRUCT_STAT *psbuf = &sbuf; > @@ -760,7 +760,7 @@ static NTSTATUS get_nt_acl_internal(vfs_handle_struct *handle, > is_directory = S_ISDIR(psbuf->st_ex_mode); > > if (ignore_file_system_acl) { > - TALLOC_FREE(pdesc_next); > + TALLOC_FREE(psd_fs); > status = make_default_filesystem_acl(mem_ctx, > smb_fname->base_name, > psbuf, > -- > 2.7.4 > > > From b77ee317be4b59aaffe13aaddd3262ec64e...

On Fri, Aug 26, 2016 at 06:33:26PM +0200, Ralph Böhme via samba wrote: > On Thu, Aug 25, 2016 at 12:14:00PM -0700, Jeremy Allison wrote: > > On Wed, Aug 24, 2016 at 04:06:42PM +0200, Ralph Böhme via samba wrote: > > > > > > Yeah, as much as I'd like to avoid adding a new option, I guess we > > > have to do something about it, my latest take on this is >

07.06.2024 20:52, Jeremy Allison wrote: > Fair enough. Can you post a minimal smb.conf and directory > setup that reproduces the problem and how to demo it with smbclient > command lines please ? I know I'm asking to be spoon-fed but my time for > Samba these days is quite limited and this would aid immensely > in creating a properly tested fix. You're not asking to be

...filesystem SD. */ > - TALLOC_FREE(pdesc_next); > + TALLOC_FREE(psd_fs); > } else { > SMB_STRUCT_STAT sbuf; > SMB_STRUCT_STAT *psbuf = &sbuf; > @@ -760,7 +760,7 @@ static NTSTATUS get_nt_acl_internal(vfs_handle_struct *handle, > is_directory = S_ISDIR(psbuf->st_ex_mode); > > if (ignore_file_system_acl) { > - TALLOC_FREE(pdesc_next); > + TALLOC_FREE(psd_fs); > status = make_default_filesystem_acl(mem_ctx, > smb_fname->base_name, > psbuf, > -- > 2.7.4 > > > From 0d2d6afb990c382a508da1823631e1b76af...

On Fri, Aug 26, 2016 at 04:03:49PM -0700, Jeremy Allison wrote: > On Fri, Aug 26, 2016 at 02:46:19PM -0700, Jeremy Allison via samba wrote: > > On Fri, Aug 26, 2016 at 06:44:05PM +0200, Ralph Böhme wrote: > > > > > > Cheerio! > > > -slow > > > > Still reviewing this - but a few things that will need changing: > > > > When adding the