search for: sshpam_init

...shpam_set_maxtries_reached(1); if (sshpam_err != PAM_SUCCESS) goto auth_fail; + sshpam_err = check_pam_user(sshpam_authctxt); + if (sshpam_err != PAM_SUCCESS) + goto auth_fail; if (!do_pam_account()) { sshpam_err = PAM_ACCT_EXPIRED; @@ -686,8 +711,7 @@ sshpam_cleanup(void) static int sshpam_init(struct ssh *ssh, Authctxt *authctxt) { - const char *pam_user, *user = authctxt->user; - const char **ptr_pam_user = &pam_user; + const char *user = authctxt->user; int r; if (options.pam_service_name == NULL) @@ -706,9 +730,8 @@ sshpam_init(struct ssh *ssh, Authctxt *authctxt) }...

...t redhat.com today I ran into problems with PAM and bumped into the function do_pam_set_tty(), which is defined, but never used, if I see right: $ git grep do_pam_set_tty auth-pam.c:do_pam_set_tty(const char *tty) auth-pam.h:void do_pam_set_tty(const char *); There is basically duplicate code in sshpam_init(). In the git, last usage of this function was removed in 2008 [1]. I don't think it makes sense to keep it. [1] https://github.com/openssh/openssh-portable/commit/52358d6d -- You are receiving this mail because: You are watching the assignee of the bug.

...shpam_thread': auth-pam.c:365: warning: passing arg 3 of `pam_get_item' from incompatible pointer type auth-pam.c:370: warning: assignment from incompatible pointer type auth-pam.c: At top level: auth-pam.c:460: warning: initialization from incompatible pointer type auth-pam.c: In function `sshpam_init': auth-pam.c:491: warning: passing arg 3 of `pam_get_item' from incompatible pointer type auth-pam.c: At top level: auth-pam.c:842: warning: initialization from incompatible pointer type auth-pam.c:908: warning: initialization from incompatible pointer type auth-pam.c:1034: warning: initial...