search for: sshbuf_dup_string

In sshconnect.c there are two global variables for server_version_string client_version_string. These are used just in a few functions and can easily be passed as parameters. Also, there is a strange construct, where their memory is allocated to the global pointers, then copies of these pointers are assigned to the kex structure. The kex_free finally frees them via cleanup of the kex

I hacked zstd support into OpenSSH a while ago and just started to clean it up in the recent days. The cleanup includes configuration support among other things that I did not have. During testing I noticed the following differences compared to zlib: - highly interactive shell output (as in refreshed at a _very_ high rate) may result in higher bandwidth compared to zlib. Since zstd is quicker

I added ZSTD support to OpenSSH roughly over a year and I've been playing with it ever since. The nice part is that ZSTD achieves reasonable compression (like zlib) but consumes little CPU so it is unlikely that compression becomes the bottle neck of a transfer. The compression overhead (CPU) is negligible even when uncompressed data is tunneled over the SSH connection (SOCKS proxy, port

... and I guess your next question will be about compilation environment, so: ``` $ gcc --version gcc (Gentoo 13.2.1_p20240210 p14) 13.2.1 20240210 Copyright (C) 2023 Free Software Foundation, Inc. This is free software; see the source for copying conditions. There is NO warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. ``` I'm running on gentoo. I tested that the

...p("shell"); + r = match_pattern_list(criteria, arg, 0) == 1; + if (r == (negate ? 1 : 0)) + this_result = result = 0; + } else if (strcasecmp(attrib, "remotecommand") == 0) { + if (rcommand != NULL && sshbuf_len(rcommand) > 0) { + if ((criteria = + sshbuf_dup_string(rcommand)) == NULL) + fatal_f("dup command failed"); + } else if (options->remote_command != NULL) + criteria = xstrdup(options->remote_command); + else + criteria = xstrdup("none"); + r = match_pattern_list(criteria, arg, 0) == 1; + if (r == (negate ? 1...

...p("shell"); + r = match_pattern_list(criteria, arg, 0) == 1; + if (r == (negate ? 1 : 0)) + this_result = result = 0; + } else if (strcasecmp(attrib, "remotecommand") == 0) { + if (rcommand != NULL && sshbuf_len(rcommand) > 0) { + if ((criteria = + sshbuf_dup_string(rcommand)) == NULL) + fatal_f("dup command failed"); + } else if (options->remote_command != NULL) + criteria = xstrdup(options->remote_command); + else + criteria = xstrdup("none"); + r = match_pattern_list(criteria, arg, 0) == 1; + if (r == (negate ? 1...

Hey there, I often want different behavior in my ssh client depending on whether I'm logging into an interactive session or running a remote non-interactive command. We can see at, say, https://unix.stackexchange.com/a/499562/305714 that this isn't a unique wish, and existing solutions are kind of baroque. Typical reasons to do this are to immediately go into a screen or tmux session; for