search for: ssh_remote_port

..._input(struct ssh *ssh, int connection_in) if (errno == EAGAIN || errno == EINTR || errno == EWOULDBLOCK) return 0; if (errno == EPIPE) { - verbose("Connection closed by %.100s port %d", + logit("Connection closed by %.100s port %d", ssh_remote_ipaddr(ssh), ssh_remote_port(ssh)); return -1; } - verbose("Read error from remote host %s port %d: %s", + logit("Read error from remote host %s port %d: %s", ssh_remote_ipaddr(ssh), ssh_remote_port(ssh), strerror(errno)); cleanup_exit(255);

On Thu, May 30, 2024 at 6:02?PM Opty <opty77 at gmail.com> wrote: > On Thu, May 30, 2024 at 3:03?AM Damien Miller <djm at mindrot.org> wrote: > > On Wed, 29 May 2024, Opty wrote: > > > On Mon, May 27, 2024 at 4:18?AM Damien Miller <djm at mindrot.org> wrote: > > > > Yeah, you're adding a new thing that will be logged. IMO you should > >

...return 0; > if (errno == EPIPE) { > - verbose("Connection closed by %.100s port %d", > + logit("Connection closed by %.100s port %d", > ssh_remote_ipaddr(ssh), ssh_remote_port(ssh)); > return -1; > } > - verbose("Read error from remote host %s port %d: %s", > + logit("Read error from remote host %s port %d: %s", > ssh_remote_ipaddr(ssh), ssh_remote_p...

In sshconnect.c there are two global variables for server_version_string client_version_string. These are used just in a few functions and can easily be passed as parameters. Also, there is a strange construct, where their memory is allocated to the global pointers, then copies of these pointers are assigned to the kex structure. The kex_free finally frees them via cleanup of the kex