search for: ssh_alloc_session_state

..., so we can place that sequence there. sshd.c calls the old function only once during initialization (in main()) so it does appear to arrive there while active_state is still NULL. So when called with active_state==NULL, essentially the old function is roughly equivalent to: struct *ssh = ssh_alloc_session_state(); ssh_packet_set_connection(ssh, fd_in, fd_out) active_state = ssh; ssh.c handles this in a similar way. It calls ssh_alloc_session_state_state directly then setting the active_state pointer with the result (ssh.c line 2113). When doing this in sshd.c too, which I think is pretty st...

In sshconnect.c there are two global variables for server_version_string client_version_string. These are used just in a few functions and can easily be passed as parameters. Also, there is a strange construct, where their memory is allocated to the global pointers, then copies of these pointers are assigned to the kex structure. The kex_free finally frees them via cleanup of the kex

...ea2d17413f2d9730dd2a19575ff86b9b6a > > Reverting it gets rid of the hang and the testsuite runs to completion > with no errors. Thanks for the analysis. I think this fixes it. diff --git a/packet.c b/packet.c index 7ddebeb..6755e74 100644 --- a/packet.c +++ b/packet.c @@ -263,8 +263,8 @@ ssh_alloc_session_state(void) int ssh_packet_is_rekeying(struct ssh *ssh) { - return ssh->state->rekeying || - (ssh->kex != NULL && ssh->kex->done == 0); + return compat20 && + (ssh->state->rekeying || (ssh->kex != NULL && ssh->kex->done == 0)); } /*

Hi, OpenSSH 7.2 is almost ready for release, so we would appreciate testing on as many platforms and systems as possible. This release contains many bugfixes and several new features. The OpenBSD version is available in CVS HEAD: http://www.openbsd.org/anoncvs.html Portable OpenSSH is available via Git at https://anongit.mindrot.org/openssh.git/ or via a mirror on Github at