search for: src_sp

...t current style guidelines advise not to. http://llvm.org/docs/CodingStandards.html#doxygen-use-in-documentation-comments + BuildMI(MBB, I, I->getDebugLoc(), TII->get(Tile::ADD) + ,I->getOperand(0).getReg()) + .addReg(Tile::ZERO) + .addReg(src_sp); +unsigned TileInstrInfo:: +isLoadFromStackSlot(const MachineInstr *MI, int &FrameIndex) const You have some weird formatting here and there. You could try clang-format to pretty-print your code automatically. The patch is also missing documentation bits. At the very least, a paragraph fo...

...not to. > > http://llvm.org/docs/CodingStandards.html#doxygen-use-in-documentation-comments > > + BuildMI(MBB, I, I->getDebugLoc(), TII->get(Tile::ADD) > + ,I->getOperand(0).getReg()) > + .addReg(Tile::ZERO) > + .addReg(src_sp); > > +unsigned TileInstrInfo:: > +isLoadFromStackSlot(const MachineInstr *MI, int &FrameIndex) const > > You have some weird formatting here and there. You could try > clang-format to pretty-print your code automatically. > > The patch is also missing documentation bit...

On 03/01/2013 10:42 PM, Hal Finkel wrote: > > As some of the llvm modules are in active development, for example MC > Layer, we want to return code to community repository first, so that > it will be easy to keep pace with llvm main tree. > I think this makes sense; but my impression is that the community will want a clear idea that this will be maintained and improved for the

...ines advise not to. >> >> http://llvm.org/docs/CodingStandards.html#doxygen-use-in-documentation-comments >> >> >> + BuildMI(MBB, I, I->getDebugLoc(), TII->get(Tile::ADD) >> + ,I->getOperand(0).getReg()) >> + .addReg(Tile::ZERO) >> + .addReg(src_sp); >> >> +unsigned TileInstrInfo:: >> +isLoadFromStackSlot(const MachineInstr *MI, int &FrameIndex) const >> >> You have some weird formatting here and there. You could try >> clang-format to pretty-print your code automatically. >> >> The patch is...