search for: space_var

...b/scripts/ovirt-config-storage index be5aec0..671ad7d 100755 --- a/scripts/ovirt-config-storage +++ b/scripts/ovirt-config-storage @@ -36,15 +36,17 @@ logging_min_size=5 data_min_size=5 swap_min_size=5 -get_selected_drive_size() +get_drive_size() { - start_log + local drive=$1 + local space_var=$2 + local size= - local udi=$(hal-find-by-property --key block.device --string $DRIVE) + local udi=$(hal-find-by-property --key block.device --string $drive) if [ -z "$udi" ]; then # If hal didn't find the device, it could be a virtio block device #...

...'exit $?' 1 2 13 15 @@ -36,8 +37,12 @@ logging_min_size=5 data_min_size=5 swap_min_size=5 +# Gets the drive's size and sets the supplied variable. +# $1 - the drive +# $2 - the variable get_drive_size() { + debug "get_drive_size: start" local drive=$1 local space_var=$2 @@ -70,11 +75,36 @@ get_drive_size() fi size=$(echo "scale=0; $size / (1024 * 1024)" | bc -l) - echo "$drive ($size MB)" + eval $space_var=$size + + debug "::size=$size" + + debug "get_drive_size: exit" +} + +print_drive_size () +...

This patch includes a fix to no longer list devices with 0 bytes of storage, such as removeable media devices with no media present.

...vice "$dm_dev" mpath_device if [ -z "$mpath_device" ]; then - mpath_device=$dev + mpath_device="$dev" fi - eval $mpath_var=$mpath_device + eval $mpath_var="$mpath_device" } get_drive_size() { - local drive=$1 - local space_var=$2 + local drive="$1" + local space_var="$2" local size= - local udi=$(hal-find-by-property --key block.device --string $drive) + local udi=$(hal-find-by-property --key block.device --string "$drive") # if more than one UDI was found then iterate...

This patch just includes the repo name in the subject.

...#39; ' '\n' | sort -u | xargs) diff --git a/scripts/ovirt-config-storage b/scripts/ovirt-config-storage index ce9707c..5b2c1e9 100755 --- a/scripts/ovirt-config-storage +++ b/scripts/ovirt-config-storage @@ -111,41 +111,11 @@ get_drive_size() local drive="$1" local space_var="$2" - local size= - local udi=$(hal-find-by-property --key block.device --string "$drive") - # if more than one UDI was found then iterate over them to find the base device - if [[ "${udi}" =~ \$ ]]; then - udi=$(echo "$udi" | sed '...

This one incorporates feedback from mburns and apevec to ensure that all multipath devices are excluded in the list of available drives. Only drives with an identified bus are included in the list now.

This set of patches introduces support for multipath devices for storage. Comments and suggestions are appreciated. Mike

...size_cmd = "sfdisk -s \"%s\" 2>null)" % drive +# size = subprocess.Popen(size_cmd, shell=True, stdout=PIPE, stderr=STDOUT) +# size_output = size.stdout.read() +# size_output = size_output / 1024 +# log("%s (%s MB)") % (drive, size_output) +# if not space_var is None: +# return space_var + +def check_existing_hostvg(install_dev): + if install_dev is None: + devices="$(pvs --separator=\" \" -o pv_name,vg_name --noheadings | grep \"HostVG\" | cut -f1)" + else: + devices="$(pvs --separator=\&quo...