search for: sourcemodul

...//Find out which logical dylib contains our symbol + auto LDI = LogicalDylibs.begin(); + for (auto LDE = LogicalDylibs.end(); LDI != LDE; ++LDI) { + if (auto LMResources = LDI->getLogicalModuleResourcesForSymbol(FuncName, false)) { + Module &SrcM = LMResources->SourceModule->getResource(); + std::string CalledFnName = mangle(FuncName, SrcM.getDataLayout()); + if (auto EC = LMResources->StubsMgr->updatePointer(CalledFnName, FnBodyAddr)) { + return 0; + } + else + return FnBodyAddr; +...

...ur symbol >> + auto LDI = LogicalDylibs.begin(); >> + for (auto LDE = LogicalDylibs.end(); LDI != LDE; ++LDI) { >> + if (auto LMResources = >> LDI->getLogicalModuleResourcesForSymbol(FuncName, false)) { >> + Module &SrcM = LMResources->SourceModule->getResource(); >> + std::string CalledFnName = mangle(FuncName, >> SrcM.getDataLayout()); >> + if (auto EC = >> LMResources->StubsMgr->updatePointer(CalledFnName, FnBodyAddr)) { >> + return 0; >> + } >...

...t; this functionality, or do you have any ideas for a cleaner way to do this? My apologies - I wasn't very clear in my description of the issue. The only sense in which your original patch was tightly coupled was that it had getLogicalModuleResourcesForSymbol accessing LogicalModuleResources::SourceModule, which isn't a required part of the 'LogicalModuleResources' interface at the moment. The alternative implementation of getLogicalModuleResourcesForSymbol doesn't have that coupling, and since it works for you I think the issue is resolved. I've committed your patch with my sug...

...cal dylib contains our symbol > + auto LDI = LogicalDylibs.begin(); > + for (auto LDE = LogicalDylibs.end(); LDI != LDE; ++LDI) { > + if (auto LMResources = > LDI->getLogicalModuleResourcesForSymbol(FuncName, false)) { > + Module &SrcM = LMResources->SourceModule->getResource(); > + std::string CalledFnName = mangle(FuncName, > SrcM.getDataLayout()); > + if (auto EC = > LMResources->StubsMgr->updatePointer(CalledFnName, FnBodyAddr)) { > + return 0; > + } > + else >...

...t; + auto LDI = LogicalDylibs.begin(); >>> + for (auto LDE = LogicalDylibs.end(); LDI != LDE; ++LDI) { >>> + if (auto LMResources = >>> LDI->getLogicalModuleResourcesForSymbol(FuncName, false)) { >>> + Module &SrcM = LMResources->SourceModule->getResource(); >>> + std::string CalledFnName = mangle(FuncName, >>> SrcM.getDataLayout()); >>> + if (auto EC = >>> LMResources->StubsMgr->updatePointer(CalledFnName, FnBodyAddr)) { >>> + return 0; >>...