search for: source_virtio_net

On Tue, Feb 09, 2016 at 05:53:55PM +0300, Roman Kagan wrote: > +and s_nic_model = Source_rtl8139 | Source_e1000 | Source_virtio_net [...] > +and source_video = Source_Cirrus | Source_QXL As you know there could be a lot of other input devices. At the moment the code basically ignores these (but it prints a warning "unknown [video|network] adapter model %s ignored"). I think we should only print warnings when tha...

...nvz.org>, libguestfs@redhat.com | Sent: Wednesday, February 10, 2016 2:15:23 AM | Subject: Re: [Libguestfs] [PATCH 1/4] v2v: collect source network and video adapter types | | On Tue, Feb 09, 2016 at 05:53:55PM +0300, Roman Kagan wrote: | > +and s_nic_model = Source_rtl8139 | Source_e1000 | Source_virtio_net | [...] | > +and source_video = Source_Cirrus | Source_QXL | | As you know there could be a lot of other input devices. | | At the moment the code basically ignores these (but it prints a | warning "unknown [video|network] adapter model %s ignored"). I think | we should only print w...

...et parse_libvirt_xml ?conn xml = | Some "00:00:00:00:00:00" (* thanks, VMware *) -> None | Some mac -> Some mac in + let model = + match xpath_string "model/@type" with + | None -> None + | Some "virtio" -> Some Source_virtio_net + | Some "e1000" -> Some Source_e1000 + | Some "rtl8139" -> Some Source_rtl8139 + | Some model -> + warning (f_"unknown network adapter model %s ignored") model; + None + in + let vnet_type = match...

...et parse_libvirt_xml ?conn xml = | Some "00:00:00:00:00:00" (* thanks, VMware *) -> None | Some mac -> Some mac in + let model = + match xpath_string "model/@type" with + | None -> None + | Some "virtio" -> Some Source_virtio_net + | Some "e1000" -> Some Source_e1000 + | Some "rtl8139" -> Some Source_rtl8139 + | Some model -> Some (Source_other_nic model) in + let vnet_type = match xpath_string "@type" with | Some "network" ->...

...et parse_libvirt_xml ?conn xml = | Some "00:00:00:00:00:00" (* thanks, VMware *) -> None | Some mac -> Some mac in + let model = + match xpath_string "model/@type" with + | None -> None + | Some "virtio" -> Some Source_virtio_net + | Some "e1000" -> Some Source_e1000 + | Some "rtl8139" -> Some Source_rtl8139 + | Some model -> Some (Source_other_nic model) in + let vnet_type = match xpath_string "@type" with | Some "network" ->...

..._vnet_orig : string; (** Original network (if we map it). *) s_vnet_type : vnet_type; (** Source network type. *) } -(** Network adapter models. *) +(** Network adapter models (in ascending order of preference). *) and s_nic_model = Source_rtl8139 | Source_e1000 | Source_virtio_net (** Network interfaces. *) and vnet_type = Bridge | Network @@ -107,7 +107,7 @@ and s_display_listen = | LAddress of string (** Listen address. *) | LNetwork of string (** Listen network. *) -(** Video adapter model. *) +(** Video adapter model (in ascending order...

...al network (if we map it). *) s_vnet_type : vnet_type; (** Source network type. *) } -(** Network adapter models. *) +(** Network adapter models (in ascending order of preference). *) and s_nic_model = Source_other_nic of string | Source_rtl8139 | Source_e1000 | Source_virtio_net (** Network interfaces. *) @@ -108,7 +108,7 @@ and s_display_listen = | LAddress of string (** Listen address. *) | LNetwork of string (** Listen network. *) -(** Video adapter model. *) +(** Video adapter model (in ascending order of preference). *) and source_vid...

The decision on which device type to use for disks, network and video cards on output used to be taken deep inside the converting functions. This is not always desirable. In particular, there are scenarios when this decision is made before the convertion takes place. E.g. in in-place mode, the decisions are taken and the output VM configuration is created outside of v2v tool. This patchset

...> s_vnet_type : vnet_type; (** Source network type. *) > } > -(** Network adapter models. *) > +(** Network adapter models (in ascending order of preference). *) > and s_nic_model = Source_other_nic of string | > Source_rtl8139 | Source_e1000 | Source_virtio_net > (** Network interfaces. *) > @@ -108,7 +108,7 @@ and s_display_listen = > | LAddress of string (** Listen address. *) > | LNetwork of string (** Listen network. *) > > -(** Video adapter model. *) > +(** Video adapter model (in ascending order...

The decision on which device type to use for disks, network and video cards on output used to be taken deep inside the converting functions. This is not always desirable. In particular, there are scenarios when this decision is made before the convertion takes place. E.g. in in-place mode, the decisions are taken and the output VM configuration is created outside of v2v tool. This patchset

The decision on which device type to use for disks, network and video cards on output used to be taken deep inside the converting functions. This is not always desirable. In particular, there are scenarios when this decision is made before the convertion takes place. E.g. in in-place mode, the decisions are taken and the output VM configuration is created outside of v2v tool. This patchset

The decision on which device type to use for disks, network and video cards on output used to be taken deep inside the converting functions. This is not always desirable. In particular, there are scenarios when this decision is made before the convertion takes place. E.g. in in-place mode, the decisions are taken and the output VM configuration is created outside of v2v tool. This patchset

...and None > > + * being smaller than Some anything *) > > + let best_net_type = > > + List.fold_left max None > > + (List.map (fun nic -> nic.s_nic_model) source.s_nics) in > > + let net_type = > > + match best_net_type with > > + | Some Source_virtio_net -> Some Virtio_net > > + | Some Source_e1000 -> Some E1000 > > + | Some Source_rtl8139 -> Some RTL8139 > > + | Some Source_other_nic _ | None -> None in > > + > > + let video = > > + match source.s_video with > > + | Some Source_...

Deep in the discussion of this bug, unfortunately mostly in private comments: https://bugzilla.redhat.com/show_bug.cgi?id=1594515 we decided it'd be more flexible for RHV if we had a way to map individual NICs to target networks and bridges. This can be done by adding a new --mac option so you can specify the exact mapping you need: $ virt-v2v [...] \ --mac

...'%s'") + | Some t -> error (f_"source has unsupported hard disk type ‘%s’") (string_of_controller t) | None -> error (f_"source has unrecognized hard disk type") in @@ -792,7 +792,7 @@ and rcaps_from_source source = | Some Source_virtio_net -> Some Virtio_net | Some Source_e1000 -> Some E1000 | Some Source_rtl8139 -> Some RTL8139 - | Some t -> error (f_"source has unsupported network adapter model '%s'") + | Some t -> error (f_"source has unsupported network adapter model ‘%s’&quot...