search for: source_other_video

...rrent_context xpathctx node; + match xpath_string "model/@type" with + | None -> None + | Some "qxl" | Some "virtio" -> Some Source_QXL + | Some "cirrus" | Some "vga" -> Some Source_Cirrus + | Some model -> Some (Source_other_video model) + ) in + (* Sound card. *) let sound = let obj = Xml.xpath_eval_expression xpathctx "/domain/devices/sound" in @@ -329,6 +346,14 @@ let parse_libvirt_xml ?conn xml = | Some "00:00:00:00:00:00" (* thanks, VMware *) -> None | Some mac -&gt...

...rrent_context xpathctx node; + match xpath_string "model/@type" with + | None -> None + | Some "qxl" | Some "virtio" -> Some Source_QXL + | Some "cirrus" | Some "vga" -> Some Source_Cirrus + | Some model -> Some (Source_other_video model) + ) in + (* Sound card. *) let sound = let obj = Xml.xpath_eval_expression xpathctx "/domain/devices/sound" in @@ -329,6 +346,14 @@ let parse_libvirt_xml ?conn xml = | Some "00:00:00:00:00:00" (* thanks, VMware *) -> None | Some mac -&gt...

...Network interfaces. *) @@ -108,7 +108,7 @@ and s_display_listen = | LAddress of string (** Listen address. *) | LNetwork of string (** Listen network. *) -(** Video adapter model. *) +(** Video adapter model (in ascending order of preference). *) and source_video = Source_other_video of string | Source_Cirrus | Source_QXL diff --git a/v2v/v2v.ml b/v2v/v2v.ml index c828e48..608150f 100644 --- a/v2v/v2v.ml +++ b/v2v/v2v.ml @@ -82,11 +82,17 @@ let rec main () = ); let keep_serial_console = output#keep_serial_console in - let rcaps = { -...

...8,7 +108,7 @@ and s_display_listen = > | LAddress of string (** Listen address. *) > | LNetwork of string (** Listen network. *) > > -(** Video adapter model. *) > +(** Video adapter model (in ascending order of preference). *) > and source_video = Source_other_video of string | > Source_Cirrus | Source_QXL > > diff --git a/v2v/v2v.ml b/v2v/v2v.ml > index c828e48..608150f 100644 > --- a/v2v/v2v.ml > +++ b/v2v/v2v.ml > @@ -82,11 +82,17 @@ let rec main () = > ); > > let keep_serial_console = output#keep_...

...b24..bf4365c 100644 --- a/v2v/types.ml +++ b/v2v/types.ml @@ -82,9 +82,11 @@ and source_display = { } and s_display_type = Window | VNC | Spice and s_display_listen = - | LNone + | LNoListen | LAddress of string | LNetwork of string + | LSocket of string + | LNone and source_video = Source_other_video of string | Source_Cirrus | Source_QXL @@ -227,9 +229,11 @@ and string_of_source_display { s_display_type = typ; (match keymap with None -> "" | Some km -> " " ^ km) (match password with None -> "" | Some _ -> " with passw...

The decision on which device type to use for disks, network and video cards on output used to be taken deep inside the converting functions. This is not always desirable. In particular, there are scenarios when this decision is made before the convertion takes place. E.g. in in-place mode, the decisions are taken and the output VM configuration is created outside of v2v tool. This patchset

...diff --git a/v2v/types.ml b/v2v/types.ml index 3c92357..d802e19 100644 --- a/v2v/types.ml +++ b/v2v/types.ml @@ -85,7 +85,7 @@ and s_display_listen = | LNoListen | LAddress of string | LNetwork of string - | LSocket of string + | LSocket of string option | LNone and source_video = Source_other_video of string | @@ -232,7 +232,8 @@ and string_of_source_display { s_display_type = typ; | LNoListen -> "" | LAddress a -> sprintf " listening on address %s" a | LNetwork n -> sprintf " listening on network %s" n - | LSocket s -> sprintf &quot...

...ow we don't always obey that rule right now, but I think it's still a good rule ...) So I think a better way to do it would be: and s_nic_model = | Source_rtl8139 | Source_e1000 | Source_virtio_net | Source_other_nic of string and source_video = | Source_Cirrus | Source_QXL | Source_other_video of string and then change the match code to be something like: let model = match xpath_string "model/@type" with | None -> None | Some "virtio" -> Some Source_virtio_net | Some "e1000" -> Some Source_e1000 | Some "rtl8139" -&g...

...e Source_rtl8139 -> Some RTL8139 > > + | Some Source_other_nic _ | None -> None in > > + > > + let video = > > + match source.s_video with > > + | Some Source_QXL -> Some QXL > > + | Some Source_Cirrus -> Some Cirrus > > + | Some Source_other_video _ | None -> None in > > + > > + { > > + rcaps_block_bus = block_type; > > + rcaps_net_bus = net_type; > > + rcaps_video = video; > > + } > > + > > let () = run_main_and_handle_errors main > > It's a bit surprising, because I...

...obey that rule right now, but I think it's still a good | rule ...) | | So I think a better way to do it would be: | | and s_nic_model = | | Source_rtl8139 | Source_e1000 | Source_virtio_net | | Source_other_nic of string | | and source_video = | | Source_Cirrus | Source_QXL | | Source_other_video of string | | and then change the match code to be something like: | | let model = | match xpath_string "model/@type" with | | None -> None | | Some "virtio" -> Some Source_virtio_net | | Some "e1000" -> Some Source_e1000 | | Some &quot...

The decision on which device type to use for disks, network and video cards on output used to be taken deep inside the converting functions. This is not always desirable. In particular, there are scenarios when this decision is made before the convertion takes place. E.g. in in-place mode, the decisions are taken and the output VM configuration is created outside of v2v tool. This patchset

The decision on which device type to use for disks, network and video cards on output used to be taken deep inside the converting functions. This is not always desirable. In particular, there are scenarios when this decision is made before the convertion takes place. E.g. in in-place mode, the decisions are taken and the output VM configuration is created outside of v2v tool. This patchset

The decision on which device type to use for disks, network and video cards on output used to be taken deep inside the converting functions. This is not always desirable. In particular, there are scenarios when this decision is made before the convertion takes place. E.g. in in-place mode, the decisions are taken and the output VM configuration is created outside of v2v tool. This patchset

https://bugzilla.redhat.com/show_bug.cgi?id=1441197