search for: source_cirrus

On Tue, Feb 09, 2016 at 05:53:55PM +0300, Roman Kagan wrote: > +and s_nic_model = Source_rtl8139 | Source_e1000 | Source_virtio_net [...] > +and source_video = Source_Cirrus | Source_QXL As you know there could be a lot of other input devices. At the moment the code basically ignores these (but it prints a warning "unknown [video|network] adapter model %s ignored"). I think we should only print warnings when that information is useful and/or actionable for...

...obj_node obj 0 in + + Xml.xpathctx_set_current_context xpathctx node; + match xpath_string "model/@type" with + | None -> None + | Some "qxl" | Some "virtio" -> Some Source_QXL + | Some "cirrus" | Some "vga" -> Some Source_Cirrus + | Some model -> + warning (f_"unknown video adapter model %s ignored") model; + None + ) in + (* Sound card. *) let sound = let obj = Xml.xpath_eval_expression xpathctx "/domain/devices/sound" in @@ -329,6 +348,17 @@ let parse_libvirt_xml...

...obj_node obj 0 in + + Xml.xpathctx_set_current_context xpathctx node; + match xpath_string "model/@type" with + | None -> None + | Some "qxl" | Some "virtio" -> Some Source_QXL + | Some "cirrus" | Some "vga" -> Some Source_Cirrus + | Some model -> Some (Source_other_video model) + ) in + (* Sound card. *) let sound = let obj = Xml.xpath_eval_expression xpathctx "/domain/devices/sound" in @@ -329,6 +346,14 @@ let parse_libvirt_xml ?conn xml = | Some "00:00:00:00:00:00" (* th...

...obj_node obj 0 in + + Xml.xpathctx_set_current_context xpathctx node; + match xpath_string "model/@type" with + | None -> None + | Some "qxl" | Some "virtio" -> Some Source_QXL + | Some "cirrus" | Some "vga" -> Some Source_Cirrus + | Some model -> Some (Source_other_video model) + ) in + (* Sound card. *) let sound = let obj = Xml.xpath_eval_expression xpathctx "/domain/devices/sound" in @@ -329,6 +346,14 @@ let parse_libvirt_xml ?conn xml = | Some "00:00:00:00:00:00" (* th...

...February 10, 2016 2:15:23 AM | Subject: Re: [Libguestfs] [PATCH 1/4] v2v: collect source network and video adapter types | | On Tue, Feb 09, 2016 at 05:53:55PM +0300, Roman Kagan wrote: | > +and s_nic_model = Source_rtl8139 | Source_e1000 | Source_virtio_net | [...] | > +and source_video = Source_Cirrus | Source_QXL | | As you know there could be a lot of other input devices. | | At the moment the code basically ignores these (but it prints a | warning "unknown [video|network] adapter model %s ignored"). I think | we should only print warnings when that information is useful and/or |...

...type = Bridge | Network @@ -107,7 +107,7 @@ and s_display_listen = | LAddress of string (** Listen address. *) | LNetwork of string (** Listen network. *) -(** Video adapter model. *) +(** Video adapter model (in ascending order of preference). *) and source_video = Source_Cirrus | Source_QXL and source_sound = { diff --git a/v2v/v2v.ml b/v2v/v2v.ml index c828e48..7f5decf 100644 --- a/v2v/v2v.ml +++ b/v2v/v2v.ml @@ -82,11 +82,17 @@ let rec main () = ); let keep_serial_console = output#keep_serial_console in - let rcaps = { - rcaps_block_bus = None...

...isplay_listen = | LAddress of string (** Listen address. *) | LNetwork of string (** Listen network. *) -(** Video adapter model. *) +(** Video adapter model (in ascending order of preference). *) and source_video = Source_other_video of string | Source_Cirrus | Source_QXL diff --git a/v2v/v2v.ml b/v2v/v2v.ml index c828e48..608150f 100644 --- a/v2v/v2v.ml +++ b/v2v/v2v.ml @@ -82,11 +82,17 @@ let rec main () = ); let keep_serial_console = output#keep_serial_console in - let rcaps = { - rcaps_block_bus = None; - rca...

...of string (** Listen address. *) > | LNetwork of string (** Listen network. *) > > -(** Video adapter model. *) > +(** Video adapter model (in ascending order of preference). *) > and source_video = Source_other_video of string | > Source_Cirrus | Source_QXL > > diff --git a/v2v/v2v.ml b/v2v/v2v.ml > index c828e48..608150f 100644 > --- a/v2v/v2v.ml > +++ b/v2v/v2v.ml > @@ -82,11 +82,17 @@ let rec main () = > ); > > let keep_serial_console = output#keep_serial_console in > - let rcaps = { > -...

The decision on which device type to use for disks, network and video cards on output used to be taken deep inside the converting functions. This is not always desirable. In particular, there are scenarios when this decision is made before the convertion takes place. E.g. in in-place mode, the decisions are taken and the output VM configuration is created outside of v2v tool. This patchset

The decision on which device type to use for disks, network and video cards on output used to be taken deep inside the converting functions. This is not always desirable. In particular, there are scenarios when this decision is made before the convertion takes place. E.g. in in-place mode, the decisions are taken and the output VM configuration is created outside of v2v tool. This patchset

The decision on which device type to use for disks, network and video cards on output used to be taken deep inside the converting functions. This is not always desirable. In particular, there are scenarios when this decision is made before the convertion takes place. E.g. in in-place mode, the decisions are taken and the output VM configuration is created outside of v2v tool. This patchset

The decision on which device type to use for disks, network and video cards on output used to be taken deep inside the converting functions. This is not always desirable. In particular, there are scenarios when this decision is made before the convertion takes place. E.g. in in-place mode, the decisions are taken and the output VM configuration is created outside of v2v tool. This patchset

...ome Source_e1000 -> Some E1000 > > + | Some Source_rtl8139 -> Some RTL8139 > > + | Some Source_other_nic _ | None -> None in > > + > > + let video = > > + match source.s_video with > > + | Some Source_QXL -> Some QXL > > + | Some Source_Cirrus -> Some Cirrus > > + | Some Source_other_video _ | None -> None in > > + > > + { > > + rcaps_block_bus = block_type; > > + rcaps_net_bus = net_type; > > + rcaps_video = video; > > + } > > + > > let () = run_main_and_handle_e...

...pes.ml @@ -82,9 +82,11 @@ and source_display = { } and s_display_type = Window | VNC | Spice and s_display_listen = - | LNone + | LNoListen | LAddress of string | LNetwork of string + | LSocket of string + | LNone and source_video = Source_other_video of string | Source_Cirrus | Source_QXL @@ -227,9 +229,11 @@ and string_of_source_display { s_display_type = typ; (match keymap with None -> "" | Some km -> " " ^ km) (match password with None -> "" | Some _ -> " with password") (match listen with - | LNon...

...+ | Some t -> error (f_"source has unsupported network adapter model ‘%s’") (string_of_nic_model t) | None -> None in @@ -800,7 +800,7 @@ and rcaps_from_source source = match source.s_video with | Some Source_QXL -> Some QXL | Some Source_Cirrus -> Some Cirrus - | Some t -> error (f_"source has unsupported video adapter model '%s'") + | Some t -> error (f_"source has unsupported video adapter model ‘%s’") (string_of_source_video t) | None -> None in diff --git a/v2...