search for: sony_acx424akp_cmd_mode

On Wed, Feb 26, 2020 at 01:08:06PM +0100, Linus Walleij wrote: > On Wed, Feb 26, 2020 at 12:57 PM Ville Syrj?l? > <ville.syrjala at linux.intel.com> wrote: > > On Tue, Feb 25, 2020 at 10:52:25PM +0100, Linus Walleij wrote: > > > > I have long suspected that a whole bunch of the "simple" displays > > > are not simple but contains a display

...to 0 in these cases? > > Don't you always have a TE interrupt or something like that > available? Could just measure it from that if no better > information is available? Yes and I did exactly that, so that is why this comment is in the driver: static const struct drm_display_mode sony_acx424akp_cmd_mode = { (...) /* * Some desired refresh rate, experiments at the maximum "pixel" * clock speed (HS clock 420 MHz) yields around 117Hz. */ .vrefresh = 60, I got a review comment at the time saying 117 Hz was weird. We didn't reach a proper conclu...

On Tue, Feb 25, 2020 at 04:19:27PM +0100, Andrzej Hajda wrote: > On 25.02.2020 12:21, Ville Syrj?l? wrote: > > On Mon, Feb 24, 2020 at 03:14:54PM +0100, Andrzej Hajda wrote: > >> On 19.02.2020 21:35, Ville Syrjala wrote: > >>> From: Ville Syrj?l? <ville.syrjala at linux.intel.com> > >>> > >>> Get rid of mode->vrefresh and just

...should fix regardless. OK, so I went ahead a wrote a bit of cocci [1] to find the bad apples. Unfortunately it found a lot of strange stuff: panel-sony-acx424akp.c:51/sony_acx424akp_vid_mode: 60 vs. 727 (.clock=330000 .htotal=480 + 15 + 0 + 15 .vtotal=864 + 14 + 1 + 11) panel-sony-acx424akp.c:71/sony_acx424akp_cmd_mode: 60 vs. 711 (.clock=420160 .htotal=480 + 154 + 16 + 32 .vtotal=864 + 1 + 1 + 1) panel-ilitek-ili9322.c:543/srgb_320x240_mode: 60 vs. 10168 (.clock=2453500 .htotal=320 + 359 + 1 + 241 .vtotal=262) panel-ilitek-ili9322.c:587/yuv_640x320_mode: 60 vs. 7768 (.clock=2454000 .htotal=640 + 252 + 1 + 28 .vt...

....vsync_start = 864 + 14, > > .vsync_end = 864 + 14 + 1, > > .vtotal = 864 + 14 + 1 + 11, > > - .vrefresh = 60, > > .width_mm = 48, > > .height_mm = 84, > > .flags = DRM_MODE_FLAG_PVSYNC, > > @@ -81,7 +80,6 @@ static const struct drm_display_mode sony_acx424akp_cmd_mode = { > > * Some desired refresh rate, experiments at the maximum "pixel" > > * clock speed (HS clock 420 MHz) yields around 117Hz. > > */ > > - .vrefresh = 60, > > .width_mm = 48, > > .height_mm = 84, > > }; > > diff --git a/dri...

...e sony_acx424akp_vid_mode = { > .vsync_start = 864 + 14, > .vsync_end = 864 + 14 + 1, > .vtotal = 864 + 14 + 1 + 11, > - .vrefresh = 60, > .width_mm = 48, > .height_mm = 84, > .flags = DRM_MODE_FLAG_PVSYNC, > @@ -81,7 +80,6 @@ static const struct drm_display_mode sony_acx424akp_cmd_mode = { > * Some desired refresh rate, experiments at the maximum "pixel" > * clock speed (HS clock 420 MHz) yields around 117Hz. > */ > - .vrefresh = 60, > .width_mm = 48, > .height_mm = 84, > }; > diff --git a/drivers/gpu/drm/panel/panel-sony-acx565akm....

...+ 14, >>> .vsync_end = 864 + 14 + 1, >>> .vtotal = 864 + 14 + 1 + 11, >>> - .vrefresh = 60, >>> .width_mm = 48, >>> .height_mm = 84, >>> .flags = DRM_MODE_FLAG_PVSYNC, >>> @@ -81,7 +80,6 @@ static const struct drm_display_mode sony_acx424akp_cmd_mode = { >>> * Some desired refresh rate, experiments at the maximum "pixel" >>> * clock speed (HS clock 420 MHz) yields around 117Hz. >>> */ >>> - .vrefresh = 60, >>> .width_mm = 48, >>> .height_mm = 84, >>> }; >&...

...6 @@ static const struct drm_display_mode sony_acx424akp_vid_mode = { .vsync_start = 864 + 14, .vsync_end = 864 + 14 + 1, .vtotal = 864 + 14 + 1 + 11, - .vrefresh = 60, .width_mm = 48, .height_mm = 84, .flags = DRM_MODE_FLAG_PVSYNC, @@ -81,7 +80,6 @@ static const struct drm_display_mode sony_acx424akp_cmd_mode = { * Some desired refresh rate, experiments at the maximum "pixel" * clock speed (HS clock 420 MHz) yields around 117Hz. */ - .vrefresh = 60, .width_mm = 48, .height_mm = 84, }; diff --git a/drivers/gpu/drm/panel/panel-sony-acx565akm.c b/drivers/gpu/drm/panel/panel-sony-acx...

...y_acx424akp_vid_mode = { > .vsync_start = 864 + 14, > .vsync_end = 864 + 14 + 1, > .vtotal = 864 + 14 + 1 + 11, > - .vrefresh = 60, > .width_mm = 48, > .height_mm = 84, > .flags = DRM_MODE_FLAG_PVSYNC, > @@ -81,7 +80,6 @@ static const struct drm_display_mode > sony_acx424akp_cmd_mode = { > * Some desired refresh rate, experiments at the maximum "pixel" > * clock speed (HS clock 420 MHz) yields around 117Hz. > */ > - .vrefresh = 60, > .width_mm = 48, > .height_mm = 84, > }; > diff --git a/drivers/gpu/drm/panel/panel-sony-acx565akm....

...6 @@ static const struct drm_display_mode sony_acx424akp_vid_mode = { .vsync_start = 864 + 14, .vsync_end = 864 + 14 + 1, .vtotal = 864 + 14 + 1 + 11, - .vrefresh = 60, .width_mm = 48, .height_mm = 84, .flags = DRM_MODE_FLAG_PVSYNC, @@ -81,7 +80,6 @@ static const struct drm_display_mode sony_acx424akp_cmd_mode = { * Some desired refresh rate, experiments at the maximum "pixel" * clock speed (HS clock 420 MHz) yields around 117Hz. */ - .vrefresh = 60, .width_mm = 48, .height_mm = 84, }; diff --git a/drivers/gpu/drm/panel/panel-sony-acx565akm.c b/drivers/gpu/drm/panel/panel-sony-acx...

...6 @@ static const struct drm_display_mode sony_acx424akp_vid_mode = { .vsync_start = 864 + 14, .vsync_end = 864 + 14 + 1, .vtotal = 864 + 14 + 1 + 11, - .vrefresh = 60, .width_mm = 48, .height_mm = 84, .flags = DRM_MODE_FLAG_PVSYNC, @@ -81,7 +80,6 @@ static const struct drm_display_mode sony_acx424akp_cmd_mode = { * Some desired refresh rate, experiments at the maximum "pixel" * clock speed (HS clock 420 MHz) yields around 117Hz. */ - .vrefresh = 60, .width_mm = 48, .height_mm = 84, }; diff --git a/drivers/gpu/drm/panel/panel-sony-acx565akm.c b/drivers/gpu/drm/panel/panel-sony-acx...