search for: sock_seqpacket

...?????? err = total_written; >>>>> ????} >>>>> out: >>>>> +??? if (sk->sk_type == SOCK_STREAM) >>>>> +??????? err = sk_stream_error(sk, msg->msg_flags, err); >>>> >>>> Do you know why we don't need this for SOCK_SEQPACKET and SOCK_DGRAM? >>> >>> Yes, here is my explanation: >>> >>> This function checks that input error is SIGPIPE, and if so it sends SIGPIPE to the 'current' thread >>> (except case when MSG_NOSIGNAL flag is set). This behaviour is described in POSI...

...current skbuff is >>> ? not dropped. Next read attempt will use same skbuff and last offset. >>> ? Instead of 'skb_dequeue()', 'skb_peek()' + '__skb_unlink()' are used. >>> ? This behaviour was implemented before skbuff support. >>> 3) For SOCK_SEQPACKET it removes unneeded 'skb_pull()' call, because for >>> ? this type of socket each skbuff is used only once: after removing it >>> ? from socket's queue, it will be freed anyway. >>> >>> Test for 2) also added: >>> Test tries to 'recv()...

...et *sock, struct msghdr *msg, >>> ??????????? err = total_written; >>> ????} >>> out: >>> +??? if (sk->sk_type == SOCK_STREAM) >>> +??????? err = sk_stream_error(sk, msg->msg_flags, err); >> >> Do you know why we don't need this for SOCK_SEQPACKET and SOCK_DGRAM? > >Yes, here is my explanation: > >This function checks that input error is SIGPIPE, and if so it sends SIGPIPE to the 'current' thread >(except case when MSG_NOSIGNAL flag is set). This behaviour is described in POSIX: > >Page 367 (description of define...

...?????? err = total_written; >>>>> ????} >>>>> out: >>>>> +??? if (sk->sk_type == SOCK_STREAM) >>>>> +??????? err = sk_stream_error(sk, msg->msg_flags, err); >>>> >>>> Do you know why we don't need this for SOCK_SEQPACKET and SOCK_DGRAM? >>> >>> Yes, here is my explanation: >>> >>> This function checks that input error is SIGPIPE, and if so it sends SIGPIPE to the 'current' thread >>> (except case when MSG_NOSIGNAL flag is set). This behaviour is described in POSI...

...>> ????} >>>>>>> out: >>>>>>> +??? if (sk->sk_type == SOCK_STREAM) >>>>>>> +??????? err = sk_stream_error(sk, msg->msg_flags, err); >>>>>> >>>>>> Do you know why we don't need this for SOCK_SEQPACKET and SOCK_DGRAM? >>>>> >>>>> Yes, here is my explanation: >>>>> >>>>> This function checks that input error is SIGPIPE, and if so it sends SIGPIPE to the 'current' thread >>>>> (except case when MSG_NOSIGNAL flag is s...

...Stefano Garzarella wrote: >> On Mon, Mar 06, 2023 at 06:31:22PM +0300, Arseniy Krasnov wrote: >>> >>> >>> On 06.03.2023 15:08, Stefano Garzarella wrote: >>>> On Sun, Mar 05, 2023 at 11:07:37PM +0300, Arseniy Krasnov wrote: >>>>> In case of SOCK_SEQPACKET all sk_buffs are used once - after read some >>>>> data from it, it will be removed, so user will never read rest of the >>>>> data. Thus we need to update credit parameters of the socket like whole >>>>> sk_buff is read - so call 'skb_pull()' fo...

...when copying data to user fails, current skbuff is > not dropped. Next read attempt will use same skbuff and last offset. > Instead of 'skb_dequeue()', 'skb_peek()' + '__skb_unlink()' are used. > This behaviour was implemented before skbuff support. >3) For SOCK_SEQPACKET it removes unneeded 'skb_pull()' call, because for > this type of socket each skbuff is used only once: after removing it > from socket's queue, it will be freed anyway. thanks for the fixes, I would wait a few days to see if there are any comments and then I think you can se...

Hi Bobby, > /* The feature bitmap for virtio vsock */ > #define VIRTIO_VSOCK_F_SEQPACKET 1 /* SOCK_SEQPACKET supported */ > +#define VIRTIO_VSOCK_F_DGRAM 2 /* Host support dgram vsock */ Seems that bit 2 is already taken by VIRTIO_VSOCK_F_NO_IMPLIED_STREAM. https://github.com/oasis-tcs/virtio-spec/commit/26ed30ccb049fd51d6e20aad3de2807d678edb3a

...00644 >> > > --- a/include/uapi/linux/virtio_vsock.h >> > > +++ b/include/uapi/linux/virtio_vsock.h >> > > @@ -40,6 +40,7 @@ >> > > >> > > /* The feature bitmap for virtio vsock */ >> > > #define VIRTIO_VSOCK_F_SEQPACKET 1 /* SOCK_SEQPACKET supported */ >> > > +#define VIRTIO_VSOCK_F_DGRAM 3 /* SOCK_DGRAM supported */ >> > > >> > > struct virtio_vsock_config { >> > > __le64 guest_cid; >> > >> > pls do not add interface without first getting it accepted in the >&g...

...CAVEATS ------- * We're currently hooked into too many socket calls. We should be able to reduce the number of hooks to 3 (__sock_create(), sys_connect(), sys_bind()). * Our 'hw_socket' component should be folded into a netdev so we can leverage NAPI. * We don't handle SOCK_SEQPACKET, SOCK_RAW, SOCK_RDM, or SOCK_PACKET sockets. * We don't currently have support for /proc/net. Our current plan is to add '/proc/net/hwsock' (filename TBD) and add support for these sockets to the net-tools packages (netstat & friends), rather than muck around with plumbin...

...CAVEATS ------- * We're currently hooked into too many socket calls. We should be able to reduce the number of hooks to 3 (__sock_create(), sys_connect(), sys_bind()). * Our 'hw_socket' component should be folded into a netdev so we can leverage NAPI. * We don't handle SOCK_SEQPACKET, SOCK_RAW, SOCK_RDM, or SOCK_PACKET sockets. * We don't currently have support for /proc/net. Our current plan is to add '/proc/net/hwsock' (filename TBD) and add support for these sockets to the net-tools packages (netstat & friends), rather than muck around with plumbin...

On Fri, Jan 15, 2016 at 1:07 PM, Alex Bligh <alex at alex.org.uk> wrote: > On 15 Jan 2016, at 11:44, Thomas ? Habets <habets at google.com> wrote: >> On 15 January 2016 at 08:48, Alex Bligh <alex at alex.org.uk> wrote: [snip] > 3. Server compares supplied address/port pair with what it sees > (to detect DNAT like Amazon elastic IPs), and if they are the >