search for: snext

...d, 17 insertions(+), 24 deletions(-) diff --git a/xen/common/sched_credit2.c b/xen/common/sched_credit2.c index a7bd2ee..03814b7 100644 --- a/xen/common/sched_credit2.c +++ b/xen/common/sched_credit2.c @@ -1544,31 +1544,24 @@ csched_runtime(const struct scheduler *ops, int cpu, struct csched_vcpu *snext) } } - /* - * snext is about to be scheduled; so: - * - * 1. if snext->credit were less than 0 when it was taken off the - * runqueue, then csched_schedule() should have called - * reset_credit(). So at this point snext->credit must be greater - * t...

...DIT_PREFER_SA MILLISECS(5) /* Carryover: How much "extra" credit may be carried over after * a reset. */ #define CSCHED_CARRYOVER_MAX CSCHED_MIN_TIMER @@ -1615,6 +1619,7 @@ runq_candidate(struct csched_runqueue_data *rqd, { struct list_head *iter; struct csched_vcpu *snext = NULL; + bool_t found_snext_w_hard_affinity = 0; /* Default to current if runnable, idle otherwise */ if ( vcpu_runnable(scurr->vcpu) ) @@ -1626,6 +1631,11 @@ runq_candidate(struct csched_runqueue_data *rqd, { struct csched_vcpu * svc = list_entry(iter, struct csche...

Address some credit2 issues. This patch series, along with the recent changes to the cpupools interface, should address some of the strange credit2 instability. _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel

v2: - Fix seeding. - Add a test that nbdkit-random-plugin is producing something which looks at least somewhat random. Rich.

...hose. + */ + +/* You can seed ‘struct random_state’ by setting the s[] elements + * directly - but not you must NOT set it all to zero. OR if you have + * a 64 bit seed, you can use xsrandom below to initialize the state. + */ +struct random_state { + uint64_t s[4]; +}; + +static inline uint64_t +snext (uint64_t *seed) +{ + uint64_t z = (*seed += 0x9e3779b97f4a7c15); + z = (z ^ (z >> 30)) * 0xbf58476d1ce4e5b9; + z = (z ^ (z >> 27)) * 0x94d049bb133111eb; + return z ^ (z >> 31); +} + +static inline void +xsrandom (uint64_t seed, struct random_state *state) +{ + state->s[0]...

...t_timer(&spc->ticker, NOW() + MILLISECS(CSCHED_MSECS_PER_TICK)); + set_timer(&spc->ticker, NOW() + MICROSECS(prv->tick_period_us) ); } static struct csched_vcpu * @@ -1375,7 +1374,7 @@ csched_schedule( * Return task to run next... */ ret.time = (is_idle_vcpu(snext->vcpu) ? - -1 : MILLISECS(CSCHED_MSECS_PER_TSLICE)); + -1 : MILLISECS(prv->tslice_ms)); ret.task = snext->vcpu; CSCHED_VCPU_CHECK(ret.task); @@ -1469,10 +1468,9 @@ csched_dump(const struct scheduler *ops) "\tweight = %u...

...s[] elements > + * directly - but not you must NOT set it all to zero. OR if you have s/not you/note you/ > + * a 64 bit seed, you can use xsrandom below to initialize the state. > + */ > +struct random_state { > + uint64_t s[4]; > +}; > + > +static inline uint64_t > +snext (uint64_t *seed) > +{ > + uint64_t z = (*seed += 0x9e3779b97f4a7c15); > + z = (z ^ (z >> 30)) * 0xbf58476d1ce4e5b9; > + z = (z ^ (z >> 27)) * 0x94d049bb133111eb; > + return z ^ (z >> 31); > +} Okay, that matches http://xoshiro.di.unimi.it/splitmix64.c. And...

...et_ntoa(csock.sin_addr)); > -#else > upslogx(LOG_INFO, "Connection from %s", tmp->addr); > -#endif > } > > /* read tcp messages and handle them */ > @@ -625,6 +688,24 @@ > { > ctype *tmpcli, *tmpnext; > upstype *ups, *unext; > + stype *stmp, *snext; > + > + /* cleanup server fds */ > + stmp = firstaddr; > + > + while (stmp) { > + snext = stmp->next; > + > + if (stmp->sock_fd != -1) > + close(stmp->sock_fd); > + if (stmp->addr != NULL) > + free(stmp->addr); > + if (stmp->port != NUL...

Should we use attribute((nonnull)) at all? There's a very interesting history of this in libvirt -- try looking at commit eefb881 plus the commits referencing eefb881 -- but it does seem to work for me using recent GCC and Clang. I only did a few functions because annotating them gets old quickly... Rich.

...atic inline bool +static inline bool __attribute__((__nonnull__ (1))) is_zero (const char *buffer, size_t size) { size_t i; diff --git a/common/include/random.h b/common/include/random.h index eb08295..098c6d6 100644 --- a/common/include/random.h +++ b/common/include/random.h @@ -67,7 +67,7 @@ snext (uint64_t *seed) } /* Seed the random state from a 64 bit seed. */ -static inline void +static inline void __attribute__((__nonnull__ (2))) xsrandom (uint64_t seed, struct random_state *state) { state->s[0] = snext (&seed); @@ -83,7 +83,7 @@ rotl (const uint64_t x, int k) } /*...

v1 was here: https://www.redhat.com/archives/libguestfs/2019-January/msg00008.html In v2 I have provided two patches: The first patch extends attribute((nonnull)) to most internal functions, but not to the external API. The second patch uses a macro so that attribute((format)) is only used in the public API on GCC or Clang. At least in theory these headers could be used by a C compiler which

Hello, This small series deals with some weirdness in the mechanism with which the credit scheduler choses what PCPU to tickle upon a VCPU wake-up. Details are available in the changelog of the first patch. The new approach has been extensively benchmarked and proved itself either beneficial or harmless. That means it does not introduce any significant amount of overhead and/or performances

(Second try to send this. I wonder if the first one gotten eaten by a spam filter; I'll link to patches instead of attaching them.) Here are the tincctl patches I've been working on. They apply to http://www.tinc-vpn.org/svn/tinc/branches/1.1@1545. I intend to commit them once the crypto stuff's fixed. Since they're basically done, I'm emailing them now for review and in case