Displaying 2 results from an estimated 2 matches for "sn_mapl".
Did you mean:
sn_map1
2014 Mar 13
2
[LLVMdev] MergeFunctions: reduce complexity to O(log(N))
...Val:
> + case Value::GlobalAliasVal:
> + default: // Unknown constant
> + return cmpNumbers((uint64_t)L, (uint64_t)R);
>
> Please assert on unknown constant.
>
> How are function, global variable and alias reachable here?
>
> 0004:
>
> Thanks for the comment on sn_mapL/R!
>
> +int FunctionComparator::cmpEnumerate(const Value *V1, const Value *V2) {
>
> "Compare enumerate"? This name doesn't make sense to me. "cmpValue" perhaps?
>
> + const Constant *C1 = dyn_cast<Constant>(V1);
> + const Constant *C2 = dyn_cast...
2014 Feb 27
3
[LLVMdev] MergeFunctions: reduce complexity to O(log(N))
Hi Nick,
I tried to rework changes as you requested. One of patches (0004 with
extra assertions) has been removed.
> + bool isEquivalentType(Type *Ty1, Type *Ty2) const {
> + return cmpType(Ty1, Ty2) == 0;
> + }
>
> Why do we still need isEquivalentType? Can we nuke this?
Yup. After applying all the patches isEquivalentType will be totally
replaced with cmpType. All