search for: smp_call_on_cpu

On Tuesday 05 April 2016 21:31:52 Pali Roh?r wrote: > On Tuesday 05 April 2016 16:54:14 Guenter Roeck wrote: > > On Tue, Apr 05, 2016 at 07:10:07AM +0200, Juergen Gross wrote: > > > Use the smp_call_on_cpu() function to call system management > > > mode on cpu 0. > > > Make call secure by adding get_online_cpus() to avoid e.g. suspend > > > resume cycles in between. > > > > > > Signed-off-by: Juergen Gross <jgross at suse.com> > > > --- &gt...

On Tuesday 05 April 2016 21:31:52 Pali Roh?r wrote: > On Tuesday 05 April 2016 16:54:14 Guenter Roeck wrote: > > On Tue, Apr 05, 2016 at 07:10:07AM +0200, Juergen Gross wrote: > > > Use the smp_call_on_cpu() function to call system management > > > mode on cpu 0. > > > Make call secure by adding get_online_cpus() to avoid e.g. suspend > > > resume cycles in between. > > > > > > Signed-off-by: Juergen Gross <jgross at suse.com> > > > --- &gt...

On Tue, Apr 05, 2016 at 07:10:07AM +0200, Juergen Gross wrote: > Use the smp_call_on_cpu() function to call system management > mode on cpu 0. > Make call secure by adding get_online_cpus() to avoid e.g. suspend > resume cycles in between. > > Signed-off-by: Juergen Gross <jgross at suse.com> > --- > V4: add call to get_online_cpus() Pali, any chance to tes...

On Tue, Apr 05, 2016 at 07:10:07AM +0200, Juergen Gross wrote: > Use the smp_call_on_cpu() function to call system management > mode on cpu 0. > Make call secure by adding get_online_cpus() to avoid e.g. suspend > resume cycles in between. > > Signed-off-by: Juergen Gross <jgross at suse.com> > --- > V4: add call to get_online_cpus() Pali, any chance to tes...

Use the smp_call_on_cpu() function to call system management mode on cpu 0. Make call secure by adding get_online_cpus() to avoid e.g. suspend resume cycles in between. Signed-off-by: Juergen Gross <jgross at suse.com> --- V4: add call to get_online_cpus() --- drivers/hwmon/dell-smm-hwmon.c | 35 ++++++++++++++++++...

Use smp_call_on_cpu() to raise SMI on cpu 0. Make call secure by adding get_online_cpus() to avoid e.g. suspend resume cycles in between. Signed-off-by: Juergen Gross <jgross at suse.com> --- V4: add call to get_online_cpus() --- drivers/firmware/dcdbas.c | 51 ++++++++++++++++++++++++----------------------- 1...

Use the smp_call_on_cpu() function to call system management mode on cpu 0. Make call secure by adding get_online_cpus() to avoid e.g. suspend resume cycles in between. Signed-off-by: Juergen Gross <jgross at suse.com> --- V4: add call to get_online_cpus() --- drivers/hwmon/dell-smm-hwmon.c | 35 ++++++++++++++++++...

On 21/04/16 12:57, Pali Roh?r wrote: > On Tuesday 05 April 2016 21:31:52 Pali Roh?r wrote: >> On Tuesday 05 April 2016 16:54:14 Guenter Roeck wrote: >>> On Tue, Apr 05, 2016 at 07:10:07AM +0200, Juergen Gross wrote: >>>> Use the smp_call_on_cpu() function to call system management >>>> mode on cpu 0. >>>> Make call secure by adding get_online_cpus() to avoid e.g. suspend >>>> resume cycles in between. >>>> >>>> Signed-off-by: Juergen Gross <jgross at suse.com> >>>&...

...>> On 21/04/16 12:57, Pali Roh?r wrote: >>> On Tuesday 05 April 2016 21:31:52 Pali Roh?r wrote: >>>> On Tuesday 05 April 2016 16:54:14 Guenter Roeck wrote: >>>>> On Tue, Apr 05, 2016 at 07:10:07AM +0200, Juergen Gross wrote: >>>>>> Use the smp_call_on_cpu() function to call system management >>>>>> mode on cpu 0. >>>>>> Make call secure by adding get_online_cpus() to avoid e.g. suspend >>>>>> resume cycles in between. >>>>>> >>>>>> Signed-off-by: Juergen Gross...

...en Gross wrote: > On 21/04/16 12:57, Pali Roh?r wrote: > > On Tuesday 05 April 2016 21:31:52 Pali Roh?r wrote: > >> On Tuesday 05 April 2016 16:54:14 Guenter Roeck wrote: > >>> On Tue, Apr 05, 2016 at 07:10:07AM +0200, Juergen Gross wrote: > >>>> Use the smp_call_on_cpu() function to call system management > >>>> mode on cpu 0. > >>>> Make call secure by adding get_online_cpus() to avoid e.g. suspend > >>>> resume cycles in between. > >>>> > >>>> Signed-off-by: Juergen Gross <jgross at s...

...en Gross wrote: > On 21/04/16 12:57, Pali Roh?r wrote: > > On Tuesday 05 April 2016 21:31:52 Pali Roh?r wrote: > >> On Tuesday 05 April 2016 16:54:14 Guenter Roeck wrote: > >>> On Tue, Apr 05, 2016 at 07:10:07AM +0200, Juergen Gross wrote: > >>>> Use the smp_call_on_cpu() function to call system management > >>>> mode on cpu 0. > >>>> Make call secure by adding get_online_cpus() to avoid e.g. suspend > >>>> resume cycles in between. > >>>> > >>>> Signed-off-by: Juergen Gross <jgross at s...

...coding such a functionality multiple times in the kernel add a service function for this purpose. This will enable the possibility to take special measures in virtualized environments like Xen, too. Signed-off-by: Juergen Gross <jgross at suse.com> --- V5: rename and reshuffle parameters of smp_call_on_cpu() as requested by Peter Zijlstra test target cpu to be online as requested by Peter Zijlstra V4: change return value in case of illegal cpu as requested by Peter Zijlstra make pinning of vcpu an option as suggested by Peter Zijlstra V2: instead of manipulating the allowed set of cpus...

...y. Can you confirm, please? This is not something we should worry about; the caller should ensure the CPU stays valid; typically I would expect a caller to do get_online_cpus() before 'computing' what CPU to send the function to. > > So I would propose you add: > > > > smp_call_on_cpu() > > > > As per patch 2. No promises about physical or anything. This means it > > can be used freely by anyone that wants to run a function on another > > cpu -- a much more useful thing. > > Okay. > > > And then build a phys variant on top. > > Hm...

...y. Can you confirm, please? This is not something we should worry about; the caller should ensure the CPU stays valid; typically I would expect a caller to do get_online_cpus() before 'computing' what CPU to send the function to. > > So I would propose you add: > > > > smp_call_on_cpu() > > > > As per patch 2. No promises about physical or anything. This means it > > can be used freely by anyone that wants to run a function on another > > cpu -- a much more useful thing. > > Okay. > > > And then build a phys variant on top. > > Hm...

On Tuesday 05 April 2016 16:54:14 Guenter Roeck wrote: > On Tue, Apr 05, 2016 at 07:10:07AM +0200, Juergen Gross wrote: > > Use the smp_call_on_cpu() function to call system management > > mode on cpu 0. > > Make call secure by adding get_online_cpus() to avoid e.g. suspend > > resume cycles in between. > > > > Signed-off-by: Juergen Gross <jgross at suse.com> > > --- > > V4: add call to get_onl...

...generic function to be able to temporarily pin a (virtual) cpu to a dedicated physical cpu for executing above mentioned functions on that specific cpu. The drivers (dcdbas and i8k) requiring this functionality are modified accordingly. Changes in V5: - patch 3: rename and reshuffle parameters of smp_call_on_cpu() as requested by Peter Zijlstra - patch 3: test target cpu to be online as requested by Peter Zijlstra - patch 4: less wordy messages as requested by David Vrabel Changes in V4: - move patches 5 and 6 further up in the series - patch 2 (was 5): WARN_ONCE in case platform doesn't support pin...

...generic function to be able to temporarily pin a (virtual) cpu to a dedicated physical cpu for executing above mentioned functions on that specific cpu. The drivers (dcdbas and i8k) requiring this functionality are modified accordingly. Changes in V5: - patch 3: rename and reshuffle parameters of smp_call_on_cpu() as requested by Peter Zijlstra - patch 3: test target cpu to be online as requested by Peter Zijlstra - patch 4: less wordy messages as requested by David Vrabel Changes in V4: - move patches 5 and 6 further up in the series - patch 2 (was 5): WARN_ONCE in case platform doesn't support pin...

...+++++++++++++ 3 files changed, 69 insertions(+) diff --git a/include/linux/smp.h b/include/linux/smp.h index c441407..3b5813b 100644 --- a/include/linux/smp.h +++ b/include/linux/smp.h @@ -196,4 +196,6 @@ extern void arch_enable_nonboot_cpus_end(void); void smp_setup_processor_id(void); +int smp_call_on_cpu(unsigned int cpu, bool pin, int (*func)(void *), void *par); + #endif /* __LINUX_SMP_H */ diff --git a/kernel/smp.c b/kernel/smp.c index 9388064..357458b 100644 --- a/kernel/smp.c +++ b/kernel/smp.c @@ -740,3 +740,53 @@ void wake_up_all_idle_cpus(void) preempt_enable(); } EXPORT_SYMBOL_GPL(wak...

...his constraint by using: hypervisor_pin_vcpu(smp_processor_id()); Also, for the vpinning stuff, the UP version below is sufficient, even on SMP systems (with the current !preempt constraint). Which seems to suggest we're not having the right interface for this. So I would propose you add: smp_call_on_cpu() As per patch 2. No promises about physical or anything. This means it can be used freely by anyone that wants to run a function on another cpu -- a much more useful thing. And then build a phys variant on top. > diff --git a/kernel/up.c b/kernel/up.c > index afd395c..725ec44 100644 >...

...his constraint by using: hypervisor_pin_vcpu(smp_processor_id()); Also, for the vpinning stuff, the UP version below is sufficient, even on SMP systems (with the current !preempt constraint). Which seems to suggest we're not having the right interface for this. So I would propose you add: smp_call_on_cpu() As per patch 2. No promises about physical or anything. This means it can be used freely by anyone that wants to run a function on another cpu -- a much more useful thing. And then build a phys variant on top. > diff --git a/kernel/up.c b/kernel/up.c > index afd395c..725ec44 100644 >...