search for: smatch

Smatch complains about the inconsistent NULL checking here. Fix it to return NULL on failure. Signed-off-by: Dan Carpenter <dan.carpenter at oracle.com> --- This is only needed in linux-next. diff --git a/drivers/block/virtio_blk.c b/drivers/block/virtio_blk.c index 2edfb5c..457db0c 100644 --- a/...

Smatch complains about the inconsistent NULL checking here. Fix it to return NULL on failure. Signed-off-by: Dan Carpenter <dan.carpenter at oracle.com> --- This is only needed in linux-next. diff --git a/drivers/block/virtio_blk.c b/drivers/block/virtio_blk.c index 2edfb5c..457db0c 100644 --- a/...

On Mon, Feb 15, 2010 at 03:40:56PM +0300, Dan Carpenter wrote: > This is the results from: > make C=1 CHECK="/path/to/smatch -p=kernel" bzImage modules | tee warns.txt > grep -w overflow warns.txt | uniq -f 3 | tee err-list > > I hacked on the buffer overflow check last weekend and these are the > results. It has way more false positives than the other bug lists > I've posted, but it's...

...l32: Correct monthcal WM_LBUTTONDOWN return values. comctl32: Monthcal should send notifications when today link gets clicked. user32: Do not send button click to dialog with disabled default button. Lionel Debroux (11): comctl32: Remove redundant NULL check before free (found by Smatch). comctl32: Remove redundant NULL check before free (found by Smatch). itss: Remove redundant NULL check before free (found by Smatch). server: Remove redundant NULL checks before free (found by Smatch). server: Remove redundant NULL checks before free (found by Smatch)....

Hello Ben Skeggs, The patch 176fdcbddfd2: "drm/nouveau/gsp/r535: add support for booting GSP-RM" from Sep 19, 2023 (linux-next), leads to the following Smatch static checker warning: drivers/gpu/drm/nouveau/nvkm/subdev/gsp/r535.c:1016 r535_gsp_rpc_unloading_guest_driver() warn: 'rpc' isn't an ERR_PTR drivers/gpu/drm/nouveau/nvkm/subdev/gsp/r535.c 1010 static int 1011 r535_gsp_rpc_unloading_guest_driver(struct nvkm_gsp *gsp, bool s...

Smatch complains that "rc" can be uninitialized if we hit the "break;" statement on the first iteration through the loop. I suspect that this can't happen in real life, but returning a zero literal is cleaner and silence the static checker warning. Signed-off-by: Dan Carpenter &l...

On Mon, Feb 15, 2010 at 03:40:56PM +0300, Dan Carpenter wrote: > This is the results from: > make C=1 CHECK="/path/to/smatch -p=kernel" bzImage modules | tee warns.txt > grep -w overflow warns.txt | uniq -f 3 | tee err-list > > I hacked on the buffer overflow check last weekend and these are the > results. It has way more false positives than the other bug lists > I've posted, but it's...

Hi Josef, Smatch complains about this change introduces a double unlock. fs/btrfs/async-thread.c +608 find_worker(49) error: double unlock ''spin_lock:&workers->lock'' 579 spin_unlock_irqrestore(&workers->lock, flags); ^^^^^...

...DirA/W and SheChangeDirA/W. Matt Jones (2): kernel32: Added test for bad arguments to SetThreadPriority, test for correct error value. server: Only commit SetThreadPriority if new priority is correct. Michael Stefaniuc (17): shell32: Fix missing unlock on an error path. Found by Smatch. wined3d: Remove unreachable code: break after return. Found by Smatch. ntdll: Don't produce unreachable code during conditional compilation. Found by Smatch. winhelp: Add missing case label "default". Found by Smatch (unreached code). dlls: Remove unreachable...

Hi Ville, Thank you for the patch! Perhaps something to improve: url: https://github.com/0day-ci/linux/commits/Ville-Syrjala/drm-Third-attempt-at-fixing-the-fb-helper-best_encoder-mess/20180629-014202 base: git://people.freedesktop.org/~airlied/linux.git drm-next smatch warnings: drivers/gpu/drm/nouveau/nouveau_connector.c:461 nouveau_connector_ddc_detect() error: uninitialized symbol 'nv_encoder'. # https://github.com/0day-ci/linux/commit/7ec8bb65386edfb0b2bdc8e8391eb5e6eac44c06 git remote add linux-review https://github.com/0day-ci/linux git remote upda...

Hello, I am trying to force a command for all users *except* for users in the "wheel" group. My idea was to do the following in sshd_config: ForceCommand /usr/bin/validate-ssh-command Match Group wheel ForceCommand But obviously this doesn't work, because ForceCommand requires an argument. I couldn't find a way to achieve what I want. I wrote a patch that adds a

On 11/7/23 15:34, Dan Carpenter wrote: > Hello Ben Skeggs, > > The patch 176fdcbddfd2: "drm/nouveau/gsp/r535: add support for > booting GSP-RM" from Sep 19, 2023 (linux-next), leads to the > following Smatch static checker warning: > > drivers/gpu/drm/nouveau/nvkm/subdev/gsp/r535.c:1016 r535_gsp_rpc_unloading_guest_driver() > warn: 'rpc' isn't an ERR_PTR > > drivers/gpu/drm/nouveau/nvkm/subdev/gsp/r535.c > 1010 static int > 1011 r535_gsp_rpc_unloading_gues...

...ndconfig-m031-20200913 (attached as .config) > compiler: hppa-linux-gcc (GCC) 9.3.0 > > If you fix the issue, kindly add following tag as appropriate > Reported-by: kernel test robot <lkp at intel.com> > Reported-by: Dan Carpenter <dan.carpenter at oracle.com> > > smatch warnings: > drivers/i2c/busses/i2c-virtio.c:160 virtio_i2c_xfer() error: we previously assumed 'vmsg' could be null (see line 137) > It's quite possible a false positive. Look at 122. But I agree that for-loop is not the best for such things to understand. Perhaps switching to d...

...ndconfig-m031-20200913 (attached as .config) > compiler: hppa-linux-gcc (GCC) 9.3.0 > > If you fix the issue, kindly add following tag as appropriate > Reported-by: kernel test robot <lkp at intel.com> > Reported-by: Dan Carpenter <dan.carpenter at oracle.com> > > smatch warnings: > drivers/i2c/busses/i2c-virtio.c:160 virtio_i2c_xfer() error: we previously assumed 'vmsg' could be null (see line 137) > It's quite possible a false positive. Look at 122. But I agree that for-loop is not the best for such things to understand. Perhaps switching to d...

...ontrol to the SelectionPath event. msi: Handle the SelectionBrowse event using ControlEvent_SpawnDialog. msi: Only apply the last font style in the list of styles. user: Add missing sizeof(WCHAR) multiplier. crypt32: Remove redundant NULL checks before CryptMemFree (found by Smatch). advapi32: Remove redundant NULL check before SERV_free (found by Smatch). dbghelp: Remove redundant NULL checks before pdb_free (found by Smatch). dinput: Call missing LeaveCriticalSection in the error case (found by Smatch). ddraw: Set lplpDirect3DViewport3 to NULL before...

[ No idea why it's only complaining about this a year later... -dan ] Hello Ben Skeggs, This is a semi-automatic email about new static checker warnings. The patch b7a2bc1886d0: "drm/nouveau/imem: convert to new-style nvkm_subdev" from Aug 20, 2015, leads to the following Smatch complaint: drivers/gpu/drm/nouveau/nvkm/subdev/instmem/gk20a.c:536 gk20a_instobj_new() error: we previously assumed 'node' could be null (see line 532) drivers/gpu/drm/nouveau/nvkm/subdev/instmem/gk20a.c 531 align, &node); 532 *pmemory = node ? &node->memory...

smatch reports drivers/gpu/drm/nouveau/nvkm/engine/fifo/runl.c:33:18: warning: symbol 'nvkm_engn_cgrp_get' was not declared. Should it be static? nvkm_engn_cgrp_get is only used in runl.c, so it should be static Signed-off-by: Tom Rix <trix at redhat.com> --- drivers/gpu/drm/nouveau/nvk...

smatch reports drivers/gpu/drm/nouveau/nvkm/subdev/gsp/ga102.c:49:1: warning: symbol 'ga102_gsps' was not declared. Should it be static? This variable is only used in its defining file, so it should be static Signed-off-by: Tom Rix <trix at redhat.com> --- drivers/gpu/drm/nouveau/nvkm/s...

There is an error path in ocfs2_quota_write() that doesn't unlock &gqinode->i_mutex(). That seems unintentional. Found by smatch (http://repo.or.cz/w/smatch.git). Compile tested. regards, dan carpenter Signed-off-by: Dan Carpenter <error27 at gmail.com> --- orig/fs/ocfs2/quota_global.c 2009-04-07 19:34:22.000000000 +0300 +++ devel/fs/ocfs2/quota_global.c 2009-04-07 19:34:25.000000000 +0300 @@ -232,10 +232,8 @@ e...

On 11/7/23 20:00, Danilo Krummrich wrote: > On 11/7/23 15:34, Dan Carpenter wrote: >> Hello Ben Skeggs, >> >> The patch 176fdcbddfd2: "drm/nouveau/gsp/r535: add support for >> booting GSP-RM" from Sep 19, 2023 (linux-next), leads to the >> following Smatch static checker warning: >> >> ????drivers/gpu/drm/nouveau/nvkm/subdev/gsp/r535.c:1016 r535_gsp_rpc_unloading_guest_driver() >> ????warn: 'rpc' isn't an ERR_PTR >> >> drivers/gpu/drm/nouveau/nvkm/subdev/gsp/r535.c >> ???? 1010 static int >> ????...