search for: sm_usernam

...ls with + | None -> + error (f_"subscription-manager credentials required for --sm-register") + | Some c -> c in + let cmd = sprintf "subscription-manager register --username=%s --password=%s" + (quote creds.Subscription_manager.sm_username) + (quote creds.Subscription_manager.sm_password) in + do_run ~display:"subscription-manager register" cmd + + | `SMRemove -> + message (f_"Removing all the subscriptions"); + let cmd = "subscription-manager remove --all" in +...

Hi, this is the v2 of a series introducing basic support for registering/attaching/unregistering RHEL guests using subscription-manager, so it is possible to do for example: $ virt-customize -a rhel-guest.qcow2 \ --sm-credentials user:file:/path/to/password-file --sm-register \ --sm-attach file:/path/to/pool-file \ --install pkg1 --install pkg2 .. \ --sm-remove --sm-unregister

...cmd + do_run ~display:cmd ~warn_failed_no_network:true cmd ) | `SMRegister -> @@ -317,17 +322,18 @@ exec >>%s 2>&1 let cmd = sprintf "subscription-manager register --username=%s --password=%s" (quote creds.Subscription_manager.sm_username) (quote creds.Subscription_manager.sm_password) in - do_run ~display:"subscription-manager register" cmd + do_run ~display:"subscription-manager register" + ~warn_failed_no_network:true cmd | `SMRemove -> message (f_&quo...

...100644 --- a/customize/subscription_manager.ml +++ b/customize/subscription_manager.ml @@ -16,8 +16,9 @@ * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. *) -open Common_gettext.Gettext +open Std_utils open Common_utils +open Common_gettext.Gettext type sm_credentials = { sm_username : string; diff --git a/dib/Makefile.am b/dib/Makefile.am index 6780ee249..b10fa94c9 100644 --- a/dib/Makefile.am +++ b/dib/Makefile.am @@ -79,6 +79,7 @@ OCAMLPACKAGES = \ -I $(top_builddir)/lib/.libs \ -I $(top_builddir)/gnulib/lib/.libs \ -I $(top_builddir)/ocaml \ + -I $(top_builddir)/comm...

...ption_manager.ml b/customize/subscription_manager.ml index 1e6e25de3..a23efe546 100644 --- a/customize/subscription_manager.ml +++ b/customize/subscription_manager.ml @@ -37,7 +37,7 @@ and parse_credentials_selector_list orig_arg = function | [ username; "file"; filename ] -> { sm_username = username; sm_password = read_first_line_from_file filename } | _ -> - error (f_"invalid sm-credentials selector '%s'; see the man page") orig_arg + error (f_"invalid sm-credentials selector ‘%s’; see the man page") orig_arg let rec parse_pool_selector a...

This is just the utilities part of the patch series from: https://www.redhat.com/archives/libguestfs/2017-June/msg00103.html I believe this addresses everything raised in comments on that patch series. Rich.

This turned out to be rather more involved than I thought. We have lots of utility functions, spread all over the repository, with not a lot of structure. This moves many of them under common/ and structures them so there are clear dependencies. This doesn't complete the job by any means. Other items I had on my to-do list for this change were: - Split up mllib/common_utils into: -

This is a combination of: https://www.redhat.com/archives/libguestfs/2017-June/msg00046.html [PATCH 00/12] Refactor utility functions. plus: https://www.redhat.com/archives/libguestfs/2017-June/msg00023.html [PATCH v3 00/19] Allow APIs to be implemented in OCaml. with the second patches rebased on top of the utility refactoring, and some other adjustments and extensions. This passes

v5: https://www.redhat.com/archives/libguestfs/2017-June/msg00065.html Since v5, this now implements inspection almost completely for Linux and Windows guests. Rich.

v7 was: https://www.redhat.com/archives/libguestfs/2017-June/msg00169.html https://www.redhat.com/archives/libguestfs/2017-June/msg00184.html I believe this addresses all comments received so far. Also it now passes a test where I compared about 100 disk images processed with old and new virt-inspector binaries. The output is identical in all cases except one which is caused by a bug in blkid