search for: skip_offlin

...e20f..024e02b60346 100644 --- a/include/linux/page-isolation.h +++ b/include/linux/page-isolation.h @@ -32,6 +32,8 @@ static inline bool is_migrate_isolate(int migratetype) #define SKIP_HWPOISON 0x1 #define REPORT_FAILURE 0x2 +/* Skip PageOffline() pages with a reference count of 0. */ +#define SKIP_OFFLINE 0x4 bool has_unmovable_pages(struct zone *zone, struct page *page, int count, int migratetype, int flags); @@ -58,7 +60,7 @@ undo_isolate_page_range(unsigned long start_pfn, unsigned long end_pfn, * Test all pages in [start_pfn, end_pfn) are isolated or not. */ int test_pages_isolated...

...gt; + * Memory devices allow to offline a page if it is > + * marked PG_offline and has a reference count of 0. > + * However, the pages are not movable as it would be > + * required e.g., for alloc_contig_range(). > + */ > + if (PageOffline(page) && !(flags & SKIP_OFFLINE)) > + if (++found > count) > + goto unmovable; > continue; > } Do we really need to distinguish offline and hwpoison pages? They are both unmovable for allocator purposes and offlineable for the hotplug, right? Should we just hide them behind a helper and use it rathe...

...gt; + * Memory devices allow to offline a page if it is > + * marked PG_offline and has a reference count of 0. > + * However, the pages are not movable as it would be > + * required e.g., for alloc_contig_range(). > + */ > + if (PageOffline(page) && !(flags & SKIP_OFFLINE)) > + if (++found > count) > + goto unmovable; > continue; > } Do we really need to distinguish offline and hwpoison pages? They are both unmovable for allocator purposes and offlineable for the hotplug, right? Should we just hide them behind a helper and use it rathe...

...ices allow to offline a page if it is >> + * marked PG_offline and has a reference count of 0. >> + * However, the pages are not movable as it would be >> + * required e.g., for alloc_contig_range(). >> + */ >> + if (PageOffline(page) && !(flags & SKIP_OFFLINE)) >> + if (++found > count) >> + goto unmovable; >> continue; >> } > > Do we really need to distinguish offline and hwpoison pages? They are > both unmovable for allocator purposes and offlineable for the hotplug, > right? Should we just hide...

Long time no RFC! I finally had time to get the next version of the Linux driver side of virtio-mem into shape, incorporating ideas and feedback from previous discussions. This RFC is based on the series currently on the mm list: - [PATCH 0/3] Remove __online_page_set_limits() - [PATCH v1 0/3] mm/memory_hotplug: Export generic_online_page() - [PATCH v4 0/8] mm/memory_hotplug: Shrink zones before

...f it is > > > + * marked PG_offline and has a reference count of 0. > > > + * However, the pages are not movable as it would be > > > + * required e.g., for alloc_contig_range(). > > > + */ > > > + if (PageOffline(page) && !(flags & SKIP_OFFLINE)) > > > + if (++found > count) > > > + goto unmovable; > > > continue; > > > } > > > > Do we really need to distinguish offline and hwpoison pages? They are > > both unmovable for allocator purposes and offlineable for the h...

...f it is > > > + * marked PG_offline and has a reference count of 0. > > > + * However, the pages are not movable as it would be > > > + * required e.g., for alloc_contig_range(). > > > + */ > > > + if (PageOffline(page) && !(flags & SKIP_OFFLINE)) > > > + if (++found > count) > > > + goto unmovable; > > > continue; > > > } > > > > Do we really need to distinguish offline and hwpoison pages? They are > > both unmovable for allocator purposes and offlineable for the h...