search for: skip_

Hi all : there is a problem on libguestfs-1.29.40 after command :make check libguestfs: error: mkfs_btrfs: /dev/vda1: device /dev/vda1 is too small (must be at least 256 MB) FAIL: test_btrfs_image_0 3/515 test_btrfstune_enable_skinny_metadata_extent_refs_0 libguestfs: error: btrfstune_enable_skinny_metadata_extent_refs: /dev/vda1: btrfstune: invalid option -- 'x' usage: btrfstune

...gt; + * Memory devices allow to offline a page if it is > + * marked PG_offline and has a reference count of 0. > + * However, the pages are not movable as it would be > + * required e.g., for alloc_contig_range(). > + */ > + if (PageOffline(page) && !(flags & SKIP_OFFLINE)) > + if (++found > count) > + goto unmovable; > continue; > } Do we really need to distinguish offline and hwpoison pages? They are both unmovable for allocator purposes and offlineable for the hotplug, right? Should we just hide them behind a helper and use it...

...gt; + * Memory devices allow to offline a page if it is > + * marked PG_offline and has a reference count of 0. > + * However, the pages are not movable as it would be > + * required e.g., for alloc_contig_range(). > + */ > + if (PageOffline(page) && !(flags & SKIP_OFFLINE)) > + if (++found > count) > + goto unmovable; > continue; > } Do we really need to distinguish offline and hwpoison pages? They are both unmovable for allocator purposes and offlineable for the hotplug, right? Should we just hide them behind a helper and use it...

...ices allow to offline a page if it is >> + * marked PG_offline and has a reference count of 0. >> + * However, the pages are not movable as it would be >> + * required e.g., for alloc_contig_range(). >> + */ >> + if (PageOffline(page) && !(flags & SKIP_OFFLINE)) >> + if (++found > count) >> + goto unmovable; >> continue; >> } > > Do we really need to distinguish offline and hwpoison pages? They are > both unmovable for allocator purposes and offlineable for the hotplug, > right? Should we jus...

Add a single shell script to hold results of configure. Pino Toscano (3): build: add an empty config.sh Revert "tests: rhv-upload: Fix skip test of nbdkit python plugin." tests: use the right nbdkit python3 plugin .gitignore | 2 +- config.sh.in | 22 +++++++++++++++++++ configure.ac

Add a single shell script to hold results of configure. Pino Toscano (2): build: add an empty config.sh tests: switch to config.sh for xmllint .gitignore | 4 +--- config.sh.in | 22 +++++++++++++++++++ configure.ac | 7 +----- ...luks.sh.in => test-virt-inspector-luks.sh} | 2 +-

...Jonathan seems to have written yet another plugin to make things work(acts_as_modified). [thread: http://www.ruby-forum.com/topic/75313#new ] Caio Chassot poses the question: "Do you really think it''s a good idea to run filters more than once?" Besides from being able to use skip_* this thread discusses the ins and outs as well as performance benchmarks and the possibility of adding a uniq option to the filter chain. [thread: http://www.ruby-forum.com/topic/75353#new ] Rick Olson breaks the news that Simply Restful is now an integral part of core with some slight syntax ch...

The first of two sets of patches. This checks that the templates we supply have the serial console enabled, or in two cases, that the serial console can be enabled by fiddling with some grub config. The second set of patches (to follow) will test that the --password and --root-password options work. This implementation of this is quite complex. Rich.

There's a lot of common code in the tests, eg: if [ "$(guestfish get-backend)" = "uml" ]; then echo "$0: test skipped because UML backend does not support network" exit 77 fi These commits (work in progress) create a common set of test functions for skipping tests etc. Rich.

...f it is > > > + * marked PG_offline and has a reference count of 0. > > > + * However, the pages are not movable as it would be > > > + * required e.g., for alloc_contig_range(). > > > + */ > > > + if (PageOffline(page) && !(flags & SKIP_OFFLINE)) > > > + if (++found > count) > > > + goto unmovable; > > > continue; > > > } > > > > Do we really need to distinguish offline and hwpoison pages? They are > > both unmovable for allocator purposes and offlineable for...

...f it is > > > + * marked PG_offline and has a reference count of 0. > > > + * However, the pages are not movable as it would be > > > + * required e.g., for alloc_contig_range(). > > > + */ > > > + if (PageOffline(page) && !(flags & SKIP_OFFLINE)) > > > + if (++found > count) > > > + goto unmovable; > > > continue; > > > } > > > > Do we really need to distinguish offline and hwpoison pages? They are > > both unmovable for allocator purposes and offlineable for...

...nd' etc. will still work. But in addition, you can now run the tests on an installed copy of libguestfs by doing: cd $libdir/guestfs/tests ./test-harness The test-harness script supports various options, see 'test-harness(1)' for full details. Other notable features: - Checking SKIP_* environment variables in tests is no longer necessary. The test harness deals with these. - Every test runs in its own temporary directory. There is no need to clean up output files. On the other hand, tests must use $srcdir, $builddir, $datadir etc. to refer to test data. This is o...

This has got to the stage where it actually works, both for running the tests in-tree and installed. The 'test-harness' script has become rather over-complex in the process however. Rich.

...39; etc. will still work. But in addition, you can now run the tests on an installed copy of libguestfs by doing: cd $libdir/guestfs/tests ./test-harness The test-harness script supports various options, see 'test-harness --help' for full details. Other notable features: - Checking SKIP_* environment variables in tests is no longer necessary. The test harness deals with these. - Every test runs in its own temporary directory. There is no need to clean up output files. On the other hand, tests must use $srcdir to refer to test data. This is only implemented for a sing...

...39; etc. will still work. But in addition, you can now run the tests on an installed copy of libguestfs by doing: cd $libdir/guestfs/tests ./test-harness The test-harness script supports various options, see 'test-harness --help' for full details. Other notable features: - Checking SKIP_* environment variables in tests is no longer necessary. The test harness deals with these. - Every test runs in its own temporary directory. There is no need to clean up output files. On the other hand, tests must use $srcdir to refer to test data. This is only implemented for a sing...

Hi, as it was already discussed on this list, here it is my attempt in splitting virt-p2v in an own repository. Sadly there are things that must be copied from libguestfs, as it cannot be avoided. The approach taken was to run a script (will send separately) to just get the "p2v" subdirectory with its history as own repository, and then add in few followup commits all the bits needed

Previously I posted a work-in-progress preview of this patch series: https://www.redhat.com/archives/libguestfs/2017-February/msg00224.html This is the finished version that updates all of the shell-script based tests. It passes 'make check', 'make check-direct' and 'make check-slow'. Rich.

...lvl = 2; if (h->msglvl >= 2) diff --git a/src/generator.ml b/src/generator.ml index aff6356..917fea9 100644 --- a/src/generator.ml +++ b/src/generator.ml @@ -5878,9 +5878,9 @@ static int %s_skip (void) if (str) return strstr (str, \"%s\") == NULL; str = getenv (\"SKIP_%s\"); - if (str && strcmp (str, \"1\") == 0) return 1; + if (str && STREQ (str, \"1\")) return 1; str = getenv (\"SKIP_TEST_%s\"); - if (str && strcmp (str, \"1\") == 0) return 1; + if (str && STREQ (str, \"1\&...

This converts more of the tests (basically everything under tests/) to use the test harness, revealing some problems which have subsequently been fixed. Rich.

These are my thoughts on adding a test harness to run tests instead of using automake. The aim of this exercise is to allow us to run the full test suite on an installed copy of libguestfs. Another aim is to allow us to work around all the limitations and problems of automake. The first patch makes an observation that since the ./run script sets up $PATH to contain all the directories