search for: sizeglobaladdress

...nes where > instructions may not be byte sized? The iAPX 432 had a bitstream format. See http://en.wikipedia.org/wiki/Intel_iAPX_432 . In a nutshell: the processor was a failure due to many reasons, the bitstream format among them though not particularly prominent. > > +static unsigned sizeGlobalAddress(bool dword) { > > + if (dword) > > + return 8; > > + else > > + return 4; > > +} > > How about? > return dword ? 8 : 4; Why? (Just wondering, I'd be happy with either style if I were to review the code.) Regards, Jo

...ak; > + } > + } > + } > + return REX; > +} > + > +/// sizePCRelativeBlockAddress - This method returns the size of a PC > +/// relative block address instruction > +/// > +static unsigned sizePCRelativeBlockAddress() { > + return 4; > +} > + > +/// sizeGlobalAddress - Give the size of the emission of this > global address > +/// > +static unsigned sizeGlobalAddress(bool dword) { > + if (dword) > + return 8; > + else > + return 4; > +} How about? return dword ? 8 : 4; > > + > +/// sizeConstPoolAddress - Give the size...

OK, here's a new patch that adds the infrastructure and the implementation for X86, ARM and PPC of GetInstSize and GetFunctionSize. Both functions are virtual functions defined in TargetInstrInfo.h. For X86, I moved some commodity functions from X86CodeEmitter to X86InstrInfo. What do you think? Nicolas Evan Cheng wrote: > > I think both of these belong to TargetInstrInfo. And