search for: single_responsibility_principle

Displaying 2 results from an estimated 2 matches for "single_responsibility_principle".

2016 Apr 21
2
Refactor BitcodeWriter into classes?
...much nicer to have a class instead of passing around a long list of parameters. I am thinking of biting the bullet and doing that - any objections? > > In general I'm worried about having single gigantic class that keep many data members, this goes against https://en.wikipedia.org/wiki/Single_responsibility_principle and makes it hard to track what is initialized, where, and under which condition (basically one of the reason why global variables are not welcome). The code is almost always easier to understand with small separated components (yes many places are drifting a lot in LLVM...). > > Not to say...
2016 Apr 21
3
Refactor BitcodeWriter into classes?
I am currently making some BitcodeWriter changes that involve some refactoring, and am thinking for the Nth time that it would be much nicer to have a class instead of passing around a long list of parameters. I am thinking of biting the bullet and doing that - any objections? I assume the reason why there is no existing class wrapping the bitcode writing process is just legacy code and nothing