search for: sinclude

Automake insists that any file present in a Makefile.am 'include' must be present, but it has no idea about the GNU make extension 'sinclude'. Use this to our advantage: as long as Makefile.inc has nothing other than variable modifications (done in the previous patch), and our rules properly generate it when needed (thanks to generator_built), then running 'make' will still build all the right man pages, and 'make dist&...

‘make clean && make’ was not rebuilding the docs/*.3 files. The reason is obscure: - docs/Makefile has rules: MANS = $(man_MANS) all: all-am all-am: Makefile $(MANS) - sinclude docs/Makefile.inc happened long after MANS is defined, so MANS held the earlier version of $(man_MANS) without the api-built man pages listed. This was confirmed by looking at the output of ‘make -d -C docs all-am’ and examining what happens when rebuilding all-am. The fix is to change docs...

...Rich's change. I'll go ahead and push it. docs/Makefile.am | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/docs/Makefile.am b/docs/Makefile.am index 30a972d..dd34a3a 100644 --- a/docs/Makefile.am +++ b/docs/Makefile.am @@ -21,8 +21,12 @@ api_built= # Our use of sinclude to bypass Automake is intentional; this file won't # exist in a fresh git checkout until after the generator has run, but -# should already be present in any released tarball. +# should already be present in any released tarball. But, since automake +# can't see into this file, it did not...

...lem when trying to add support for ogg/vorbis into a package today: Automake assumes that anything beginning with AM_ belongs to automake -- these two macros are actually infringing on the automake namespace. This can cause problems if you don't include *.m4 by value in acinclude.m4 -- if you sinclude(ogg.m4) for example, aclocal won't be able to find AM_PATH_OGG because it doesn't understand sinclude, and it will generate an error because it thinks that some internal automake macro was not found. The solution is to change the DEFUN name for these two m4 macros. Perhaps CHECK_PATH_AO, C...

Rich recently patched things to generate one man page per function rather than libnbd-api.3 (nice), but in doing so got stumped by a problem with a fresh git clone (automake fails for any 'include' directive that does not already exist). I've figured out how to hack around it, but the hack requires GNU make. We already use GNU make constructs elsewhere (such as $(wildcard)), but