search for: sii8620

...+0100, Andrzej Hajda wrote: > Quite late, hopefully not too late. > > > On 21.11.2018 12:51, Ville Syrjälä wrote: > > On Wed, Nov 21, 2018 at 01:40:43PM +0200, Jani Nikula wrote: > >> > >>> return; > >>> diff --git a/drivers/gpu/drm/bridge/sil-sii8620.c b/drivers/gpu/drm/bridge/sil-sii8620.c > >>> index a6e8f4591e63..0cc293a6ac24 100644 > >>> --- a/drivers/gpu/drm/bridge/sil-sii8620.c > >>> +++ b/drivers/gpu/drm/bridge/sil-sii8620.c > >>> @@ -1104,8 +1104,7 @@ static void sii8620_set_infoframes(str...

...ite late, hopefully not too late. > >> > >> > >> On 21.11.2018 12:51, Ville Syrjälä wrote: > >>> On Wed, Nov 21, 2018 at 01:40:43PM +0200, Jani Nikula wrote: > >>>>> return; > >>>>> diff --git a/drivers/gpu/drm/bridge/sil-sii8620.c b/drivers/gpu/drm/bridge/sil-sii8620.c > >>>>> index a6e8f4591e63..0cc293a6ac24 100644 > >>>>> --- a/drivers/gpu/drm/bridge/sil-sii8620.c > >>>>> +++ b/drivers/gpu/drm/bridge/sil-sii8620.c > >>>>> @@ -1104,8 +1104,7 @@ static...

....c | 2 +- > > drivers/gpu/drm/amd/amdgpu/dce_v6_0.c | 3 ++- > > drivers/gpu/drm/amd/amdgpu/dce_v8_0.c | 2 +- > > drivers/gpu/drm/bridge/analogix-anx78xx.c | 5 ++-- > > drivers/gpu/drm/bridge/sii902x.c | 3 ++- > > drivers/gpu/drm/bridge/sil-sii8620.c | 3 +-- > > drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 3 ++- > > drivers/gpu/drm/drm_edid.c | 33 ++++++++++++++--------- > > drivers/gpu/drm/exynos/exynos_hdmi.c | 3 ++- > > drivers/gpu/drm/i2c/tda998x_drv.c | 3 ++- > > driv...

Quite late, hopefully not too late. On 21.11.2018 12:51, Ville Syrjälä wrote: > On Wed, Nov 21, 2018 at 01:40:43PM +0200, Jani Nikula wrote: >> >>> return; >>> diff --git a/drivers/gpu/drm/bridge/sil-sii8620.c b/drivers/gpu/drm/bridge/sil-sii8620.c >>> index a6e8f4591e63..0cc293a6ac24 100644 >>> --- a/drivers/gpu/drm/bridge/sil-sii8620.c >>> +++ b/drivers/gpu/drm/bridge/sil-sii8620.c >>> @@ -1104,8 +1104,7 @@ static void sii8620_set_infoframes(struct sii8620 *ctx, &g...

...drzej Hajda wrote: >> Quite late, hopefully not too late. >> >> >> On 21.11.2018 12:51, Ville Syrjälä wrote: >>> On Wed, Nov 21, 2018 at 01:40:43PM +0200, Jani Nikula wrote: >>>>> return; >>>>> diff --git a/drivers/gpu/drm/bridge/sil-sii8620.c b/drivers/gpu/drm/bridge/sil-sii8620.c >>>>> index a6e8f4591e63..0cc293a6ac24 100644 >>>>> --- a/drivers/gpu/drm/bridge/sil-sii8620.c >>>>> +++ b/drivers/gpu/drm/bridge/sil-sii8620.c >>>>> @@ -1104,8 +1104,7 @@ static void sii8620_set_in...

...y not too late. >>>> >>>> >>>> On 21.11.2018 12:51, Ville Syrjälä wrote: >>>>> On Wed, Nov 21, 2018 at 01:40:43PM +0200, Jani Nikula wrote: >>>>>>> return; >>>>>>> diff --git a/drivers/gpu/drm/bridge/sil-sii8620.c b/drivers/gpu/drm/bridge/sil-sii8620.c >>>>>>> index a6e8f4591e63..0cc293a6ac24 100644 >>>>>>> --- a/drivers/gpu/drm/bridge/sil-sii8620.c >>>>>>> +++ b/drivers/gpu/drm/bridge/sil-sii8620.c >>>>>>> @@ -1104,8 +1104...

...gt;> > >>>> > >>>> On 21.11.2018 12:51, Ville Syrjälä wrote: > >>>>> On Wed, Nov 21, 2018 at 01:40:43PM +0200, Jani Nikula wrote: > >>>>>>> return; > >>>>>>> diff --git a/drivers/gpu/drm/bridge/sil-sii8620.c b/drivers/gpu/drm/bridge/sil-sii8620.c > >>>>>>> index a6e8f4591e63..0cc293a6ac24 100644 > >>>>>>> --- a/drivers/gpu/drm/bridge/sil-sii8620.c > >>>>>>> +++ b/drivers/gpu/drm/bridge/sil-sii8620.c > >>>>>>&...

...c | 2 +- drivers/gpu/drm/amd/amdgpu/dce_v11_0.c | 2 +- drivers/gpu/drm/amd/amdgpu/dce_v6_0.c | 3 ++- drivers/gpu/drm/amd/amdgpu/dce_v8_0.c | 2 +- drivers/gpu/drm/bridge/analogix-anx78xx.c | 5 ++-- drivers/gpu/drm/bridge/sii902x.c | 3 ++- drivers/gpu/drm/bridge/sil-sii8620.c | 3 +-- drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 3 ++- drivers/gpu/drm/drm_edid.c | 33 ++++++++++++++--------- drivers/gpu/drm/exynos/exynos_hdmi.c | 3 ++- drivers/gpu/drm/i2c/tda998x_drv.c | 3 ++- drivers/gpu/drm/i915/intel_hdmi.c | 14 +++++--...

...t out of > the bridge drivers. Adding an additional dependency to connectors in the > bridges will make that more difficult. Ideally bridges should retrieve the > information from their sink, regardless of whether it is a connector or > another bridge. I agree with it, and case of sii8620 shows that there are cases where bridge has no direct access to the connector. On the other side,  since you are passing connector to drm_hdmi_avi_infoframe_from_display_mode(), you could drop mode parameter and rename the function to drm_hdmi_avi_infoframe_from_connector() then, unless mode passe...

...ville.syrjala at linux.intel.com> Make life easier for drivers by simply passing the connector to drm_hdmi_avi_infoframe_from_display_mode() and drm_hdmi_avi_infoframe_quant_range(). That way drivers don't need to worry about is_hdmi2_sink mess. v2: Make is_hdmi2_sink() return true for sil-sii8620 Adapt to omap/vc4 changes Cc: Alex Deucher <alexander.deucher at amd.com> Cc: "Christian König" <christian.koenig at amd.com> Cc: "David (ChunMing) Zhou" <David1.Zhou at amd.com> Cc: Archit Taneja <architt at codeaurora.org> Cc: Andrzej Hajda <a.h...

.../drm/amd/amdgpu/dce_v11_0.c | 2 +- > drivers/gpu/drm/amd/amdgpu/dce_v6_0.c | 3 ++- > drivers/gpu/drm/amd/amdgpu/dce_v8_0.c | 2 +- > drivers/gpu/drm/bridge/analogix-anx78xx.c | 5 ++-- > drivers/gpu/drm/bridge/sii902x.c | 3 ++- > drivers/gpu/drm/bridge/sil-sii8620.c | 3 +-- > drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 3 ++- > drivers/gpu/drm/drm_edid.c | 33 ++++++++++++++--------- > drivers/gpu/drm/exynos/exynos_hdmi.c | 3 ++- > drivers/gpu/drm/i2c/tda998x_drv.c | 3 ++- > drivers/gpu/drm/i915/intel_hd...

...g an additional dependency to connectors in the >>> bridges will make that more difficult. Ideally bridges should retrieve the >>> information from their sink, regardless of whether it is a connector or >>> another bridge. >> >> I agree with it, and case of sii8620 shows that there are cases where >> bridge has no direct access to the connector. > It's just a matter of plumbing it through. What do you mean exactly? > >> On the other side,  since you are passing connector to >> drm_hdmi_avi_infoframe_from_display_mode(), you cou...

...> dependency to connectors in the bridges will make that more >>>>>> difficult. Ideally bridges should retrieve the information from their >>>>>> sink, regardless of whether it is a connector or another bridge. >>>>> I agree with it, and case of sii8620 shows that there are cases where >>>>> bridge has no direct access to the connector. >>>> It's just a matter of plumbing it through. >>> What do you mean exactly? >> void bridge_foo(... >> + ,struct drm_connector *connector); >&gt...

...y to connectors in the > >>> bridges will make that more difficult. Ideally bridges should retrieve the > >>> information from their sink, regardless of whether it is a connector or > >>> another bridge. > >> > >> I agree with it, and case of sii8620 shows that there are cases where > >> bridge has no direct access to the connector. > > It's just a matter of plumbing it through. > > > What do you mean exactly? void bridge_foo(... + ,struct drm_connector *connector); > > > > > >&g...

...ers. Adding an additional dependency to connectors in the > > bridges will make that more difficult. Ideally bridges should retrieve the > > information from their sink, regardless of whether it is a connector or > > another bridge. > > > I agree with it, and case of sii8620 shows that there are cases where > bridge has no direct access to the connector. It's just a matter of plumbing it through. > > On the other side,  since you are passing connector to > drm_hdmi_avi_infoframe_from_display_mode(), you could drop mode > parameter and rename the f...

...dency to connectors in the bridges will make that more > >>>> difficult. Ideally bridges should retrieve the information from their > >>>> sink, regardless of whether it is a connector or another bridge. > >>> > >>> I agree with it, and case of sii8620 shows that there are cases where > >>> bridge has no direct access to the connector. > >> > >> It's just a matter of plumbing it through. > > > > What do you mean exactly? > > void bridge_foo(... > + ,struct drm_connector *conn...

.../drm/amd/amdgpu/dce_v11_0.c | 2 +- > drivers/gpu/drm/amd/amdgpu/dce_v6_0.c | 3 ++- > drivers/gpu/drm/amd/amdgpu/dce_v8_0.c | 2 +- > drivers/gpu/drm/bridge/analogix-anx78xx.c | 5 ++-- > drivers/gpu/drm/bridge/sii902x.c | 3 ++- > drivers/gpu/drm/bridge/sil-sii8620.c | 3 +-- > drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 3 ++- > drivers/gpu/drm/drm_edid.c | 33 ++++++++++++++--------- > drivers/gpu/drm/exynos/exynos_hdmi.c | 3 ++- > drivers/gpu/drm/i2c/tda998x_drv.c | 3 ++- > drivers/gpu/drm/i915/intel_hd...

.../drm/amd/amdgpu/dce_v11_0.c | 2 +- > drivers/gpu/drm/amd/amdgpu/dce_v6_0.c | 3 ++- > drivers/gpu/drm/amd/amdgpu/dce_v8_0.c | 2 +- > drivers/gpu/drm/bridge/analogix-anx78xx.c | 5 ++-- > drivers/gpu/drm/bridge/sii902x.c | 3 ++- > drivers/gpu/drm/bridge/sil-sii8620.c | 3 +-- > drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 3 ++- > drivers/gpu/drm/drm_edid.c | 33 ++++++++++++++--------- > drivers/gpu/drm/exynos/exynos_hdmi.c | 3 ++- > drivers/gpu/drm/i2c/tda998x_drv.c | 3 ++- > drivers/gpu/drm/i915/intel_hd...