search for: sigio

Hi Rusty, The main thing in these patches is the introduction of injecting SIGIO on host-side connect/disconnect events and when new data is available for ports. The first two patches fix bugs that I haven't seen, but look like the right thing to do. These have been tested extensively using the test-virtserial test suite. Please apply, Amit. Amit Shah (4): virtio: c...

Hi Rusty, The main thing in these patches is the introduction of injecting SIGIO on host-side connect/disconnect events and when new data is available for ports. The first two patches fix bugs that I haven't seen, but look like the right thing to do. These have been tested extensively using the test-virtserial test suite. Please apply, Amit. Amit Shah (4): virtio: c...

Hey Rusty, This patchset is on top of the previous one. It sends a SIGIO signal to apps that request signals for host activity. SIGIO is sent on host connect, disconnect as well as hot-unplug (which can be seen as a special case of host disconnect). Tested using several testcases in the test-virtserial repo: http://fedorapeople.org/gitweb?p=amitshah/public_git/test-vir...

Hey Rusty, This patchset is on top of the previous one. It sends a SIGIO signal to apps that request signals for host activity. SIGIO is sent on host connect, disconnect as well as hot-unplug (which can be seen as a special case of host disconnect). Tested using several testcases in the test-virtserial repo: http://fedorapeople.org/gitweb?p=amitshah/public_git/test-vir...

SIGIO should be sent when a port gets unplugged. It should only be sent to prcesses that have the port opened, and have asked for SIGIO to be delivered. We were clearing out guest_connected before calling send_sigio_to_port(), resulting in a sigio not getting sent to processes. Fix by setting guest_co...

...uot;strace -e open,close,write -f smbd -D" yielded: [pid 17704] open("foo/testfile.txt", O_RDWR|O_CREAT|O_NOFOLLOW, 0744) = 29 [some write()s to FD 24] [pid 17704] open("foo/testfile.txt", O_WRONLY|O_NOFOLLOW) = -1 EAGAIN (Resource temporarily unavailable) [pid 17704] --- SIGIO (I/O possible) @ 0 (0) --- [pid 17704] +++ killed by SIGIO +++ [pid 17478] --- SIGCHLD (Child exited) @ 0 (0) --- So this seemed to "explain" notepad thinking the file was saved successfully when I assume the SMB-protocol to not do "hard checks" for successful writes. Since the...

...before guest_connected and host_connected were set to false Amit Shah (9): virtio: console: fix race with port unplug and open/close virtio: console: fix race in port_fops_open() and port unplug virtio: console: clean up port data immediately at time of unplug virtio: console: fix raising SIGIO after port unplug virtio: console: return -ENODEV on all read operations after unplug virtio: console: add locks around buffer removal in port unplug path virtio: console: add locking in port unplug path virtio: console: fix locking around send_sigio_to_port() virtio: console: prevent use...

...before guest_connected and host_connected were set to false Amit Shah (9): virtio: console: fix race with port unplug and open/close virtio: console: fix race in port_fops_open() and port unplug virtio: console: clean up port data immediately at time of unplug virtio: console: fix raising SIGIO after port unplug virtio: console: return -ENODEV on all read operations after unplug virtio: console: add locks around buffer removal in port unplug path virtio: console: add locking in port unplug path virtio: console: fix locking around send_sigio_to_port() virtio: console: prevent use...

...le: clean up port data immediately at time of unplug virtio: console: return -ENODEV on all read operations after unplug virtio: console: update private_data in struct file only on successful open virtio: console: fix race in port_fops_poll() and port unplug virtio: console: fix raising SIGIO after port unplug virtio: console: add locks around buffer removal in port unplug path virtio: console: add locking in port unplug path virtio: console: fix locking around send_sigio_to_port() virtio: console: prevent use-after-free of port name in port unplug drivers/char/virtio_console....

...le: clean up port data immediately at time of unplug virtio: console: return -ENODEV on all read operations after unplug virtio: console: update private_data in struct file only on successful open virtio: console: fix race in port_fops_poll() and port unplug virtio: console: fix raising SIGIO after port unplug virtio: console: add locks around buffer removal in port unplug path virtio: console: add locking in port unplug path virtio: console: fix locking around send_sigio_to_port() virtio: console: prevent use-after-free of port name in port unplug drivers/char/virtio_console....

...le: clean up port data immediately at time of unplug virtio: console: return -ENODEV on all read operations after unplug virtio: console: update private_data in struct file only on successful open virtio: console: fix race in port_fops_poll() and port unplug virtio: console: fix raising SIGIO after port unplug virtio: console: add locks around buffer removal in port unplug path virtio: console: add locking in port unplug path virtio: console: fix locking around send_sigio_to_port() drivers/char/virtio_console.c | 67 ++++++++++++++++++++++++++++--------------- 1 file changed, 44...

...le: clean up port data immediately at time of unplug virtio: console: return -ENODEV on all read operations after unplug virtio: console: update private_data in struct file only on successful open virtio: console: fix race in port_fops_poll() and port unplug virtio: console: fix raising SIGIO after port unplug virtio: console: add locks around buffer removal in port unplug path virtio: console: add locking in port unplug path virtio: console: fix locking around send_sigio_to_port() drivers/char/virtio_console.c | 67 ++++++++++++++++++++++++++++--------------- 1 file changed, 44...

...urned. However, subsequent read()s returned 0, indicating there's no > host-side connection (but not indicating the device went away). > > This also happened when a port was unplugged and the user didn't have > any blocking operation pending. If the user didn't monitor the SIGIO > signal, they won't have a chance to find out if the port went away. > > Fix by returning -ENODEV on all read()s after the port gets unplugged. > write() already behaves this way. > > CC: <stable at vger.kernel.org> > Signed-off-by: Amit Shah <amit.shah at redhat....

...urned. However, subsequent read()s returned 0, indicating there's no > host-side connection (but not indicating the device went away). > > This also happened when a port was unplugged and the user didn't have > any blocking operation pending. If the user didn't monitor the SIGIO > signal, they won't have a chance to find out if the port went away. > > Fix by returning -ENODEV on all read()s after the port gets unplugged. > write() already behaves this way. > > CC: <stable at vger.kernel.org> > Signed-off-by: Amit Shah <amit.shah at redhat....

send_sigio_to_port() checks the value of guest_connected, which we always modify under the inbuf_lock; make sure invocations of send_sigio_to_port() have take the inbuf_lock around the call. Signed-off-by: Amit Shah <amit.shah at redhat.com> --- drivers/char/virtio_console.c | 8 +++++--- 1 file chang...

...+#define SIGKILL 9 +#define SIGBUS 10 +#define SIGSEGV 11 +#define SIGSYS 12 +#define SIGPIPE 13 +#define SIGALRM 14 +#define SIGTERM 15 +#define SIGURG 16 +#define SIGSTOP 17 +#define SIGTSTP 18 +#define SIGCONT 19 +#define SIGCHLD 20 +#define SIGTTIN 21 +#define SIGTTOU 22 +#define SIGIO 23 +#define SIGXCPU 24 +#define SIGXFSZ 25 +#define SIGVTALRM 26 +#define SIGPROF 27 +#define SIGWINCH 28 +#define SIGINFO 29 +#define SIGUSR1 30 +#define SIGUSR2 31 + +#define SIGPOLL SIGIO +#define SIGPWR SIGINFO +#define SIGIOT SIGABRT + +#define SA_ONSTACK 0x00000001 +#define SA_RESTA...

...h> int main(int argc, char *argv[]) { int s, p; if(argc != 2) { fputs("Please specify a pid to send signal to.\n", stderr); exit(0); } else { p = atoi(argv[1]); } fcntl(0,F_SETOWN,p); s = fcntl(0,F_GETFL,0); fcntl(0,F_SETFL,s|O_ASYNC); printf("Sending SIGIO - press enter.\n"); getchar(); fcntl(0,F_SETFL,s&~O_ASYNC); printf("SIGIO send attempted.\n"); return 0; } This can kill from a normal user account the inetd process under Linux 2.0.34 by sending a SIGIO. Very bad. The fix is to invert !euid to euid in fs/fcntl.c:send_...

I've made two little patches to allow dovecot to be compiled on GNU/Hurd. Could you review them? Kind regards, Marco Nenciarini -- --------------------------------------------------------------------- | Marco Nenciarini | Debian/GNU Linux Developer - Plug Member | | mnencia at prato.linux.it | http://www.prato.linux.it/~mnencia |

...define _NSIG 64 +#define _NSIG_BPW 32 +#define _NSIG_WORDS (_NSIG / _NSIG_BPW) + +typedef struct { + unsigned long sig[_NSIG_WORDS]; +} sigset_t; + +#define SIGHUP 1 +#define SIGINT 2 +#define SIGQUIT 3 +#define SIGILL 4 +#define SIGTRAP 5 +#define SIGABRT 6 +#define SIGIOT 6 +#define SIGBUS 7 +#define SIGFPE 8 +#define SIGKILL 9 +#define SIGUSR1 10 +#define SIGSEGV 11 +#define SIGUSR2 12 +#define SIGPIPE 13 +#define SIGALRM 14 +#define SIGTERM 15 +#define SIGSTKFLT 16 +#define SIGCHLD 17 +#define SIGCONT 18 +#define SIGSTOP 19 +#define SIGTSTP 20 +...

Most important fix is the use of input_lock() instead of the old SIGIO stuff to handle the input thread in server 1.19. This version now supports tablet pads and exposes properties for changing the tap button mapping and the rotation. Eric Engestrom (1): man: fix a couple typos Keith Packard (2): Use xf86AddEnabledDevice instead of AddEnabledDevice when...