search for: sig_int

...: main.c =================================================================== RCS file: /cvsroot/rsync/main.c,v retrieving revision 1.135 diff -u -u -r1.135 main.c --- main.c 11 Jan 2002 07:16:11 -0000 1.135 +++ main.c 11 Jan 2002 07:23:18 -0000 @@ -821,9 +821,11 @@ } signal(SIGINT,SIGNAL_CAST sig_int); - signal(SIGPIPE,SIGNAL_CAST sig_int); signal(SIGHUP,SIGNAL_CAST sig_int); signal(SIGTERM,SIGNAL_CAST sig_int); + + /* Ignore SIGPIPE; we check error codes consistently. */ + signal(SIGPIPE,SIG_IGN); /* Initialize push_dir here because on some old systems getcwd (implemented by forki...

...ity). (2) Secondly, if I connect to rsync daemon from another machine and hit ctrl-c at the client end during transfer, the rsync daemon exists (not just the connection handler process, but every rsync). I guess this is because rsync gets sigpipe signal, which is handled by sig_int, which in turn sends sigusr to the parent. I have no idea why this should be. I changed sigpipe handler to SIG_IGN, and I now get the behaviour I want: if there is a network error (such as premature socket closing) the rysnc daemon won't die, and I can reconnect to i...

I've run into a bug in the IO handling when reading a file. Suppose I have a file that lives on an NFS filesystem. That filesystem is NOT being exported with auth=0 permissions. So, if I try to access a file as root, it successfully opens the file, but subsequent reads fail with EACCES. This produces a destination file full of null bytes. I noticed this with 2.5.7, but checked 2.6.2 as

...oc.c:346 #12 0x00007f7ef04007cd in _rtld_bind_start () from /usr/libexec/ld.elf_so #13 0x0000000000000202 in ?? () #14 0x00007f7fff901dd0 in ?? () #15 0x0000000000000000 in ?? () The backtrace suggests, and inspection of the code confirms, that rsync calls exit() from a signal handler, for example sig_int() -> exit_cleanup() -> _exit_cleanup() -> exit(). This is incorrect as exit() is not async-signal-safe. -- You are receiving this mail because: You are the QA Contact for the bug.

...: %s (code %d) at %s(%d) [%s=%s]\n") at log.c:405 #8 0x000000000041eeec in log_exit (code=20, file=0x4446f5 "rsync.c", line=545) at log.c:836 #9 0x00000000004133f9 in _exit_cleanup (code=20, file=0x4446f5 "rsync.c", line=545) at cleanup.c:190 #10 0x000000000040ab62 in sig_int (val=<value optimized out>) at rsync.c:545 #11 <signal handler called> #12 0x00002b968915debc in ptmalloc_unlock_all () from /lib64/libc.so.6 #13 0x00002b968918947f in fork () from /lib64/libc.so.6 #14 0x000000000042c945 in start_accept_loop (port=12666, fn=0x436a80 <start_daemon>...

...ses, @@ -1000,6 +1001,14 @@ * code here, rather than relying on getopt. */ option_error(); exit_cleanup(RERR_SYNTAX); + } + + if (!lp_load(config_file, 1)) { + exit_cleanup(RERR_SYNTAX); + } + + if(lp_rsync_port() != 0) { + rsync_port = lp_rsync_port(); } signal(SIGINT,SIGNAL_CAST sig_int); Only in rsync-dmn/popt: dummy Only in rsync-dmn/zlib: dummy

> Just curious: what about the rsync+ patch? Thanks for the reminder. I've just committed Jos's rsync+ patch onto the "branch_mbp_rsyncplus_merge" branch. If it works OK and nobody screams I will move it across onto the main tree tomorrow or Wednesday. I see the patch doesn't add documentation about the new options to the man page, so we should fix that in the future.

...x8088eec "rsync error: %s (code %d) at %s(%d) [%s=%s]\n") at log.c:385 #7 0x0805d86c in log_exit (code=20, file=0x8086ecb "rsync.c", line=260) at log.c:792 #8 0x08051e3d in _exit_cleanup (code=20, file=0x8086ecb "rsync.c", line=260) at cleanup.c:154 #9 0x0804b395 in sig_int (val=15) at rsync.c:260 #10 <signal handler called> #11 0x473ad402 in __kernel_vsyscall () #12 0x4748cddd in ___newselect_nocancel () from /lib/libc.so.6 #13 0x0806a397 in writefd_unbuffered (fd=0, buf=0xbfecc7bc "h\002", len=620) at io.c:1074 #14 0x080692e9 in mplex_write (code=Var...

All callers of robust_rename() call copy_file() if EXDEV is received. This patch moves the copy_file() call into robust_rename(). Patch Summary: -12 +1 backup.c -15 +2 rsync.c -9 +33 util.c -------------- next part -------------- patchwork diff util.c --- util.c 2004-02-17 09:58:44.000000000 -0500 +++ util.c 2004-02-17 10:21:22.000000000 -0500 @@ -355,16 +355,40 @@

...+ D = c->h3; + E = c->h4; + + } +} + +#endif diff --git a/main.c b/main.c index 6a6ac55967ef9..6774c2e6a1007 100644 --- a/main.c +++ b/main.c @@ -1597,6 +1597,8 @@ int main(int argc,char *argv[]) exit_cleanup(RERR_SYNTAX); } + mdlib_initialize(); + SIGACTMASK(SIGINT, sig_int); SIGACTMASK(SIGHUP, sig_int); SIGACTMASK(SIGTERM, sig_int); diff --git a/rsync.h b/rsync.h index 641ba74073de3..87326e9e284ca 100644 --- a/rsync.h +++ b/rsync.h @@ -98,7 +98,7 @@ == ((unsigned)(b2) & (unsigned)(mask))) /* update this if you make incompatible changes */ -#define...

..._mutable(const char *fname, mode_t mode, uint32 fileflags, > uint32 iflags); > +int undo_make_mutable(const char *fname, uint32 fileflags); > int set_file_attrs(const char *fname, struct file_struct *file, > stat_x *sxp, > const char *fnamecmp, int flags); > RETSIGTYPE sig_int(UNUSED(int val)); > @@ -293,11 +295,12 @@ int sock_exec(const char *prog); > int do_unlink(const char *fname); > int do_symlink(const char *fname1, const char *fname2); > int do_link(const char *fname1, const char *fname2); > -int do_lchown(const char *path, uid_t owner, gid_t gro...

...r. At the client system, approx. 620MB (aka. nearly all) memory is allocated to compare the file list (the sync is set up with -auvH). The files are transfered - when running it the 1st time, all files are transfered of course - and the transfer stops at the client after an hour with rsync.c:sig_int() called. rsync error: received SIGUSR1 or SIGINT (code 20) at rsync.c(230) rsync error: received SIGUSR1 or SIGINT (code 20) at main.c(741) where I do not see *anything* that is interfering (not me either). OK I say, better luck next time. However, as no rsync process remains at the client...

...correctly identifies the build machine as little-endian (i386) and even if I override things and set CAREFUL_ALIGNMENT rsync still bails with those invalid file index errors. Some warnings were produced during the build but they all look harmless to me. Things like: rsync.c: In function ?sig_int?: rsync.c:231: warning: unused parameter ?val? This is because __attribute__((__unused__)) is omitted on the Mac OS X builds because of a bug in GCC; incidentally, that bug is no longer present in the current version: $ gcc --version i686-apple-darwin8-gcc-4.0.1 (GCC) 4.0.1 (Apple Computer, I...

...*f); +void write_sum_head(int f, struct sum_struct *sum); void recv_generator(char *fname, struct file_list *flist, int i, int f_out); void generate_files(int f,struct file_list *flist,char *local_name,int f_recv); int main(int argc, char *argv[]); @@ -190,6 +191,7 @@ int report); void sig_int(void); void finish_transfer(char *fname, char *fnametmp, struct file_struct *file); +void read_sum_head(int f, struct sum_struct *sum); void send_files(struct file_list *flist,int f_out,int f_in); int try_bind_local(int s, int ai_family, int ai_socktype, --- generator.c Sat Mar 29 11:11:3...

...[ac++] = "--from0"; } } + + if (delete_sent_files) + args[ac++] = "--delete-sent-files"; *argc = ac; } Index: proto.h --- proto.h 15 Jan 2004 07:42:23 -0000 1.172 +++ proto.h 17 Jan 2004 05:04:55 -0000 @@ -193,6 +193,7 @@ int set_perms(char *fname,struct file_st void sig_int(void); void finish_transfer(char *fname, char *fnametmp, struct file_struct *file); void read_sum_head(int f, struct sum_struct *sum); +void successful_send(int i); void send_files(struct file_list *flist, int f_out, int f_in); int try_bind_local(int s, int ai_family, int ai_socktype, con...

...rgv += optind; optind = 0; + + if (source_list && + ((argc != 2) || + !(src_list_fp = (strcmp(argv[0],"-") ? + fopen(argv[0],"r") : stdin)))) { + usage(FERROR); + exit_cleanup(RERR_SYNTAX); + } signal(SIGCHLD,SIG_IGN); signal(SIGINT,SIGNAL_CAST sig_int); --- options.c.orig Tue Sep 5 22:46:43 2000 +++ options.c Fri Nov 9 12:03:39 2001 @@ -53,6 +53,10 @@ int module_id = -1; int am_server = 0; int am_sender=0; +int source_list=0; +int list_rs='\n'; +int send_dirs=0; +int implicit_dirs=1; int recurse = 0; int am_daemon=0; int do_stats...

..._perms, int exists); +void make_mutable(const char *fname, mode_t mode, uint32 fileflags); +void undo_make_mutable(const char *fname, mode_t mode, uint32 fileflags); int set_file_attrs(const char *fname, struct file_struct *file, stat_x *sxp, const char *fnamecmp, int flags); RETSIGTYPE sig_int(UNUSED(int val)); @@ -296,6 +298,7 @@ int do_mknod(const char *pathname, mode_ int do_rmdir(const char *pathname); int do_open(const char *pathname, int flags, mode_t mode); int do_chmod(const char *path, mode_t mode); +int do_chflags(const char *path, u_long flags); int do_rename(const char *f...