search for: sideaffect

Since quirk_nvidia_hda() was added there's now two nvidia device functions on any laptops with nvidia GPUs: the HDA controller, and the GPU itself. Unfortunately this has the sideaffect of breaking quirk_reset_lenovo_thinkpad_50_nvgpu() since pci_reset_function() was using pci_parent_bus_reset() to reset the GPU's respective PCI bus, and pci_parent_bus_reset() does not work on busses which have more then a single device function present. So, fix this by simply calling pci_res...

This reverts commit b516ea586d717472178e6ef1c152e85608b0ce32. While this fixes audio for a number of users, this commit has the sideaffect of breaking the BIOS workaround that's required to make the GPU on the nvidia P50 work, by causing the GPU's PCI device function to stop working after it's been set to multifunction mode. Signed-off-by: Lyude Paul <lyude at redhat.com> Fixes: b516ea586d71 ("PCI: Enable NVIDI...

...g in a rather subtle way. If ->best_encoder() returns NULL, this makes ALL modesets involving the connector fail. This includes modesets from userspace that would shut off the CRTCs being used by the connector. Since this results in blocking any changes to a connector's DPMS prop, it has the sideaffect of preventing legacy modesetting users from ever disabling a CRTC that was previously enabled for use in an MST topology. An example of this, where X tries to change the DPMS property of an MST connector that was just detached from the system: [ 2908.320131] [drm:drm_helper_probe_single_connector_...

...g in a rather subtle way. If ->best_encoder() returns NULL, this makes ALL modesets involving the connector fail. This includes modesets from userspace that would shut off the CRTCs being used by the connector. Since this results in blocking any changes to a connector's DPMS prop, it has the sideaffect of preventing legacy modesetting users from ever disabling a CRTC that was previously enabled for use in an MST topology. An example of this, where X tries to change the DPMS property of an MST connector that was just detached from the system: [ 2908.320131] [drm:drm_helper_probe_single_connector_...

On Wed, Jul 31, 2019 at 04:19:27PM -0400, Lyude Paul wrote: > While this fixes audio for a number of users, this commit has the > sideaffect of breaking the BIOS workaround that's required to make the > GPU on the nvidia P50 work, by causing the GPU's PCI device function to > stop working after it's been set to multifunction mode. This is missing a reference to the commit introducing the P50 quirk, which is e0547c81bf...

...e > > > > > > > > This results in some very strange behavior: the GPU will quite > > > > literally be left in exactly the same state it was in when the > > > > previously booted kernel started the reboot. This has all > > > > sorts of bad sideaffects: for starters, this completely breaks > > > > nouveau starting with a mysterious EVO channel failure that > > > > happens well before we've actually used the EVO channel for > > > > anything: Thanks for the hybrid tutorial (snipped from this response). IIU...

..., 2019-07-31 at 23:26 +0200, Karol Herbst wrote: > On Wed, Jul 31, 2019 at 11:18 PM Lukas Wunner <lukas at wunner.de> wrote: > > On Wed, Jul 31, 2019 at 04:19:27PM -0400, Lyude Paul wrote: > > > While this fixes audio for a number of users, this commit has the > > > sideaffect of breaking the BIOS workaround that's required to make the > > > GPU on the nvidia P50 work, by causing the GPU's PCI device function to > > > stop working after it's been set to multifunction mode. > > > > This is missing a reference to the commit introd...

...t; > > This results in some very strange behavior: the GPU will quite > > > > > > literally be left in exactly the same state it was in when the > > > > > > previously booted kernel started the reboot. This has all > > > > > > sorts of bad sideaffects: for starters, this completely breaks > > > > > > nouveau starting with a mysterious EVO channel failure that > > > > > > happens well before we've actually used the EVO channel for > > > > > > anything: > > > > Thanks for the...

On Wed, Jul 31, 2019 at 11:18 PM Lukas Wunner <lukas at wunner.de> wrote: > > On Wed, Jul 31, 2019 at 04:19:27PM -0400, Lyude Paul wrote: > > While this fixes audio for a number of users, this commit has the > > sideaffect of breaking the BIOS workaround that's required to make the > > GPU on the nvidia P50 work, by causing the GPU's PCI device function to > > stop working after it's been set to multifunction mode. > > This is missing a reference to the commit introducing the P50 quirk,...

...; > > > > > This results in some very strange behavior: the GPU will quite > > > > > literally be left in exactly the same state it was in when the > > > > > previously booted kernel started the reboot. This has all > > > > > sorts of bad sideaffects: for starters, this completely breaks > > > > > nouveau starting with a mysterious EVO channel failure that > > > > > happens well before we've actually used the EVO channel for > > > > > anything: > > Thanks for the hybrid tutorial (snipped...

...is results in some very strange behavior: the GPU will quite > > > > > > > literally be left in exactly the same state it was in when the > > > > > > > previously booted kernel started the reboot. This has all > > > > > > > sorts of bad sideaffects: for starters, this completely breaks > > > > > > > nouveau starting with a mysterious EVO channel failure that > > > > > > > happens well before we've actually used the EVO channel for > > > > > > > anything: > > > >...

...k to > > step 2 until you reproduce the issue > > > > This results in some very strange behavior: the GPU will > > quite literally be left in exactly the same state it was in when the > > previously booted kernel started the reboot. This has all sorts of bad > > sideaffects: for starters, this completely breaks nouveau starting with a > > mysterious EVO channel failure that happens well before we've actually > > used the EVO channel for anything: > > There are a lot of moving parts here that are probably obvious to you > but not to me. I ne...

...uveau loads up properly, reboot the machine again and go back to step 2 until you reproduce the issue This results in some very strange behavior: the GPU will quite literally be left in exactly the same state it was in when the previously booted kernel started the reboot. This has all sorts of bad sideaffects: for starters, this completely breaks nouveau starting with a mysterious EVO channel failure that happens well before we've actually used the EVO channel for anything: nouveau 0000:01:00.0: disp: chid 0 mthd 0000 data 00000400 00001000 00000002 Later on, this causes us to timeout trying to b...

...t the machine again and go back to > step 2 until you reproduce the issue > > This results in some very strange behavior: the GPU will > quite literally be left in exactly the same state it was in when the > previously booted kernel started the reboot. This has all sorts of bad > sideaffects: for starters, this completely breaks nouveau starting with a > mysterious EVO channel failure that happens well before we've actually > used the EVO channel for anything: There are a lot of moving parts here that are probably obvious to you but not to me. I need help untangling this a...

...il you reproduce the issue > > > > > > This results in some very strange behavior: the GPU will > > > quite literally be left in exactly the same state it was in when the > > > previously booted kernel started the reboot. This has all sorts of bad > > > sideaffects: for starters, this completely breaks nouveau starting with > > > a > > > mysterious EVO channel failure that happens well before we've actually > > > used the EVO channel for anything: > > > > There are a lot of moving parts here that are probably obvio...

...ome very strange behavior: the GPU will quite > > > > > > > > literally be left in exactly the same state it was in when the > > > > > > > > previously booted kernel started the reboot. This has all > > > > > > > > sorts of bad sideaffects: for starters, this completely breaks > > > > > > > > nouveau starting with a mysterious EVO channel failure that > > > > > > > > happens well before we've actually used the EVO channel for > > > > > > > > anything: > &...