search for: shut_rd

The Linux implementation of TCP sockets has a bug which causes shutdown(sock, SHUT_RD) to fail spuriously (ENOTCONN) if the write side of the socket has already been shut down. If you are using SSH port forwarding to tunnel HTTP through a firewall, nchan.c will tickle this bug once for every HTTP exchange. You will therefore get lots of useless, annoying error messages: channel 2...

On Sat, Aug 26, 2023 at 08:59:00PM +0300, Arseniy Krasnov wrote: >This adds two tests for 'shutdown()' call. It checks that SIGPIPE is >sent when MSG_NOSIGNAL is not set and vice versa. Both flags SHUT_WR >and SHUT_RD are tested. > >Signed-off-by: Arseniy Krasnov <avkrasnov at salutedevices.com> >--- > tools/testing/vsock/vsock_test.c | 138 +++++++++++++++++++++++++++++++ > 1 file changed, 138 insertions(+) Reviewed-by: Stefano Garzarella <sgarzare at redhat.com> > >diff --git...

...dif #ifdef HAVE_UTMP_H # include <utmp.h> /* For _PATH_XXX */ #endif #ifdef HAVE_UTMPX_H # include <utmpx.h> /* For _PATH_XXX */ #endif #ifdef HAVE_SYS_TIME_H # include <sys/time.h> /* For timersub */ #endif #ifdef HAVE_MAILLOCK_H #include <maillock.h> #endif #ifndef SHUT_RDWR enum { SHUT_RD = 0, /* No more receptions. */ SHUT_WR, /* No more transmissions. */ SHUT_RDWR /* No more receptions or transmissions. */ }; # define SHUT_RD SHUT_RD # define SHUT_WR SHUT_WR # define SHUT_RDWR SHUT_RDWR #endif /* If sys/types.h does not supply intXX_t, supply th...

...Garzarella wrote: >>>>>> On Tue, Aug 01, 2023 at 05:17:26PM +0300, Arseniy Krasnov wrote: >>>>>>> POSIX requires to send SIGPIPE on write to SOCK_STREAM socket which was >>>>>>> shutdowned with SHUT_WR flag or its peer was shutdowned with SHUT_RD >>>>>>> flag. Also we must not send SIGPIPE if MSG_NOSIGNAL flag is set. >>>>>>> >>>>>>> Signed-off-by: Arseniy Krasnov <AVKrasnov at sberdevices.ru> >>>>>>> --- >>>>>>> net/vmw_vsock/af_v...

On Sat, Aug 26, 2023 at 08:58:59PM +0300, Arseniy Krasnov wrote: >POSIX requires to send SIGPIPE on write to SOCK_STREAM socket which was >shutdowned with SHUT_WR flag or its peer was shutdowned with SHUT_RD >flag. Also we must not send SIGPIPE if MSG_NOSIGNAL flag is set. > >Signed-off-by: Arseniy Krasnov <avkrasnov at salutedevices.com> >--- > net/vmw_vsock/af_vsock.c | 3 +++ > 1 file changed, 3 insertions(+) Reviewed-by: Stefano Garzarella <sgarzare at redhat.com> &gt...

Hi Arseniy, On Sat, Aug 26, 2023 at 08:58:58PM +0300, Arseniy Krasnov wrote: >Hello, > >this small patchset adds POSIX compliant behaviour on writes to the >socket which was shutdowned with 'shutdown()' (both sides - local with >SHUT_WR flag, peer - with SHUT_RD flag). According POSIX we must send >SIGPIPE in such cases (but SIGPIPE is not send when MSG_NOSIGNAL is set). > >First patch is implemented in the same way as net/ipv4/tcp.c:tcp_sendmsg_locked(). >It uses 'sk_stream_error()' function which handles EPIPE error. Another >way i...

...i Stefano, > >On 02.08.2023 10:46, Stefano Garzarella wrote: >> On Tue, Aug 01, 2023 at 05:17:26PM +0300, Arseniy Krasnov wrote: >>> POSIX requires to send SIGPIPE on write to SOCK_STREAM socket which was >>> shutdowned with SHUT_WR flag or its peer was shutdowned with SHUT_RD >>> flag. Also we must not send SIGPIPE if MSG_NOSIGNAL flag is set. >>> >>> Signed-off-by: Arseniy Krasnov <AVKrasnov at sberdevices.ru> >>> --- >>> net/vmw_vsock/af_vsock.c | 3 +++ >>> 1 file changed, 3 insertions(+) >>> >&gt...

...2.08.2023 10:46, Stefano Garzarella wrote: >>>> On Tue, Aug 01, 2023 at 05:17:26PM +0300, Arseniy Krasnov wrote: >>>>> POSIX requires to send SIGPIPE on write to SOCK_STREAM socket which was >>>>> shutdowned with SHUT_WR flag or its peer was shutdowned with SHUT_RD >>>>> flag. Also we must not send SIGPIPE if MSG_NOSIGNAL flag is set. >>>>> >>>>> Signed-off-by: Arseniy Krasnov <AVKrasnov at sberdevices.ru> >>>>> --- >>>>> net/vmw_vsock/af_vsock.c | 3 +++ >>>>> 1 fi...

...2.08.2023 10:46, Stefano Garzarella wrote: >>>> On Tue, Aug 01, 2023 at 05:17:26PM +0300, Arseniy Krasnov wrote: >>>>> POSIX requires to send SIGPIPE on write to SOCK_STREAM socket which was >>>>> shutdowned with SHUT_WR flag or its peer was shutdowned with SHUT_RD >>>>> flag. Also we must not send SIGPIPE if MSG_NOSIGNAL flag is set. >>>>> >>>>> Signed-off-by: Arseniy Krasnov <AVKrasnov at sberdevices.ru> >>>>> --- >>>>> net/vmw_vsock/af_vsock.c | 3 +++ >>>>> 1 fi...

...sh so that these warning lines are not printed? MY PRELIMINARY ANALYSIS of the PROBLEM. The message seems to come from the following routine in nchan.c: static void chan_shutdown_read(Channel *c) { debug("channel %d: shutdown_read", c->self); if (shutdown(c->sock, SHUT_RD) < 0) error("chan_shutdown_read failed for #%d/fd%d [i%d o%d]: %.100s", c->self, c->sock, c->istate, c->ostate, strerror(errno)); } Although the self and sock fields vary, ostate is 128 and istate is 1 in the warning messages. =======...

...TX: LEN:00000000 TYPE:0001 OP:4=SHUTDOWN TX: FLAGS:00000001 BUF_ALLOC:00040000 FWD_CNT:0000005e Guest SHUTDOWN_RX. I'm not sure if this is a direct kernel response to the SHUTDOWN_TX or if the application inside the guest saw an EOF when reading the socket and did the corresponding shutdown(SHUT_RD). TX: <=SRC:00000003.00000948 DST:00000002.00010002 TX: LEN:00000000 TYPE:0001 OP:4=SHUTDOWN TX: FLAGS:00000002 BUF_ALLOC:00040000 FWD_CNT:0000005e Guest SHUTDOWN_TX, I presume that having sent the only response it is going to it then does shutdown(SHUT_WR). TX: <=SRC:00000003.00000948...

When I encounter the problem with TCP port forwarding locking up, I'll see this on the client window (if I haven't invoked ssh with -q): chan_shutdown_read failed for #1/fd6: Transport endpoint is not connected chan_shutdown_read failed for #1/fd6: Transport endpoint is not connected This is with Blowfish encryption. I have to kill and restart the client when this happens. Phil

On Mon, Apr 11, 2016 at 03:54:08PM +0300, Michael S. Tsirkin wrote: > On Mon, Apr 11, 2016 at 11:45:48AM +0100, Stefan Hajnoczi wrote: > > On Fri, Apr 08, 2016 at 04:35:05PM +0100, Ian Campbell wrote: > > > On Fri, 2016-04-01 at 15:23 +0100, Stefan Hajnoczi wrote: > > > > This series is based on Michael Tsirkin's vhost branch (v4.5-rc6). > > > > >

On Mon, Apr 11, 2016 at 03:54:08PM +0300, Michael S. Tsirkin wrote: > On Mon, Apr 11, 2016 at 11:45:48AM +0100, Stefan Hajnoczi wrote: > > On Fri, Apr 08, 2016 at 04:35:05PM +0100, Ian Campbell wrote: > > > On Fri, 2016-04-01 at 15:23 +0100, Stefan Hajnoczi wrote: > > > > This series is based on Michael Tsirkin's vhost branch (v4.5-rc6). > > > > >

..._strerror... yes checking for library containing nanosleep... none required checking whether getrusage is declared... no checking whether strsep is declared... yes checking for strsep... yes checking whether tcsendbreak is declared... yes checking whether h_errno is declared... yes checking whether SHUT_RD is declared... yes checking whether O_NONBLOCK is declared... yes checking whether writev is declared... yes checking whether MAXSYMLINKS is declared... yes checking whether offsetof is declared... yes checking for setresuid... no checking for setresgid... no checking for gettimeofday... yes checki...

From: Andy King <acking at vmware.com> ** Introduce VM Sockets *** In an effort to improve the out-of-the-box experience with Linux kernels for VMware users, VMware is working on readying the VM Sockets (VSOCK, formerly VMCI Sockets) (vmw_vsock) kernel module for inclusion in the Linux kernel. The purpose of this post is to acquire feedback on the vmw_vsock kernel module. Unlike previous

From: Andy King <acking at vmware.com> ** Introduce VM Sockets *** In an effort to improve the out-of-the-box experience with Linux kernels for VMware users, VMware is working on readying the VM Sockets (VSOCK, formerly VMCI Sockets) (vmw_vsock) kernel module for inclusion in the Linux kernel. The purpose of this post is to acquire feedback on the vmw_vsock kernel module. Unlike previous

* * * This series of VSOCK linux upstreaming patches include latest udpate from VMware to address Greg's and all other's code review comments. Summary of changes: - Rebase our linux kernel tree from v3.5 to v3.7. - Fix all checkpatch warnings and errors. Fix some checkpatch with -strict errors. This addresses Greg's comment: On 15 Nov 2012

* * * This series of VSOCK linux upstreaming patches include latest udpate from VMware to address Greg's and all other's code review comments. Summary of changes: - Rebase our linux kernel tree from v3.5 to v3.7. - Fix all checkpatch warnings and errors. Fix some checkpatch with -strict errors. This addresses Greg's comment: On 15 Nov 2012

* * * This series of VSOCK linux upstreaming patches include latest udpate from VMware. Summary of changes: - Sparse clean. - Checkpatch clean with one exception, a "complex macro" in which we can't add parentheses. - Remove all runtime assertions. - Fix device name, so that existing user clients work. - Fix VMCI handle lookup. * *