Displaying 6 results from an estimated 6 matches for "shtarkman".
Did you mean:
shearman
2023 Feb 14
2
[PATCH 1/2] python: Avoid crash if callback parameters cannot be built
...Python event callback
fails, args was returned as NULL. We immediately tried to call
Py_INCREF on this which crashed. Returning NULL means the Python
function threw an exception, so print the exception and return (there
is no way to return an error here - the event is lost).
Reported-by: Yonatan Shtarkman
See: https://listman.redhat.com/archives/libguestfs/2023-February/030653.html
---
python/handle.c | 9 ++++++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/python/handle.c b/python/handle.c
index c8752baf47..f37e939e03 100644
--- a/python/handle.c
+++ b/python/handle.c
@@ -134,1...
2023 Feb 14
1
Issue with downloading files whose path contains multi-byte utf-8 characters
On Tue, Feb 14, 2023 at 08:02:59PM +0200, Yonatan Shtarkman wrote:
> The attached code snippet?reproduces the issue when running:
> python3 libugestfs_segfault_repro.py
>
> With:
> guestfs version: 1.48.6
> guestfs-python version: 1.48.6
Can confirm with {python3-,}libguestfs-1.51.1-1.fc39.x86_64
The stack trace is roughly the same as y...
2023 Feb 14
2
[PATCH 2/2] python: Use bytes instead of str for event callback buffer
...) UTF-8 but could contain any old byte sequence.
In the test case provided by the reported, we failed to encode the
buffer as str with this error:
UnicodeDecodeError: 'utf-8' codec can't decode byte 0xc3 in position 137: unexpected end of data
Use bytes instead.
Reported-by: Yonatan Shtarkman
See: https://listman.redhat.com/archives/libguestfs/2023-February/030653.html
---
python/handle.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/python/handle.c b/python/handle.c
index f37e939e03..bf639b5789 100644
--- a/python/handle.c
+++ b/python/handle.c
@@ -131,7 +131,7 @...
2023 Feb 13
3
Issue with downloading files whose path contains multi-byte utf-8 characters
On Sun, Feb 12, 2023 at 03:31:08PM +0200, Yonatan Shtarkman wrote:
> Hey,
> When downloading a file whose path contains multi-byte utf-8, libguestfs
> sometimes crashes.
> This reproduces when using python, and not when using guestfish.
>
> Code to reproduce:
> for i in range(2000):
> ? ? g.download ('/xxx?', '/tmp/1'...
2023 Feb 17
1
[PATCH 1/2] python: Avoid crash if callback parameters cannot be built
...NULL. We immediately tried to call
> > Py_INCREF on this which crashed. Returning NULL means the Python
> > function threw an exception, so print the exception and return (there
> > is no way to return an error here - the event is lost).
> >
> > Reported-by: Yonatan Shtarkman
> > See: https://listman.redhat.com/archives/libguestfs/2023-February/030653.html
> > ---
> > python/handle.c | 9 ++++++---
> > 1 file changed, 6 insertions(+), 3 deletions(-)
> >
> > diff --git a/python/handle.c b/python/handle.c
> > index c8752baf47..f...
2023 Feb 12
1
Issue with downloading files whose path contains multi-byte utf-8 characters
Hey,
When downloading a file whose path contains multi-byte utf-8, libguestfs
sometimes crashes.
This reproduces when using python, and not when using guestfish.
Code to reproduce:
for i in range(2000):
g.download ('/xxx?', '/tmp/1')
#0 raise (sig=<optimized out>) at ../sysdeps/unix/sysv/linux/raise.c:50
#1 0x00007ffff7fac140 in <signal handler called> () at