search for: shinfo

This patch introduce a new function that releases the xdp shinfo. The subsequent patch will reuse this function. Signed-off-by: Xuan Zhuo <xuanzhuo at linux.alibaba.com> --- drivers/net/virtio_net.c | 27 ++++++++++++++++----------- 1 file changed, 16 insertions(+), 11 deletions(-) diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c index 7...

virtnet_build_xdp_buff_mrg() and virtnet_xdp_handler() auto release xdp shinfo then the caller no need to careful the xdp shinfo. Signed-off-by: Xuan Zhuo <xuanzhuo at linux.alibaba.com> --- drivers/net/virtio_net.c | 29 +++++++++++++++++------------ 1 file changed, 17 insertions(+), 12 deletions(-) diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c in...

? 2023/3/28 20:04, Xuan Zhuo ??: > virtnet_build_xdp_buff_mrg() and virtnet_xdp_handler() auto I think you meant virtnet_xdp_handler() actually? > release xdp shinfo then the caller no need to careful the xdp shinfo. > > Signed-off-by: Xuan Zhuo <xuanzhuo at linux.alibaba.com> > --- > drivers/net/virtio_net.c | 29 +++++++++++++++++------------ > 1 file changed, 17 insertions(+), 12 deletions(-) > > diff --git a/drivers/net/virtio_...

...9137-1-xuanzhuo at linux.alibaba.com/ Xuan Zhuo (8): virtio_net: mergeable xdp: put old page immediately virtio_net: mergeable xdp: introduce mergeable_xdp_prepare virtio_net: introduce virtnet_xdp_handler() to seprate the logic of run xdp virtio_net: separate the logic of freeing xdp shinfo virtio_net: separate the logic of freeing the rest mergeable buf virtio_net: auto release xdp shinfo virtio_net: introduce receive_mergeable_xdp() virtio_net: introduce receive_small_xdp() drivers/net/virtio_net.c | 615 +++++++++++++++++++++++---------------- 1 file changed, 357 insertio...

...n the future. Please review. Thanks. Xuan Zhuo (8): virtio_net: mergeable xdp: put old page immediately virtio_net: mergeable xdp: introduce mergeable_xdp_prepare virtio_net: introduce virtnet_xdp_handler() to seprate the logic of run xdp virtio_net: separate the logic of freeing xdp shinfo virtio_net: separate the logic of freeing the rest mergeable buf virtio_net: auto release xdp shinfo virtio_net: introduce receive_mergeable_xdp() virtio_net: introduce receive_small_xdp() drivers/net/virtio_net.c | 615 +++++++++++++++++++++++---------------- 1 file changed, 357 insertio...

.... fix some variables are uninitialized Xuan Zhuo (8): virtio_net: mergeable xdp: put old page immediately virtio_net: mergeable xdp: introduce mergeable_xdp_prepare virtio_net: introduce virtnet_xdp_handler() to seprate the logic of run xdp virtio_net: separate the logic of freeing xdp shinfo virtio_net: separate the logic of freeing the rest mergeable buf virtio_net: auto release xdp shinfo virtio_net: introduce receive_mergeable_xdp() virtio_net: introduce receive_small_xdp() drivers/net/virtio_net.c | 618 +++++++++++++++++++++++---------------- 1 file changed, 360 insertio...

...had some interest from David VemLehn and Bart Van Assche regarding using this functionality in the context of vmsplice and iSCSI targets respectively (I think). Changes since last time: * The big change is that the patches now explicitly align the "nr_frags" member of the shinfo, as suggested by Alexander Duyck. This ensures that the placement is optimal irrespective of page size (in particular the variation of MAX_SKB_FRAGS). It is still the case that for 4k pages a maximum MTU frame + SKB_PAD + shinfo, still fit within 2048k....

...linux. > Xuan Zhuo (8): > virtio_net: mergeable xdp: put old page immediately > virtio_net: mergeable xdp: introduce mergeable_xdp_prepare > virtio_net: introduce virtnet_xdp_handler() to seprate the logic of > run xdp > virtio_net: separate the logic of freeing xdp shinfo > virtio_net: separate the logic of freeing the rest mergeable buf > virtio_net: auto release xdp shinfo > virtio_net: introduce receive_mergeable_xdp() > virtio_net: introduce receive_small_xdp() > > drivers/net/virtio_net.c | 615 +++++++++++++++++++++++----------------...

...tio_net: mergeable xdp: put old page immediately > > > virtio_net: mergeable xdp: introduce mergeable_xdp_prepare > > > virtio_net: introduce virtnet_xdp_handler() to seprate the logic of > > > run xdp > > > virtio_net: separate the logic of freeing xdp shinfo > > > virtio_net: separate the logic of freeing the rest mergeable buf > > > virtio_net: auto release xdp shinfo > > > virtio_net: introduce receive_mergeable_xdp() > > > virtio_net: introduce receive_small_xdp() > > > > > > drivers/net...

...(8): > > virtio_net: mergeable xdp: put old page immediately > > virtio_net: mergeable xdp: introduce mergeable_xdp_prepare > > virtio_net: introduce virtnet_xdp_handler() to seprate the logic of > > run xdp > > virtio_net: separate the logic of freeing xdp shinfo > > virtio_net: separate the logic of freeing the rest mergeable buf > > virtio_net: auto release xdp shinfo > > virtio_net: introduce receive_mergeable_xdp() > > virtio_net: introduce receive_small_xdp() > > > > drivers/net/virtio_net.c | 615 ++++++++++...

...); rcu_read_unlock(); goto xdp_xmit; default: @@ -1321,9 +1321,6 @@ static struct sk_buff *receive_mergeable(struct net_device *dev, goto err_xdp_frags; } err_xdp_frags: - if (unlikely(xdp_page != page)) - __free_pages(xdp_page, 0); - if (xdp_buff_has_frags(&xdp)) { shinfo = xdp_get_shared_info_from_buff(&xdp); for (i = 0; i < shinfo->nr_frags; i++) { -- 2.32.0.3.g01195cf9f

...dev, > goto err_xdp_frags; > } > err_xdp_frags: > - if (unlikely(xdp_page != page)) > - __free_pages(xdp_page, 0); > - > if (xdp_buff_has_frags(&xdp)) { > shinfo = xdp_get_shared_info_from_buff(&xdp); > for (i = 0; i < shinfo->nr_frags; i++) { > -- > 2.32.0.3.g01195cf9f >

...+++++++++++++--------------- 1 files changed, 19 insertions(+), 15 deletions(-) diff --git a/drivers/net/xen-netfront.c b/drivers/net/xen-netfront.c index d7c8a98..6e5d4c0 100644 --- a/drivers/net/xen-netfront.c +++ b/drivers/net/xen-netfront.c @@ -275,7 +275,7 @@ no_skb: break; } - skb_shinfo(skb)->frags[0].page = page; + __skb_fill_page_desc(skb, 0, page, 0, 0); skb_shinfo(skb)->nr_frags = 1; __skb_queue_tail(&np->rx_batch, skb); } @@ -309,8 +309,8 @@ no_skb: BUG_ON((signed short)ref < 0); np->grant_rx_ref[id] = ref; - pfn = page_to_pfn(skb_shinfo(s...

...ir.bootlin.com/linux/v6.3-rc3/source/net/core/page_pool.c#L500 Yes, but now we don't seem to be very good to distinguish it. But I think it doesn't matter. This logic is rare under actual situation. Thanks. > > > - > > if (xdp_buff_has_frags(&xdp)) { > > shinfo = xdp_get_shared_info_from_buff(&xdp); > > for (i = 0; i < shinfo->nr_frags; i++) { > >

The initial values of the wallclock time in the shared info page are set for PVHVM guests when the hypercall page is initialized, since the hypercall page is not reinitialized on resume, the hypervisor wallclock time is not properly set on resume. Fix it by forcing an update of the wallclock values when the shared info page is mapped. Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>

...iver for upstream one of the things I removed was the zero-copy guest transmit (i.e. netback receive) support. In this mode guest data pages ("foreign pages") were mapped into the backend domain (using Xen grant-table functionality) and placed into the skb''s paged frag list (skb_shinfo(skb)->frags, I hope I am using the right term). Once the page is finished with netback unmaps it in order to return it to the guest (we really want to avoid returning such pages to the general allocation pool!). Unfortunately "page is finished with" is an event which there is no way fo...

...omplete failed: ops = rcu_dereference(inet_offloads[proto]); Which I'm guessing means the packet didn't have a valid layer 4 protocol definition, or we don't have that protocol enabled. Then when attempting to handle that failure there was a GPF, I believe by accessing invalid data in shinfo->frag_list . "skb_release_data+0x73" is in __read_once_size, which I think is generated by "kfree_skb: if (likely(atomic_read(&skb->users) == 1))" . --Sarah

...en-4.0/lib/python/remus --no-net lindi-exp1 10.7.2.11 creates a paused version of lindi-exp1 successfully on 10.7.2.11 (overlord1) and starts updating it with output like ... PROF: resumed at 1294213416.981778 PROF: flushed memory at 1294213416.988018 PROF: suspending at 1294213417.180439 SUSPEND shinfo 000699f7 delta 1ms, dom0 100%, target 0%, sent 0Mb/s, dirtied 6225Mb/s 190 pages 3220: sent 179, skipped 0, delta 1ms, dom0 0%, target 0%, sent 5865Mb/s, dirtied 5865Mb/s 179 pages Total pages sent= 666245 (10.17x) (of which 0 were fixups) All memory is saved PROF: resumed at 1294213417.183659 PRO...

...mmand on two terminals >> >> (i) *remus --no-net 1 192.168.36.233 >> *(ii) *remus --no-net 2 192.168.36.233* >> >> >> Terminal 1 : >> The following error i got where i run command >> >> *remus --no-net 1 192.168.36.233* >> >> SUSPEND shinfo 00076122 >> delta 1ms, dom0 100%, target 0%, sent 0Mb/s, dirtied 2457Mb/s 75 pages >> 86: sent 72, skipped 0, delta 1ms, dom0 0%, target 0%, sent 2359Mb/s, >> dirtied 2359Mb/s 72 pages >> Total pages sent= 41424 (1.19x) >> (of which 0 were fixups) >> All memory...

...en-4.0/lib/python/remus --no-net lindi-exp1 10.7.2.11 creates a paused version of lindi-exp1 successfully on 10.7.2.11 (overlord1) and starts updating it with output like ... PROF: resumed at 1294213416.981778 PROF: flushed memory at 1294213416.988018 PROF: suspending at 1294213417.180439 SUSPEND shinfo 000699f7 delta 1ms, dom0 100%, target 0%, sent 0Mb/s, dirtied 6225Mb/s 190 pages 3220: sent 179, skipped 0, delta 1ms, dom0 0%, target 0%, sent 5865Mb/s, dirtied 5865Mb/s 179 pages Total pages sent= 666245 (10.17x) (of which 0 were fixups) All memory is saved PROF: resumed at 1294213417.183659 PRO...