search for: shilong

From: Wang Shilong <wangsl.fnst@cn.fujitsu.com> Scrubing supers is not in a transaction context, when trying to write supers to disk, we should check if we are trying to scrub supers.Fix it. Signed-off-by: Wang Shilong <wangsl.fnst@cn.fujitsu.com> --- fs/btrfs/disk-io.c | 2 ++ fs/btrfs/transaction...

I''m trying to use this feature of qgroup: btrfs qgroup assign <srcid> <destid> <path> Assigns the lower level qgroup src to the higher level qgroup dest in the btrfs found in <path>. It is used to build qgroup hierarchies. However, I fail to understand how this feature should work, and I''m getting "ERROR: bad relation requested":

...objectid 2.when we want to using interval subvolume path, we mount it other place that use subvolume 5 as its default subvolume. We''d better use the second approach because it won''t bother kernel change. Reported-by: Michael Welsh Duggan <mwd@md5i.com> Signed-off-by: Wang Shilong <wangsl.fnst@cn.fujitsu.com> Signed-off-by: Miao Xie <miaox@cn.fujitsu.com> --- cmds-receive.c | 51 +++++++++++++++++++++++++++++++++++++++++++++++---- utils.c | 28 ++++++++++++++++++++++++++++ utils.h | 1 + 3 files changed, 76 insertions(+), 4 deletions(-) diff --gi...

From: Wang Shilong <wangsl-fnst@cn.fujitsu.com> This patch tries to stop users to create/destroy qgroup level 0, users can only create/destroy qgroup level more than 0. See the fact: a subvolume/snapshot qgroup was created automatically when creating subvolume/snapshot, so creating a qgroup level 0 can'&...

From: Wang Shilong <wangsl-fnst@cn.fujitsu.com> The check work has been done just before the function btrfs_clean_quota_tree is called, it is not necessary to check it again, remove it. Signed-off-by: Wang Shilong <wangsl-fnst@cn.fujitsu.com> --- fs/btrfs/qgroup.c | 3 --- 1 files changed, 0 inserti...

From: Wang Shilong <wangsl-fnst@cn.fujitsu.com> commit eb6b88d92c6df083dd09a8c471011e3788dfd7c6 leads into another bug. If it is just because qgroup_reserve fails, the function btrfs_qgroup_free should not be called, otherwise, it will cause the wrong quota accounting. Signed-off-by: Wang Shilong <wangsl-f...

When using "-U" option with btrfs-corrupt-block, it will cause a segfault due to a missing break in getopt switch. Reported-by: Wang Shilong <wangsl.fnst@cn.fujitsu.com> Signed-off-by: Qu Wenruo <quwenruo@cn.fujitsu.com> --- btrfs-corrupt-block.c | 1 + 1 file changed, 1 insertion(+) diff --git a/btrfs-corrupt-block.c b/btrfs-corrupt-block.c index f0c14a9..a2828d4 100644 --- a/btrfs-corrupt-block.c +++ b/btrfs-corrupt-bloc...

...cause any problems, because in the tree_mod_alloc(), it ignores arg gfp_t and just use GFP_ATOMIC directly, this is not good. However, i think we should try best not to allocate with GFP_ATOMIC, so i keep the gfp_t there in the hope we can change allocation mode in the future. Signed-off-by: Wang Shilong <wangsl-fnst@cn.fujitsu.com> --- fs/btrfs/ctree.c | 37 ++++++++++++++++++------------------- 1 files changed, 18 insertions(+), 19 deletions(-) diff --git a/fs/btrfs/ctree.c b/fs/btrfs/ctree.c index de6de8e..33c9061 100644 --- a/fs/btrfs/ctree.c +++ b/fs/btrfs/ctree.c @@ -553,7 +553,7 @@...

...138688 items 0 free space 3995 generation 1 owner 7 fs uuid 2e08fd93-f24d-4f44-a226-e2116fcd544f chunk uuid dc482988-6246-46ce-9329-68bcf6d3683c For the above example, csum root leaf comes into system block group which is wrong,csum root leaf should be in metadata block group. Signed-off-by: Wang Shilong <wangsl-fnst@cn.fujitsu.com> Reviewed-by: Miao Xie <miaox@cn.fujitsu.com> --- mkfs.c | 71 ++++++++++++++++++++++++++++++++++++++++++------------------------ 1 file changed, 45 insertions(+), 26 deletions(-) diff --git a/mkfs.c b/mkfs.c index 7ff60e5..9cd93e4 100644 --- a/mkfs.c +++ b...

Although for most time, int is enough for subvolid, we should ensure safety in theory. Signed-off-by: Wang Shilong <wangsl.fnst@cn.fujitsu.com> Reviewed-by: Miao Xie <miaox@cn.fujitsu.com> --- fs/btrfs/super.c | 16 +++++++--------- 1 file changed, 7 insertions(+), 9 deletions(-) diff --git a/fs/btrfs/super.c b/fs/btrfs/super.c index cc00295..d82391d 100644 --- a/fs/btrfs/super.c +++ b/fs/btrfs/su...

On 2013/9/1 14:08, Wang Shilong wrote: > Hello, Using checkpatch.pl, i get the following warnings(errors): > ERROR: patch seems to be corrupt (line wrapped?) > #57: FILE: fs/ocfs2/file.c:665: > } else { > > total: 1 errors, 0 warnings, 87 lines checked > > patch has style problems, please review. If a...

mkfs.c: In function ‘is_ssd’: mkfs.c:1168:26: warning: ignoring return value of ‘blkid_devno_to_wholedisk’, declared with attribute warn_unused_result [-Wunused-result] blkid_devno_to_wholedisk(devno, wholedisk, sizeof(wholedisk), NULL); Signed-off-by: Wang Shilong <wangsl.fnst@cn.fujitsu.com> --- mkfs.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/mkfs.c b/mkfs.c index 6d340cb..bcaca43 100644 --- a/mkfs.c +++ b/mkfs.c @@ -1209,6 +1209,7 @@ static int is_ssd(const char *file) dev_t devno; int fd; char rotational; + i...

...toplevel subvol by himself and run receive We''s better use the third approach because first patch will bother kernel change and the second approach is not very good for power users. So give this option to users. Reported-by: Michael Welsh Duggan <mwd@md5i.com> Signed-off-by: Wang Shilong <wangsl.fnst@cn.fujitsu.com> Signed-off-by: Miao Xie <miaox@cn.fujitsu.com> --- Changelog: v1->v2: addressed david''s comments and use the third approach to fix the problem --- cmds-receive.c | 11 +++++++++-- man/btrfs.8.in | 15 ++++++++++----- 2 files changed, 19 inserti...

...ock generation mismatch problems. The fact is that we are trying to check whether we have started a scrub operation in userspace, this will make us can''t start scrub if that record file is damaged itself. By adding a option to skip that check, everything will be fine. Signed-off-by: Wang Shilong <wangsl.fnst@cn.fujitsu.com> --- cmds-scrub.c | 12 +++++++++--- man/btrfs.8.in | 5 ++++- 2 files changed, 13 insertions(+), 4 deletions(-) diff --git a/cmds-scrub.c b/cmds-scrub.c index 605af45..9f614bc 100644 --- a/cmds-scrub.c +++ b/cmds-scrub.c @@ -1096,9 +1096,10 @@ static int scru...

This fixes bugzilla 57491. If we take a snapshot of a fs with a unlink ongoing and then try to send that root we will run into problems. When comparing with a parent root we will search the parents and the send roots commit_root, which if we''ve just created the snapshot will include the file that needs to be evicted by the orphan cleanup. So when we find a changed extent we will try

Memory leaks found by the tool--valgrind along with static reviewing. Based on Daivd''s branch ''integration-20130903''. Gui Hecheng (5): btrfs-progs:free local variable buf upon unsuccessful returns btrfs-progs:local variable memory freed btrfs-progs: missing tree-freeing statements added btrfs-progs:free the local list pending_list in btrfs_scan_one_dir

The kernel side for rescan, which is needed if you want to enable qgroup tracking on a non-empty volume. The first patch splits btrfs_qgroup_account_ref into readable ans reusable units. The second patch adds the rescan implementation (refer to its commit message for a description of the algorithm). The third patch starts an automatic rescan when qgroups are enabled. It is only separated to

First two patches are trivial cleanups that I''ve spotted while reading send.c, can be applied independently. The third patch contains the important bits, safety checks that the subvolumes involved in send do not accidentally lose the RO status. I haven''t seen this documented anywhere that this is mandatory, implied from how I assume send works. Please let me know if this is

Hi Linus, My for-linus branch has a one line fix: git://git.kernel.org/pub/scm/linux/kernel/git/mason/linux-btrfs.git for-linus Sage hit a deadlock with ceph on btrfs, and Josef tracked it down to a regression in our initial rc1 pull. When doing nocow writes we were sometimes starting a transaction with locks held. Josef Bacik (1) commits (+1/-0): Btrfs: release path before starting

...n <mcuos.com@gmail.com> WANG Cong <amwang@redhat.com> WANG Cong <xiyou.wangcong@gmail. WANG Cong <xiyou.wangcong@gmail.com> Wang Dongsheng <Dongsheng.Wang@freescale.com> Wang Sen <senwang@linux.vnet.ibm.com> Wang Sheng-Hui <shhuiw@gmail.com> Wang Shilong <wangsl-fnst@cn.fujitsu.com> Wang Tianhong <wangthbj@linux.vnet.ibm.com> Wang Xingchao <xingchao.wang@intel.com> Wang Xingchao <xingchao.wang@linux.intel.com> Wang YanQing <udknight@gmail.com> Wanlong Gao <gaowanlong@cn.fujitsu.com> Wanlong Gao <wa...