search for: shared_ldflag

...> On 3/21/20 7:06 AM, Richard W.M. Jones wrote: > >Eric: > > > >Yifan Gu has posted a few patches for mingw support. My comments > >below. > > > >https://github.com/gyf304/nbdkit/commit/a37c4ca6546dfc4e96e305af97b62e5a9d6174ca > > > >* I think the SHARED_LDFLAGS idea is good. I pushed a slightly > > different take on the idea here: > > https://github.com/libguestfs/nbdkit/commit/1d634009ab8e43592065ec469df6312400525cc8 > > It's slightly different from what Yifan posted above, because I > > replaced -module -avoid-versi...

This creates libnbdkit.so as discussed in the following thread: https://www.redhat.com/archives/libguestfs/2020-March/thread.html#00203 test-delay-shutdown.sh fails for unclear reasons. This series starts by reverting "tests: Don't strand hung nbdkit processes" which is because several other tests fail randomly unless I revert this patch. I didn't investigate this yet so it

Eric: Yifan Gu has posted a few patches for mingw support. My comments below. https://github.com/gyf304/nbdkit/commit/a37c4ca6546dfc4e96e305af97b62e5a9d6174ca * I think the SHARED_LDFLAGS idea is good. I pushed a slightly different take on the idea here: https://github.com/libguestfs/nbdkit/commit/1d634009ab8e43592065ec469df6312400525cc8 It's slightly different from what Yifan posted above, because I replaced -module -avoid-version -shared with $(SHARED_LDFLAGS), add...

On 3/21/20 7:06 AM, Richard W.M. Jones wrote: > Eric: > > Yifan Gu has posted a few patches for mingw support. My comments > below. > > https://github.com/gyf304/nbdkit/commit/a37c4ca6546dfc4e96e305af97b62e5a9d6174ca > > * I think the SHARED_LDFLAGS idea is good. I pushed a slightly > different take on the idea here: > https://github.com/libguestfs/nbdkit/commit/1d634009ab8e43592065ec469df6312400525cc8 > It's slightly different from what Yifan posted above, because I > replaced -module -avoid-version -shared with...

...ard W.M. Jones wrote: >>> Eric: >>> >>> Yifan Gu has posted a few patches for mingw support. My comments >>> below. >>> >>> https://github.com/gyf304/nbdkit/commit/a37c4ca6546dfc4e96e305af97b62e5a9d6174ca >>> >>> * I think the SHARED_LDFLAGS idea is good. I pushed a slightly >>> different take on the idea here: >>> https://github.com/libguestfs/nbdkit/commit/1d634009ab8e43592065ec469df6312400525cc8 >>> It's slightly different from what Yifan posted above, because I >>> replaced -mod...

...55bbe70d056. --- configure.ac | 9 --------- tests/Makefile.am | 6 +----- 2 files changed, 1 insertion(+), 14 deletions(-) diff --git a/configure.ac b/configure.ac index 0a0ac60a..92e0d4e3 100644 --- a/configure.ac +++ b/configure.ac @@ -412,15 +412,6 @@ AS_CASE([$host_os], AC_MSG_RESULT([$SHARED_LDFLAGS]) AC_SUBST([SHARED_LDFLAGS]) -AC_MSG_CHECKING([if we are on a windows platform]) -AS_CASE([$host_os], - [mingw*|msys*|cygwin*], [is_windows=yes], - [is_windows=no] -) -AC_MSG_RESULT([$is_windows]) -AM_CONDITIONAL([WINDOWS], - [test "x$is_windows" = "xyes"]) -...

...n Fri, May 01, 2020 at 09:16:14PM +0200, François Revol wrote: > >> +nbdkit_ddrescue_filter_la_LDFLAGS = \ > >> + -module -avoid-version -shared \ > >> + -Wl,--version-script=$(top_srcdir)/filters/filters.syms \ > >> + $(NULL) > > > > Still lacking $(SHARED_LDFLAGS) here? > > > > The rest seems fine (but see Eric's suggestion about the documentation). > > > > We'll have to hold this one until 1.20 has been released, should > > be soon. > > I see 1.20 is out, I'll send a v3, hopefully it can be merged now. &g...

...> >>> > >>> Yifan Gu has posted a few patches for mingw support. My comments > >>> below. > >>> > >>> > https://github.com/gyf304/nbdkit/commit/a37c4ca6546dfc4e96e305af97b62e5a9d6174ca > >>> > >>> * I think the SHARED_LDFLAGS idea is good. I pushed a slightly > >>> different take on the idea here: > >>> > https://github.com/libguestfs/nbdkit/commit/1d634009ab8e43592065ec469df6312400525cc8 > >>> It's slightly different from what Yifan posted above, because I > >&gt...

...>Eric: > >>> > >>>Yifan Gu has posted a few patches for mingw support. My comments > >>>below. > >>> > >>>https://github.com/gyf304/nbdkit/commit/a37c4ca6546dfc4e96e305af97b62e5a9d6174ca > >>> > >>>* I think the SHARED_LDFLAGS idea is good. I pushed a slightly > >>> different take on the idea here: > >>> https://github.com/libguestfs/nbdkit/commit/1d634009ab8e43592065ec469df6312400525cc8 > >>> It's slightly different from what Yifan posted above, because I > >>>...

The patches following do indeed allow you to compile nbdkit.exe, but it does not actually work yet. I'm posting this experimental series more as a work in progress and to get feedback. Note this does not require Windows itself to build or test. You can cross-compile it using mingw64-* packages on Fedora or Debian, and test it [spoiler alert: it fails] using Wine. Rich.

...isted. > +TESTS += \ > + test-undefined.sh \ > + $(NULL) > > +# For use of the -rpath option, see: > +# https://lists.gnu.org/archive/html/libtool/2007-07/msg00067.html > +test_undefined_plugin_la_LDFLAGS = \ > + -module -avoid-version -shared \ > + -undefined \ > + $(SHARED_LDFLAGS) \ > + -rpath /nowhere \ > + $(NULL) The most important part here is that we did NOT pass in libnbdkit.so on the link line, but it still builds, resulting in a plugin with undefined symbols which can still be loaded by the just-built nbdkit. > +++ b/tests/test-undefined-plugin.c >...

This allows to overlay bad sectors according to the mapfile generated by ddrescue, to then see where sectors are used using fsck and trying to copy files around. Signed-off-by: Fran?ois Revol <revol at free.fr> --- configure.ac | 2 + filters/ddrescue/Makefile.am | 75 +++++++ filters/ddrescue/ddrescue.c | 211

From: Alan Somers <asomers@gmail.com> There was a missing #include. It only worked on Linux due to header pollution. --- plugins/ssh/ssh.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/plugins/ssh/ssh.c b/plugins/ssh/ssh.c index ea199a93..a4007c40 100644 --- a/plugins/ssh/ssh.c +++ b/plugins/ssh/ssh.c @@ -30,6 +30,8 @@ * SUCH DAMAGE. */ +#include <sys/stat.h> +

What risk exists in changing the check for the matching version of openssl so that the final letter part of the version (e.g. 0.9.6c vs. 0.9.6d) is ignored? Are there any security vulnerabilities in such a thing? What if ssh(d) is linked against an older _letter_ version such as 0.9.6c and now finds the library is 0.9.6d? Is there a security risk in that? Surely a major API change would not

...FLAGS = \ + -I$(top_srcdir)/include \ + $(NULL) +test_undefined_plugin_la_CFLAGS = $(WARNINGS_CFLAGS) +# For use of the -rpath option, see: +# https://lists.gnu.org/archive/html/libtool/2007-07/msg00067.html +test_undefined_plugin_la_LDFLAGS = \ + -module -avoid-version -shared \ + -undefined \ + $(SHARED_LDFLAGS) \ + -rpath /nowhere \ + $(NULL) + if CAN_TEST_ANSI_C # This builds a plugin using an ANSI (ISO C90) compiler to ensure that # the header file is compatible. The plugin does nothing very diff --git a/tests/test-undefined.sh b/tests/test-undefined.sh new file mode 100755 index 00000000..db6c8eb...

...filter_la_SOURCES = \ nbdkit_blocksize_filter_la_CPPFLAGS = \ -I$(top_srcdir)/include \ -I$(top_srcdir)/common/include \ + -I$(top_srcdir)/common/utils \ $(NULL) nbdkit_blocksize_filter_la_CFLAGS = $(WARNINGS_CFLAGS) nbdkit_blocksize_filter_la_LDFLAGS = \ -module -avoid-version -shared $(SHARED_LDFLAGS) \ -Wl,--version-script=$(top_srcdir)/filters/filters.syms \ $(NULL) +nbdkit_blocksize_filter_la_LIBADD = \ + $(top_builddir)/common/utils/libutils.la \ + $(NULL) if HAVE_POD diff --git a/tests/Makefile.am b/tests/Makefile.am index 481291e6..c0c7e981 100644 --- a/tests/Makefile.am +++ b/tes...

...c \ + $(top_srcdir)/include/nbdkit-filter.h \ + $(NULL) + +nbdkit_tlsdummy_filter_la_CPPFLAGS = \ + -I$(top_srcdir)/include \ + -I$(top_srcdir)/common/include \ + $(NULL) +nbdkit_tlsdummy_filter_la_CFLAGS = $(WARNINGS_CFLAGS) +nbdkit_tlsdummy_filter_la_LDFLAGS = \ + -module -avoid-version -shared $(SHARED_LDFLAGS) \ + -Wl,--version-script=$(top_srcdir)/filters/filters.syms \ + $(NULL) + +if HAVE_POD + +man_MANS = nbdkit-tlsdummy-filter.1 +CLEANFILES += $(man_MANS) + +nbdkit-tlsdummy-filter.1: nbdkit-tlsdummy-filter.pod + $(PODWRAPPER) --section=1 --man $@ \ + --html $(top_builddir)/html/$@.html \ +...

...gin.h \ + $(NULL) +test_stdio_plugin_la_CPPFLAGS = -I$(top_srcdir)/include +test_stdio_plugin_la_CFLAGS = $(WARNINGS_CFLAGS) +# For use of the -rpath option, see: +# https://lists.gnu.org/archive/html/libtool/2007-07/msg00067.html +test_stdio_plugin_la_LDFLAGS = \ + -module -avoid-version -shared $(SHARED_LDFLAGS) -rpath /nowhere \ + $(NULL) + # check_LTLIBRARIES won't build a shared library (see automake manual). # So we have to do this and add a dependency. noinst_LTLIBRARIES += \ diff --git a/tests/test-single-sh.sh b/tests/test-single-sh.sh new file mode 100755 index 00000000..a1586868 --- /dev/...

This allows to overlay bad sectors according to the mapfile generated by ddrescue, to then see where sectors are used using fsck and trying to copy files around. Signed-off-by: Fran?ois Revol <revol at free.fr> --- configure.ac | 2 + filters/ddrescue/Makefile.am | 75 +++++++ filters/ddrescue/ddrescue.c | 218

...top_srcdir)/include \ + -I$(top_srcdir)/common/include \ + -I$(top_srcdir)/common/sparse \ + -I$(top_srcdir)/common/utils \ + $(NULL) +nbdkit_ddrescue_filter_la_CFLAGS = \ + $(WARNINGS_CFLAGS) \ + $(GNUTLS_CFLAGS) \ + $(NULL) +nbdkit_ddrescue_filter_la_LDFLAGS = \ + -module -avoid-version -shared $(SHARED_LDFLAGS) \ + -Wl,--version-script=$(top_srcdir)/filters/filters.syms \ + $(NULL) +nbdkit_ddrescue_filter_la_LIBADD = \ + $(top_builddir)/common/sparse/libsparse.la \ + $(top_builddir)/common/utils/libutils.la \ + $(GNUTLS_LIBS) \ + $(NULL) + +if HAVE_POD + +man_MANS = nbdkit-ddrescue-filter.1 +CLEANFILES...