search for: sgtm

....com>> wrote: > Apple doesn’t ship CMake publicly. Our internal build clusters should all be running 2.8.12.2 or later. > > Any OS X users not on CMake 2.8.12.2 can always download install packages from CMake.org <http://cmake.org/>. > > OK, so its analogous to Windows. SGTM. (and no, I don't think you need to wait for further review of patches) -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20150209/e7f96368/attachment.html>

...seful... >>>> >>>> -Chris >>> >>> If we agreed to perform this change and we found the person who can change >>> it, we can probably give a heads-up a couple of days before to see if >>> anybody will have major issues. >> >> SGTM - thanks for the recap/quotation. (but, yes, I'm not the person >> who can change that - hopefully Tanya or one of the other admins will >> speak up with details) > > > Yes, I can remove the list name. I'll confirm with Chris and I can send email to the lists before i...

...doesn’t ship CMake publicly. Our internal build clusters should all >>> be running 2.8.12.2 or later. >>> >>> Any OS X users not on CMake 2.8.12.2 can always download install packages >>> from CMake.org. >> >> >> OK, so its analogous to Windows. SGTM. (and no, I don't think you need to >> wait for further review of patches) >> >> >> >> _______________________________________________ >> LLVM Developers mailing list >> LLVMdev at cs.uiuc.edu http://llvm.cs.uiuc.edu >> http://lists.cs.uiu...

...metadata attachments for global variables in > the same way as we did for functions. > > > > Syntax would be pretty simple: > > @foo = global i32 0, !foo !0, !bar !1 > > (the extra commas are required to disambiguate from a named metadata on > the next line) > > SGTM. > > > Benefits: > > 1) Lets us reverse the DIGlobalVariable -> GlobalVariable edge, which > should hopefully clear the way for removing the llvm.dbg.cu named > metadata node. > > A little harder than it sounds (need to somehow support a GlobalVariable > that is RAU...

...ame way as we did for functions. >>> > >>> > Syntax would be pretty simple: >>> > @foo = global i32 0, !foo !0, !bar !1 >>> > (the extra commas are required to disambiguate from a named metadata >>> on the next line) >>> >>> SGTM. >>> >>> > Benefits: >>> > 1) Lets us reverse the DIGlobalVariable -> GlobalVariable edge, which >>> should hopefully clear the way for removing the llvm.dbg.cu named >>> metadata node. >>> >>> A little harder than it sounds (n...

...>>>>> -Chris >>>> >>>> If we agreed to perform this change and we found the person who can change >>>> it, we can probably give a heads-up a couple of days before to see if >>>> anybody will have major issues. >>> >>> SGTM - thanks for the recap/quotation. (but, yes, I'm not the person >>> who can change that - hopefully Tanya or one of the other admins will >>> speak up with details) >> >> >> Yes, I can remove the list name. I'll confirm with Chris and I can send email to...

...e been long wanting to do something decent there), then > we'd need to add a proper update procedure. > > I'm fine with some checkout if it's a stable release, not trunk, as it > would make things a lot easier to update later (patch releases, new > releases, etc). > SGTM. > > >> Thanks -- this doesn't tell me how to run the test though... I could certainly do it by hand (i.e. build the executables and run it) and I suspect I'm not alone in wanting to be able to do this easily through the CMake+Ninja (or other generator) workflow. > > A...

Sanjoy Das <sanjoy at playingwithpointers.com> writes: > Hi Justin, > > This SGTM generally, but please make the difference between > LLVM_NODISCARD and LLVM_UNUSED_RESULT clear in the code. :) Right, this is where it gets a little weird. LLVM_NODISCARD would be for types, whereas LLVM_UNUSED_RESULT would be for functions. Depending on your host compiler, using the wrong one...

...> >>>> be running 2.8.12.2 or later. > >>>> > >>>> Any OS X users not on CMake 2.8.12.2 can always download install > packages > >>>> from CMake.org. > >>> > >>> > >>> OK, so its analogous to Windows. SGTM. (and no, I don't think you need > to > >>> wait for further review of patches) > >>> > >>> > >>> > >>> _______________________________________________ > >>> LLVM Developers mailing list > >>> LLVMdev at cs.u...

...later. >> >>>> >> >>>> Any OS X users not on CMake 2.8.12.2 can always download install packages >> >>>> from CMake.org <http://cmake.org/>. >> >>> >> >>> >> >>> OK, so its analogous to Windows. SGTM. (and no, I don't think you need to >> >>> wait for further review of patches) >> >>> >> >>> >> >>> >> >>> _______________________________________________ >> >>> LLVM Developers mailing list >> >&...

Apple doesn’t ship CMake publicly. Our internal build clusters should all be running 2.8.12.2 or later. Any OS X users not on CMake 2.8.12.2 can always download install packages from CMake.org <http://cmake.org/>. -Chris > On Feb 9, 2015, at 11:46 AM, Chandler Carruth <chandlerc at google.com> wrote: > > > On Mon, Feb 9, 2015 at 11:43 AM, Chris Bieneman <beanz at

Hi folks, We would like to add SeaHorn <http://seahorn.github.io/> and Crab-llvm <https://github.com/seahorn/crab-llvm> to the list of LLVM's users on http://llvm.org/Users.html under Open Source Projects. The descriptions would be: 1. SeaHorn | An Algorithmic Logic-Based Reasoning Framework. 2. Crab-llvm | A static analyzer based on abstract interpretation for LLVM. I attach a

...me. I was myself thinking of a number of FAQs: > > 1. A General FAQ with high level questions like "What is the license?", > "What is LLVM?", and "What is Clang?" Something that lifts the newcomer up > to a fairly knowledgable state in a short time. > SGTM. > 2. An LLVM User FAQ that only deals with LLVM usage questions. > 3. An LLVM Dev FAQ that only deals with LLVM development questions. > 4. A Clang User FAQ that only deals with Clang usage questions. > 5. A Clang Dev FAQ that only deals with Clang development questions. > 6. A yo...

I’m nominating Matthias Braun as the Instruction Scheduling code owner (in place of myself). Matthias has made substantial contributions to the scheduler, particularly for subregister support, and has been reviewing patches in that area. I think target maintainers will be happy to have Matthias officially take over the role. -Andy

...of LLD and Rui owns LLD+COFF+ELF, I can't see why >> we shouldn't put Lang as LLD+Darwin and let the hierarchical chain >> mean the rest. > > Please just add a CODE_OWNERS.TXT file to the root of the lld repo, copying the formatting from the llvm or clang one. Thanks! SGTM. Some sub-projects have been piggy-backing on the LLVM file. Makes sense to split them into their own thing in the relevant projects themselves, especially when it’s multiple people, though, you’re right. Nick, can you take care of that? -------------- next part -------------- An HTML attachment w...

As I've left Sony, I should handoff code ownership of the PS4 triple. Sony is still committed to LLVM and I look forward to continue to work with them in open source. Sony has asked that I nominate Paul Robinson to become code owner. +------------------------------------------------------------+ | Alexander M. Rosenberg <mailto:alexr at leftfield.org> | | Nobody cares what I

The GEP constructor does not assert that the source and destination types match. Of course, this is incorrect and causes random failures somewhere down the line. Could I add general sanity checks to the GEP constructor? In general, is an Instruction allowed to be in an inconsistent state? If so, is there some well known method to "verify" whether an instruction is consistent or not?

Hi @ll, I would like to obsolete and completely remove the WebKit Calling Convention. The CC was originally added for FTL and there are no other users I am aware off. Since WebKit moved away from LLVM a while ago I don’t see the need to keep the dead code around anymore. Please let me know if anyone happens to use this calling convention or has any objection with removing it. Thanks Cheers,

On Thu, Mar 19, 2015 at 01:43:25PM -0700, Duncan P. N. Exon Smith wrote: > This SGTM in principle. The specific set of passes that you've enabled at > -O1 seems strangely small to me, but we can adjust that later. Sure. (It seemed best to me for this set to be small, at least for now, because LTO is single-threaded, unlike regular optimization in a parallelized build syste...

...t; we'd need to add a proper update procedure. >>> >>> I'm fine with some checkout if it's a stable release, not trunk, as it >>> would make things a lot easier to update later (patch releases, new >>> releases, etc). >>> >> >> SGTM. >> > > Is there a preference on where to place the library? I had a look at {SingleSource/MultiSource}/Benchmarks/ and I didn't find a common location for libraries used. I'm tempted to create a top-level "libs" directory that will host common libraries but I'm...