search for: setup_myself

...opped sending updates. Debugging session revealed that lookup_config(config_tree, NAME) returned NULL when NAME was any configuration item from our host file _after_ SIGHUP. Before it, it returned valid value. I see config_tree is appended with variables from node's own host file only once, in setup_myself(). After config reload, config_tree is deleted and created again, but no reading of host file variables occur since then. It not only failed with my own newly introduced variables, but with every host file specific variable, for example, "Compression". I then fixed it with attached patc...

--- doc/tinc.conf.5.in | 3 +++ src/linux/device.c | 7 +++++++ 2 files changed, 10 insertions(+), 0 deletions(-) diff --git a/doc/tinc.conf.5.in b/doc/tinc.conf.5.in index 2bfd5fe..01f7f81 100644 --- a/doc/tinc.conf.5.in +++ b/doc/tinc.conf.5.in @@ -255,6 +255,9 @@ a lookup if your DNS server is not responding. This does not affect resolving hostnames to IP addresses from the host

...subnet=0x0) at subnet.c:250 250 switch (subnet->type) { (gdb) bt #0 0x0805667c in net2str (netstr=0xbffff8a0 "SUBNET=", len=71, subnet=0x0) at subnet.c:250 #1 0x08056b35 in subnet_update (owner=0x80d3c48, subnet=0x0, up=true) at subnet.c:427 #2 0x0804f067 in setup_myself () at net_setup.c:467 #3 0x0804f528 in setup_network_connections () at net_setup.c:546 #4 0x080576a9 in main (argc=5, argv=0xbffffa44) at tincd.c:488 subnet_update is something which got added to net_setup.c between version 1.0.3 and now. Hope this helps in fixing this issue. If you need more i...

...from /lib/tls/i686/cmov/libc.so.6 (gdb) bt #0 0xb7d30463 in strlen () from /lib/tls/i686/cmov/libc.so.6 #1 0xb7d30175 in strdup () from /lib/tls/i686/cmov/libc.so.6 #2 0x0805bf47 in xstrdup (s=0x0) at xmalloc.c:118 <--- #3 0x0805be33 in setup_device () at device.c:66 #4 0x0805072e in setup_myself () at net_setup.c:432 #5 0x08050db2 in setup_network () at net_setup.c:536 #6 0x0805b27f in main (argc=Cannot access memory at address 0x0) at tincd.c:580 This patch fixes this by checking `netname' in `setup_device'. An alternative would be to check for NULL-pointers in `xstrdup'...