search for: setthreadlocalmod

...ic, and on Darwin is whatever Darwin does, etc.". > I was not sure how hard the first item would be, so I just gave it a > try. The resulting patch is attached. Your patch preserves the current constructors. Is the idea that we wouldn't change the constructors, and clang would call setThreadLocalMode() when it creates global variables? I would feel better if we changed the constructors, to avoid the risk of forgetting to do stuff like NewGV->setThreadLocalMode(OldGV->getThreadLocalMode()) when new variables are created based on old ones. Thanks, Hans

> Attaching a new patch that has the behaviour we discussed. > > The "globaldynamic" and default values have been merged, and LLVM will > start off with the user-specified model, but choose a more specific > one if possible. > > Please review. Awesome, thanks! I will try to do a more complete review tonight or tomorrow. For now, just two quick observations *) This

...ent I think. I am ok with 4 llvm specific names or using the 4 names used by the tlf.pdf document. Just make sure none of them is named 'default' :-) > Your patch preserves the current constructors. Is the idea that we > wouldn't change the constructors, and clang would call > setThreadLocalMode() when it creates global variables? I would feel > better if we changed the constructors, to avoid the risk of forgetting > to do stuff like No, this was just a hack to get clang to build. I would suggest changing the constructor just like your patch does, but keeping the existing ones just...

On Tue, Apr 4, 2017 at 12:36 PM, Duncan P. N. Exon Smith < dexonsmith at apple.com> wrote: > > On 2017-Apr-04, at 12:12, Peter Collingbourne <peter at pcc.me.uk> wrote: > > On Mon, Apr 3, 2017 at 8:13 PM, Mehdi Amini <mehdi.amini at apple.com> wrote: > >> >> On Apr 3, 2017, at 7:08 PM, Peter Collingbourne <peter at pcc.me.uk> wrote: >>