Displaying 10 results from an estimated 10 matches for "setpromotedinteg".
Did you mean:
setpromotedinteger
2018 Mar 13
2
[SelectionDAG] DbgValue nodes aren't transferred
Thanks for help! I think that sign extension is not involved here. PromoteIntegerResult is called since i32 is not a legal type in my target and the legalizer promotes operations with i32 result type to i64 operations. I think that SetPromotedInteger seems to be a common place for all promotions like SetExpandedInteger.
Jonas, I would appreciate it if you can guide me about whether my understanding is correct or not.
Thanks,
Sejong
From: vsk at apple.com <vsk at apple.com>
Sent: Friday, March 9, 2018 3:19 PM
To: Se Jong Oh <sejo...
2018 Mar 14
2
[SelectionDAG] DbgValue nodes aren't transferred
Hi Jonas,
Thanks for taking a look! It makes linear-dbg-value.ll pass for my target by producing DEBUG_VALUEs correctly. I also tried a simple function with few operations and confirmed DEBUG_VALUEs which are not produced without trasferDbgValues in SetPromotedInteger.
Thanks,
Sejong
From: jdevlieghere at apple.com <jdevlieghere at apple.com>
Sent: Wednesday, March 14, 2018 4:07 AM
To: Se Jong Oh <sejooh at microsoft.com>
Cc: Vedant Kumar <vsk at apple.com>; llvm-dev at lists.llvm.org; Adrian Prantl <aprantl at apple.com>; pidgeot18 a...
2018 Mar 14
0
[SelectionDAG] DbgValue nodes aren't transferred
Hi Sejong,
Indeed, I think you are right and we should call transferDbgValues in SetPromotedInteger.
I couldn’t immediately find a suitable in-tree test to verify this though. Can you check and let me know whether this works for your target?
Thanks,
Jonas
> On Mar 13, 2018, at 7:45 PM, Se Jong Oh <sejooh at microsoft.com> wrote:
>
> Thanks for help! I think that sign extensio...
2018 Mar 15
1
[SelectionDAG] DbgValue nodes aren't transferred
...t microsoft.com> wrote:
>
> Hi Jonas,
>
> Thanks for taking a look! It makes linear-dbg-value.ll pass for my target by producing DEBUG_VALUEs correctly. I also tried a simple function with few operations and confirmed DEBUG_VALUEs which are not produced without trasferDbgValues in SetPromotedInteger.
That’s great news! Do you plan on creating a patch for this upstream?
>
> Thanks,
> Sejong
>
> From: jdevlieghere at apple.com <jdevlieghere at apple.com>
> Sent: Wednesday, March 14, 2018 4:07 AM
> To: Se Jong Oh <sejooh at microsoft.com>
> Cc: Vedant...
2018 Apr 30
0
[SelectionDAG] DbgValue nodes aren't transferred
...t microsoft.com> wrote:
>
> Hi Jonas,
>
> Thanks for taking a look! It makes linear-dbg-value.ll pass for my target by producing DEBUG_VALUEs correctly. I also tried a simple function with few operations and confirmed DEBUG_VALUEs which are not produced without trasferDbgValues in SetPromotedInteger.
That’s great news! Do you plan on creating a patch for this upstream?
>
> Thanks,
> Sejong
>
> From: jdevlieghere at apple.com <jdevlieghere at apple.com>
> Sent: Wednesday, March 14, 2018 4:07 AM
> To: Se Jong Oh <sejooh at microsoft.com>
> Cc: Vedant...
2018 Mar 09
2
[SelectionDAG] DbgValue nodes aren't transferred
...nsw t5, t8 --> t31: i64 = add t30, t7 ; the dbg_value node is not transferred to the new i64 add node.
For expansion, DAGTypeLegalizer::SetExpandedInteger calls transferDbgValues() but I couldn't find any place to call trasnferDbgValues() for integer type promotion in DAGTypeLegalizer ::SetPromotedInteger and other places. I am wondering If I miss anything or the legalization needs to call transferDbgValues() for this case.
I found this problem because a recently added unittest, DebugInfo/X86/linear-dbg-value.ll fails for my project, and the x86 and aarch64 backends don't have this problem si...
2018 Apr 30
2
[SelectionDAG] DbgValue nodes aren't transferred
...> wrote:
>>
>> Hi Jonas,
>>
>> Thanks for taking a look! It makes linear-dbg-value.ll pass for my target by producing DEBUG_VALUEs correctly. I also tried a simple function with few operations and confirmed DEBUG_VALUEs which are not produced without trasferDbgValues in SetPromotedInteger.
>
> That’s great news! Do you plan on creating a patch for this upstream?
>
>>
>> Thanks,
>> Sejong
>>
>> From: jdevlieghere at apple.com <jdevlieghere at apple.com>
>> Sent: Wednesday, March 14, 2018 4:07 AM
>> To: Se Jong Oh <se...
2018 Mar 09
0
[SelectionDAG] DbgValue nodes aren't transferred
...sw t5, t8 à t31: i64 = add t30, t7 ; the dbg_value node is not transferred to the new i64 add node.
>
> For expansion, DAGTypeLegalizer::SetExpandedInteger calls transferDbgValues() but I couldn’t find any place to call trasnferDbgValues() for integer type promotion in DAGTypeLegalizer ::SetPromotedInteger and other places.
Maybe the right place to do this is within the PromoteIntRes_ helper for sign extensions?
best,
vedant
> I am wondering If I miss anything or the legalization needs to call transferDbgValues() for this case.
>
> I found this problem because a recently added unittes...
2018 Apr 30
0
[SelectionDAG] DbgValue nodes aren't transferred
...t;mailto:sejooh at microsoft.com>> wrote:
Hi Jonas,
Thanks for taking a look! It makes linear-dbg-value.ll pass for my target by producing DEBUG_VALUEs correctly. I also tried a simple function with few operations and confirmed DEBUG_VALUEs which are not produced without trasferDbgValues in SetPromotedInteger.
That’s great news! Do you plan on creating a patch for this upstream?
Thanks,
Sejong
From: jdevlieghere at apple.com<mailto:jdevlieghere at apple.com> <jdevlieghere at apple.com<mailto:jdevlieghere at apple.com>>
Sent: Wednesday, March 14, 2018 4:07 AM
To: Se Jong Oh <s...
2018 Mar 09
0
[SelectionDAG] DbgValue nodes aren't transferred
...nsw t5, t8 --> t31: i64 = add t30, t7 ; the dbg_value node is not transferred to the new i64 add node.
For expansion, DAGTypeLegalizer::SetExpandedInteger calls transferDbgValues() but I couldn't find any place to call trasnferDbgValues() for integer type promotion in DAGTypeLegalizer ::SetPromotedInteger and other places. I am wondering If I miss anything or the legalization needs to call transferDbgValues() for this case.
I found this problem because a recently added unittest, DebugInfo/Generic/linear-dbg-value.ll fails for my project, and the x86 and aarch64 backends don't have this proble...