search for: setbuffersize

...ttings from this raw_ostream back to the underlying stream. > > > + if (!TheStream) > > > + return; > > > + if (DeleteStream) > > > + delete TheStream; > > > + else if (BufferSize > 0) > > > + TheStream->SetBufferSize(BufferSize); > > > + else > > > + TheStream->SetUnbuffered(); > > Another issue is that this is transfering the circular stream's > > buffer to the underlying stream. Would it make more sense and would it > > be worth it to save the underlying...

...ack to the underlying > > > > stream. + if (!TheStream) > > > > + return; > > > > + if (DeleteStream) > > > > + delete TheStream; > > > > + else if (BufferSize > 0) > > > > + TheStream->SetBufferSize(BufferSize); > > > > + else > > > > + TheStream->SetUnbuffered(); > > > > > > Another issue is that this is transfering the circular stream's > > > buffer to the underlying stream. Would it make more sense and would it > >...

...buffer > > + // settings from this raw_ostream back to the underlying stream. > > + if (!TheStream) > > + return; > > + if (DeleteStream) > > + delete TheStream; > > + else if (BufferSize > 0) > > + TheStream->SetBufferSize(BufferSize); > > + else > > + TheStream->SetUnbuffered(); > > Again, I don't think an unbuffered circular stream makes a lot of sense > here. See above. :) > Another issue is that this is transfering the circular stream's > buffer to the underl...

...> underlying stream. + if (!TheStream) > > > > > + return; > > > > > + if (DeleteStream) > > > > > + delete TheStream; > > > > > + else if (BufferSize > 0) > > > > > + TheStream->SetBufferSize(BufferSize); > > > > > + else > > > > > + TheStream->SetUnbuffered(); > > > > > > > > Another issue is that this is transfering the circular stream's > > > > buffer to the underlying stream. Would it make more sen...

...eam() { + // Delete the stream if needed. Otherwise, transfer the buffer + // settings from this raw_ostream back to the underlying stream. + if (!TheStream) + return; + if (DeleteStream) + delete TheStream; + else if (BufferSize > 0) + TheStream->SetBufferSize(BufferSize); + else + TheStream->SetUnbuffered(); + } + }; +} // end llvm namespace + + +#endif Index: lib/Support/circular_raw_ostream.cpp =================================================================== --- lib/Support/circular_raw_ostream.cpp (revision 0) +++ lib/Support/ci...

...if needed. Otherwise, transfer the buffer > + // settings from this raw_ostream back to the underlying stream. > + if (!TheStream) > + return; > + if (DeleteStream) > + delete TheStream; > + else if (BufferSize > 0) > + TheStream->SetBufferSize(BufferSize); > + else > + TheStream->SetUnbuffered(); Again, I don't think an unbuffered circular stream makes a lot of sense here. Another issue is that this is transfering the circular stream's buffer to the underlying stream. Would it make more sense and would it...

Sean, thanks for reminding this, Alp did commit a class derived from raw_svector_ostream conatining an internal SmallString he called small_string_ostream. The commit was reverted after a day due to a disagreement about the commit approval and apparently abandoned. http://lists.cs.uiuc.edu/pipermail/llvm-commits/Week-of-Mon-20140623/223393.html

On Wednesday 16 December 2009 13:19, Chris Lattner wrote: > + int BufferSize; > + std::vector<char> BufferArray; > + bool DelayOutput; > + std::vector<char>::iterator Cur; > > Please doxygenify these. Ok. > Instead of using a std::vector for BufferArray, please just new[] an array > since it is fixed size. Ok. > Why is BufferSize needed with

...eded. Otherwise, + /// transfer the buffer settings from this circular_raw_ostream + /// back to the underlying stream. + void releaseStream() { + if (!TheStream) + return; + if (OwnsStream) + delete TheStream; + else if (BufferSize != 0) + TheStream->SetBufferSize(BufferSize); + else + TheStream->SetUnbuffered(); + } + }; +} // end llvm namespace + + +#endif Index: lib/Support/circular_raw_ostream.cpp =================================================================== --- lib/Support/circular_raw_ostream.cpp (revision 0) +++ lib/Support/ci...

On Dec 16, 2009, at 8:12 AM, David Greene wrote: >>> >>> What, specifically, do you want reviewed before I start checking in? >>> I'll be happy to prepare a patch that shows just that. >> >> I want a patch that does one thing (e.g. implements dbgs(), > > Ok, let's start with that. Here's the patch to add the circular raw_ostream. This

On Friday 18 December 2009 19:47, Chris Lattner wrote: > On Dec 18, 2009, at 3:46 PM, David Greene wrote: > > + /// circular_raw_ostream - A raw_ostream that saves its output in a > > + /// circular buffer. > > A better description would be "which *can* save its data to a circular > buffer, or can pass it through directly to an underlying stream if > specified

...eam() { + // Delete the stream if needed. Otherwise, transfer the buffer + // settings from this raw_ostream back to the underlying stream. + if (!TheStream) + return; + if (DeleteStream) + delete TheStream; + else if (BufferSize > 0) + TheStream->SetBufferSize(BufferSize); + else + TheStream->SetUnbuffered(); + } + }; +} // end llvm namespace + + +#endif Index: lib/Support/circular_raw_ostream.cpp =================================================================== --- lib/Support/circular_raw_ostream.cpp (revision 0) +++ lib/Support/ci...