search for: set_vc_field

...vorbiscomment.c +++ b/src/metaflac/operations_shorthand_vorbiscomment.c @@ -96,7 +96,11 @@ FLAC__bool do_shorthand_operation__vorbis_comment(const char *filename, FLAC__bo ok = remove_vc_firstfield(filename, block, operation->argument.vc_field_name.value, needs_write); break; case OP__SET_VC_FIELD: +#ifdef _WIN32 /* do not convert anything or things will break */ + ok = set_vc_field(filename, block, &operation->argument.vc_field, needs_write, true); +#else ok = set_vc_field(filename, block, &operation->argument.vc_field, needs_write, raw); +#endif break; case OP__I...

...------------ diff --git a/src/flac/vorbiscomment.c b/src/flac/vorbiscomment.c index ed9f710..0e99267 100644 --- a/src/flac/vorbiscomment.c +++ b/src/flac/vorbiscomment.c @@ -243,7 +243,7 @@ FLAC__bool flac__vorbiscomment_add(FLAC__StreamMetadata *block, const char *comm return false; } - if(!set_vc_field(block, &parsed, &dummy, raw, violation)) { + if(parsed.field_value_length > 0 && !set_vc_field(block, &parsed, &dummy, raw, violation)) { free_field(&parsed); return false; }

This is 1.3.1 on OpenBSD/amd64. The --no-utf8-convert option of metaflac(1) does not work for me: $ metaflac --no-utf8-convert --set-tag="Artist=?ou?l??ek" aladin.flac aladin.flac: ERROR: tag value for 'Artist' is not valid UTF-8 (You probably can't see the Czech letters properly in my mail, but that's beside the point.) Indeed, it is not valid UTF8 (it's LATIN2),

Brian Willoughby wrote: > Jan Stary wrote: >>> This is 1.3.1 on OpenBSD/amd64. >>> The --no-utf8-convert option of metaflac(1) does not work for me: ... >> The problem seems to be in >> src/metaflac/operations_shorthand_vorbiscomment.c >> in the set_vc_field() function. > By the way, I've never used FLAC inside Ogg Vorbis. > Instead, I use pure FLAC format files. Is there any > difference between the way this option works on a > straight FLAC file versus how it works on FLAC data > in an Ogg Vorbis container? Some confusion seems t...

...he point.) > > Indeed, it is not valid UTF8 (it's LATIN2), but isn't metaflac > supposed to just write it as specified, with this option? On Dec 06 09:54:55, hans at stare.cz wrote: > The problem seems to be in > src/metaflac/operations_shorthand_vorbiscomment.c > in the set_vc_field() function. > > It does check whether utf conversion is required, > > /* move 'data' into 'converted', converting to UTF-8 if necessary */ > if(raw) { > converted = data; > } > } > but later checks that FLAC__format_vorbisco...