search for: set_meta_context

The NBD spec says that if a client requests SET_META_CONTEXT for exportA, but later requests NBD_OPT_GO/EXPORT_NAME for exportB, then the server should reject NBD_CMD_BLOCK_STATUS requests (that is, the context returned for exportA need not apply to exportB). When we originally added base:allocation, our argument was that we always ignore export names, so i...

The NBD spec says that if a client requests SET_META_CONTEXT for exportA, but later requests NBD_OPT_GO/EXPORT_NAME for exportB, then the server should reject NBD_CMD_BLOCK_STATUS requests (that is, the context returned for exportA need not apply to exportB). When we originally added base:allocation, our argument was that we always ignore export names, so i...

ACK series, thanks. It seems worth raising the assert failure with Red Hat's Security team since it is a viable DoS attack on nbdkit servers. Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming and virtualization blog: http://rwmj.wordpress.com virt-df lists disk usage of guests without needing to install any software inside the

The first one is the nastiest - it is an assertion failure caused by a spec-compliant client and introduced by our security fix that was released in 1.14.1. Eric Blake (4): server: Fix regression for NBD_OPT_INFO before NBD_OPT_GO server: Fix back-to-back SET_META_CONTEXT server: Forbid NUL in export and context names server: Fix OPT_GO on different export than SET_META_CONTEXT server/internal.h | 5 ++- server/backend.c | 13 ++++++ server/connections.c | 2 +- server/filters.c | 5...

....c1f1672 100644 --- a/sh/nbdsh.pod +++ b/sh/nbdsh.pod @@ -60,8 +60,10 @@ Display brief command line help and exit. Request the use of the "base:allocation" meta context, which is the most common context used with L<nbd_block_status(3)>. This is -equivalent to calling S<C<h.set_meta_context -(nbd.CONTEXT_BASE_ALLOCATION)>> in the shell prior to connecting. +equivalent to calling +S<C<h.set_meta_context(nbd.CONTEXT_BASE_ALLOCATION)>> in the shell +prior to connecting, and works even when combined with C<--uri> (while +attempting the same with C<-c> would b...

...LES_HEXDUMP__ Display brief command line help and exit. +=item B<-b> + +=item B<--base-allocation> + +Request the use of the "base:allocation" meta context, which is the +most common context used with L<nbd_block_status(3)>. This is +equivalent to calling S<C<h.set_meta_context +(nbd.CONTEXT_BASE_ALLOCATION)>> in the shell prior to connecting. + =item B<-c> 'COMMAND ...' =item B<--command> 'COMMAND ...' diff --git a/python/nbdsh.py b/python/nbdsh.py index 319b0f0..00bc6bc 100644 --- a/python/nbdsh.py +++ b/python/nbdsh.py @@ -27,6 +27,...

...involving nbdkit. Eric Blake (7): server: Reject -e with too long of a name server: Expose -e in $exportname during --run server: Switch to fixed-length conn->exportname server: Improve check of string validity server: Allow longer NBD_OPT server: Fix OPT_GO on different export than SET_META_CONTEXT server: Better newstyle .open failure handling docs/nbdkit-captive.pod | 12 ++- server/internal.h | 4 +- server/Makefile.am | 1 + server/captive.c | 22 ++++- server/connections.c | 7 -- server/mai...

...or if we should instead keep it small and add one more indirection where sbuf is malloc'd; I'm not sure that it matters much (outside of libnbd, nbd_handle is an opaque type always referenced as a pointer). Eric Blake (7): states: Log structured error messages, if any states: Refactor SET_META_CONTEXT reply parsing states: Allow large SET_CONTEXT_NAME replies states: Rewrite NBD_REP_INFO parsing states: Factor out NBD_REP payload prep states: Give up on oversized reply length states: Capture NBD_REP_ERR message generator/generator | 19 ++-- generator/states...