search for: set_log_dir

... and a small initial patch which makes it easier to test virt-p2v without having to start up a virtual machine. There is still a bug in Gtk 3 where the GtkTextView on the final (running) dialog ignores gtk_widget_set_size_request and so the window appears just a single pixel high. Rich.

This is basically the same as what I posted earlier today. The main difference is I split out the GDK thread sychronization (removal of) changes from the other Gtk 2/3 changes, which should make it a bit easier to review. Gtk 3 is still not quite perfect. Apart from the problem with the GtkTextView noted before, there are also vertical alignment and padding problems with labels in GtkGrid

I reordered the 'and' clause to make it sound a bit more natural. Thanks: Junqin Zhou. --- p2v/gui.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/p2v/gui.c b/p2v/gui.c index 58310bf..3ef1e77 100644 --- a/p2v/gui.c +++ b/p2v/gui.c @@ -1754,8 +1754,8 @@ set_log_dir (gpointer user_data) CLEANUP_FREE char *msg; if (asprintf (&msg, - _("Log files and debug information " - "is saved to this directory " + _("Debug information and log files " + "are saved...

...this, why? */ gtk_widget_set_size_request (v2v_output, 700, 400); log_label = gtk_label_new (NULL); - gtk_misc_set_alignment (GTK_MISC (log_label), 0., 0.5); - gtk_misc_set_padding (GTK_MISC (log_label), 10, 10); + set_alignment (log_label, 0., 0.5); + set_padding (log_label, 10, 10); set_log_dir (NULL); status_label = gtk_label_new (NULL); - gtk_misc_set_alignment (GTK_MISC (status_label), 0., 0.5); - gtk_misc_set_padding (GTK_MISC (status_label), 10, 10); + set_alignment (status_label, 0., 0.5); + set_padding (status_label, 10, 10); gtk_container_add (GTK_CONTAINER (v2v_output...

This version of the Gtk 2/3 patch gets alignment and padding mostly right. I still can't work out how to vertically align labels in the middle of a cell in a GtkGrid. The GtkTextView in the final dialog is still broken. Rich.

Now that virt-p2v has its own repository [1] and releases [2], it is time to remove it from libguestfs. [1] https://github.com/libguestfs/virt-p2v [2] http://download.libguestfs.org/virt-p2v/ Pino Toscano (2): Remove virt-p2v Remove remaining virt-p2v bits .gitignore | 4 - Makefile.am | 7 +- bash/Makefile.am

...LL) { warning = strdup (""); - if (warning == NULL) { + if (warning == NULL) malloc_fail: - perror ("malloc"); - exit (EXIT_FAILURE); - } + error (EXIT_FAILURE, errno, "malloc"); } len = strlen (warning); @@ -1410,10 +1393,8 @@ set_log_dir (const char *remote_dir) "is saved to this directory " "on the conversion server:\n" "%s"), - remote_dir ? remote_dir : "") == -1) { - perror ("asprintf"); - exit (EXIT_FA...