search for: set_log_base

On 2019/11/6 ??10:49, Tiwei Bie wrote: >>>>>> + default: >>>>>> + /* >>>>>> + * VHOST_SET_MEM_TABLE, VHOST_SET_LOG_BASE, and >>>>>> + * VHOST_SET_LOG_FD are not used yet. >>>>>> + */ >>>>> If we don't even use them, there's probably no need to call >>>>> vhost_dev_ioctl(). This may help to avoid confusion when we want to develop >>&g...

...t; + r = vhost_mdev_get_queue_num(m, argp); > + break; It's not clear to me that how this API will be used by userspace? I think e.g features without MQ implies the queue num here. > + default: > + r = vhost_dev_ioctl(&m->dev, cmd, argp); I believe having SET_MEM_TABLE/SET_LOG_BASE/SET_LOG_FD? is for future support of those features. If it's true need add some comments on this. > + if (r == -ENOIOCTLCMD) > + r = vhost_mdev_vring_ioctl(m, cmd, argp); > + } > + > + mutex_unlock(&m->mutex); > + return r; > +} > + > +static const struct...

...orted number of queues. For virtio devices other than virtio-net, can we always expect to have a fixed default number of queues when there is no MQ feature? > > > > + default: > > + r = vhost_dev_ioctl(&m->dev, cmd, argp); > > > I believe having SET_MEM_TABLE/SET_LOG_BASE/SET_LOG_FD? is for future > support of those features. If it's true need add some comments on this. OK. > > > > + if (r == -ENOIOCTLCMD) > > + r = vhost_mdev_vring_ioctl(m, cmd, argp); > > + } > > + > > + mutex_unlock(&m->mutex); > > +...

...orted number of queues. For virtio devices other than virtio-net, can we always expect to have a fixed default number of queues when there is no MQ feature? > > > > + default: > > + r = vhost_dev_ioctl(&m->dev, cmd, argp); > > > I believe having SET_MEM_TABLE/SET_LOG_BASE/SET_LOG_FD? is for future > support of those features. If it's true need add some comments on this. OK. > > > > + if (r == -ENOIOCTLCMD) > > + r = vhost_mdev_vring_ioctl(m, cmd, argp); > > + } > > + > > + mutex_unlock(&m->mutex); > > +...

This patch introduces a mdev based hardware vhost backend. This backend is built on top of the same abstraction used in virtio-mdev and provides a generic vhost interface for userspace to accelerate the virtio devices in guest. This backend is implemented as a mdev device driver on top of the same mdev device ops used in virtio-mdev but using a different mdev class id, and it will register the

This patch introduces a mdev based hardware vhost backend. This backend is built on top of the same abstraction used in virtio-mdev and provides a generic vhost interface for userspace to accelerate the virtio devices in guest. This backend is implemented as a mdev device driver on top of the same mdev device ops used in virtio-mdev but using a different mdev class id, and it will register the

...for this API. In the future, consider we want to support multiqueue, it's still much tricky than exporting device config space to userspace. > >> >>> + default: >>> + r = vhost_dev_ioctl(&m->dev, cmd, argp); >> >> I believe having SET_MEM_TABLE/SET_LOG_BASE/SET_LOG_FD? is for future >> support of those features. If it's true need add some comments on this. > OK. > >> >>> + if (r == -ENOIOCTLCMD) >>> + r = vhost_mdev_vring_ioctl(m, cmd, argp); >>> + } >>> + >>> + mutex_unlock(&m-...

...= vhost_mdev_set_features(m, argp); >>>> + break; >>>> + case VHOST_MDEV_GET_VRING_NUM: >>>> + r = vhost_mdev_get_vring_num(m, argp); >>>> + break; >>>> + default: >>>> + /* >>>> + * VHOST_SET_MEM_TABLE, VHOST_SET_LOG_BASE, and >>>> + * VHOST_SET_LOG_FD are not used yet. >>>> + */ >>> >>> If we don't even use them, there's probably no need to call >>> vhost_dev_ioctl(). This may help to avoid confusion when we want to develop >>> new API for e.g...

...= vhost_mdev_set_features(m, argp); >>>> + break; >>>> + case VHOST_MDEV_GET_VRING_NUM: >>>> + r = vhost_mdev_get_vring_num(m, argp); >>>> + break; >>>> + default: >>>> + /* >>>> + * VHOST_SET_MEM_TABLE, VHOST_SET_LOG_BASE, and >>>> + * VHOST_SET_LOG_FD are not used yet. >>>> + */ >>> >>> If we don't even use them, there's probably no need to call >>> vhost_dev_ioctl(). This may help to avoid confusion when we want to develop >>> new API for e.g...