search for: set_guest_interrupt

1) Example code: old libc headers don't have SIOCBRADDIF, and old zlibs don't have gzdirect() -- it's a sanity check anyway. 2) Some people don't build in their source directories, so .config isn't there (thanks to Tony Breeds <tony@bakeyournoodle.com>). 3) Point out that guest and host kernel are usually the same. 4) Set the "no checksum" option on the

1) Example code: old libc headers don't have SIOCBRADDIF, and old zlibs don't have gzdirect() -- it's a sanity check anyway. 2) Some people don't build in their source directories, so .config isn't there (thanks to Tony Breeds <tony@bakeyournoodle.com>). 3) Point out that guest and host kernel are usually the same. 4) Set the "no checksum" option on the

...*/ + if (num >= ARRAY_SIZE(lg->idt)) + return 0; /* Early on the Guest hasn't set the IDT entries (or maybe it put a * bogus one in): if we fail here, the Guest will be killed. */ - if (!idt_present(lo, hi)) + if (!idt_present(lg->idt[num].a, lg->idt[num].b)) return 0; - set_guest_interrupt(lg, lo, hi, has_err(num)); + set_guest_interrupt(lg, lg->idt[num].a, lg->idt[num].b, has_err(num)); return 1; } diff -r 55fdd7fa62b7 drivers/lguest/lguest.c --- a/drivers/lguest/lguest.c Mon Aug 06 16:38:47 2007 +1000 +++ b/drivers/lguest/lguest.c Wed Aug 08 13:27:58 2007 +1000 @@ -323,9...

...*/ + if (num >= ARRAY_SIZE(lg->idt)) + return 0; /* Early on the Guest hasn't set the IDT entries (or maybe it put a * bogus one in): if we fail here, the Guest will be killed. */ - if (!idt_present(lo, hi)) + if (!idt_present(lg->idt[num].a, lg->idt[num].b)) return 0; - set_guest_interrupt(lg, lo, hi, has_err(num)); + set_guest_interrupt(lg, lg->idt[num].a, lg->idt[num].b, has_err(num)); return 1; } diff -r 55fdd7fa62b7 drivers/lguest/lguest.c --- a/drivers/lguest/lguest.c Mon Aug 06 16:38:47 2007 +1000 +++ b/drivers/lguest/lguest.c Wed Aug 08 13:27:58 2007 +1000 @@ -323,9...

Hi all, Gratefully-received recent feedback from CC'd was applied to excellent effect (and the advice from Matt Mackall about my personal appearance is best unrequited). The patch is split in 5 parts to correspond with the 9 parts Andrew sent out before, but here's the summary: 1) Sparse (thanks Christoph Hellwig): - lguest_const can be static now - lguest.c should include

Hi all, Gratefully-received recent feedback from CC'd was applied to excellent effect (and the advice from Matt Mackall about my personal appearance is best unrequited). The patch is split in 5 parts to correspond with the 9 parts Andrew sent out before, but here's the summary: 1) Sparse (thanks Christoph Hellwig): - lguest_const can be static now - lguest.c should include

...6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff -r 209f5cd5cda5 drivers/lguest/interrupts_and_traps.c --- a/drivers/lguest/interrupts_and_traps.c Fri Jul 20 14:53:40 2007 +1000 +++ b/drivers/lguest/interrupts_and_traps.c Fri Jul 20 21:34:06 2007 +1000 @@ -38,12 +38,12 @@ static void set_guest_interrupt(struct l ss = lg->regs->ss; } - /* We use IF bit in eflags to indicate whether irqs were disabled - (it's always 0, since irqs are enabled when guest is running). */ + /* We use IF bit in eflags to indicate whether irqs were enabled + (it's always 1, since irqs are enable...

...6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff -r 209f5cd5cda5 drivers/lguest/interrupts_and_traps.c --- a/drivers/lguest/interrupts_and_traps.c Fri Jul 20 14:53:40 2007 +1000 +++ b/drivers/lguest/interrupts_and_traps.c Fri Jul 20 21:34:06 2007 +1000 @@ -38,12 +38,12 @@ static void set_guest_interrupt(struct l ss = lg->regs->ss; } - /* We use IF bit in eflags to indicate whether irqs were disabled - (it's always 0, since irqs are enabled when guest is running). */ + /* We use IF bit in eflags to indicate whether irqs were enabled + (it's always 1, since irqs are enable...

...(hi & 0x8000); } -static void push_guest_stack(struct lguest *lg, u32 __user **gstack, u32 val) -{ - lgwrite_u32(lg, (u32)--(*gstack), val); +static void push_guest_stack(struct lguest *lg, unsigned long *gstack, u32 val) +{ + *gstack -= 4; + lgwrite_u32(lg, *gstack, val); } static void set_guest_interrupt(struct lguest *lg, u32 lo, u32 hi, int has_err) { - u32 __user *gstack; + unsigned long gstack; u32 eflags, ss, irq_enable; /* If they want a ring change, we use new stack and push old ss/esp */ if ((lg->regs->ss&0x3) != GUEST_PL) { - gstack = (u32 __user *)guest_pa(lg, lg->e...

...(hi & 0x8000); } -static void push_guest_stack(struct lguest *lg, u32 __user **gstack, u32 val) -{ - lgwrite_u32(lg, (u32)--(*gstack), val); +static void push_guest_stack(struct lguest *lg, unsigned long *gstack, u32 val) +{ + *gstack -= 4; + lgwrite_u32(lg, *gstack, val); } static void set_guest_interrupt(struct lguest *lg, u32 lo, u32 hi, int has_err) { - u32 __user *gstack; + unsigned long gstack; u32 eflags, ss, irq_enable; /* If they want a ring change, we use new stack and push old ss/esp */ if ((lg->regs->ss&0x3) != GUEST_PL) { - gstack = (u32 __user *)guest_pa(lg, lg->e...

...5834edd drivers/lguest/interrupts_and_traps.c --- a/drivers/lguest/interrupts_and_traps.c Sat Jul 21 11:12:01 2007 +1000 +++ b/drivers/lguest/interrupts_and_traps.c Sun Jul 22 20:47:51 2007 +1000 @@ -107,6 +107,7 @@ void maybe_do_interrupt(struct lguest *l clear_bit(irq, lg->irqs_pending); set_guest_interrupt(lg, idt->a, idt->b, 0); } + write_timestamp(lg); } static int has_err(unsigned int trap) diff -r 144835834edd drivers/lguest/lg.h --- a/drivers/lguest/lg.h Sat Jul 21 11:12:01 2007 +1000 +++ b/drivers/lguest/lg.h Sun Jul 22 20:49:03 2007 +1000 @@ -243,6 +243,7 @@ unsigned long get_dma_b...

...5834edd drivers/lguest/interrupts_and_traps.c --- a/drivers/lguest/interrupts_and_traps.c Sat Jul 21 11:12:01 2007 +1000 +++ b/drivers/lguest/interrupts_and_traps.c Sun Jul 22 20:47:51 2007 +1000 @@ -107,6 +107,7 @@ void maybe_do_interrupt(struct lguest *l clear_bit(irq, lg->irqs_pending); set_guest_interrupt(lg, idt->a, idt->b, 0); } + write_timestamp(lg); } static int has_err(unsigned int trap) diff -r 144835834edd drivers/lguest/lg.h --- a/drivers/lguest/lg.h Sat Jul 21 11:12:01 2007 +1000 +++ b/drivers/lguest/lg.h Sun Jul 22 20:49:03 2007 +1000 @@ -243,6 +243,7 @@ unsigned long get_dma_b...

...+static int idt_type(u32 lo, u32 hi) +{ + return (hi >> 8) & 0xF; +} + +static int idt_present(u32 lo, u32 hi) +{ + return (hi & 0x8000); +} + +static void push_guest_stack(struct lguest *lg, u32 __user **gstack, u32 val) +{ + lgwrite_u32(lg, (u32)--(*gstack), val); +} + +static void set_guest_interrupt(struct lguest *lg, u32 lo, u32 hi, int has_err) +{ + u32 __user *gstack; + u32 eflags, ss, irq_enable; + + /* If they want a ring change, we use new stack and push old ss/esp */ + if ((lg->regs->ss&0x3) != GUEST_PL) { + gstack = (u32 __user *)guest_pa(lg, lg->esp1); + ss = lg->ss1...

...+static int idt_type(u32 lo, u32 hi) +{ + return (hi >> 8) & 0xF; +} + +static int idt_present(u32 lo, u32 hi) +{ + return (hi & 0x8000); +} + +static void push_guest_stack(struct lguest *lg, u32 __user **gstack, u32 val) +{ + lgwrite_u32(lg, (u32)--(*gstack), val); +} + +static void set_guest_interrupt(struct lguest *lg, u32 lo, u32 hi, int has_err) +{ + u32 __user *gstack; + u32 eflags, ss, irq_enable; + + /* If they want a ring change, we use new stack and push old ss/esp */ + if ((lg->regs->ss&0x3) != GUEST_PL) { + gstack = (u32 __user *)guest_pa(lg, lg->esp1); + ss = lg->ss1...

Hi all, I've been working on lguest64 and in order to do this, I had to move a lot of the i386 specific out of the way. Well, the lguest64 port is still not ready to display, but before Rusty makes too many changes I would like this in upstream so I don't have to keep repeating my changes :-) So this patch series moves lguest32 out of the way for other archs. -- Steve

Hi all, I've been working on lguest64 and in order to do this, I had to move a lot of the i386 specific out of the way. Well, the lguest64 port is still not ready to display, but before Rusty makes too many changes I would like this in upstream so I don't have to keep repeating my changes :-) So this patch series moves lguest32 out of the way for other archs. -- Steve

[ Changes since last version. - Move lg.h to include/asm instead (suggested by Rusty Russel) - All steps of the series compiles (suggested by Stephen Rothwell) - Better ifdef header naming (suggested by Stephen Rothwell) - Added Andi Kleen to CC (forgot to on V1) ] Hi all, I've been working on lguest64 and in order to do this, I had to move a lot of the i386 specific out of the

[ Changes since last version. - Move lg.h to include/asm instead (suggested by Rusty Russel) - All steps of the series compiles (suggested by Stephen Rothwell) - Better ifdef header naming (suggested by Stephen Rothwell) - Added Andi Kleen to CC (forgot to on V1) ] Hi all, I've been working on lguest64 and in order to do this, I had to move a lot of the i386 specific out of the

Hi all, These are the patches I'm planning to submit for 2.6.24. Comments gratefully accepted. Along with the usual cleanups and improvements are Jes' de-i386-ification patches, and a new "virtio" mechanism designed to be shared with KVM (and hopefully other hypervisors). Cheers, Rusty. Documentation/lguest/Makefile | 30 Documentation/lguest/lguest.c

Hi all, These are the patches I'm planning to submit for 2.6.24. Comments gratefully accepted. Along with the usual cleanups and improvements are Jes' de-i386-ification patches, and a new "virtio" mechanism designed to be shared with KVM (and hopefully other hypervisors). Cheers, Rusty. Documentation/lguest/Makefile | 30 Documentation/lguest/lguest.c