search for: set_filt

...6) | (minor << 8) | patch); -} - /*-- hivex.c, journal.c --*/ extern void hivex_finalize (void); extern void journal_finalize (void); diff --git a/daemon/lvm-filter.c b/daemon/lvm-filter.c index 72fe6ac..d119f9e 100644 --- a/daemon/lvm-filter.c +++ b/daemon/lvm-filter.c @@ -122,7 +122,7 @@ set_filter (char *const *filters) * but do that only after having applied the transformation. */ const int flags = AUG_NO_ERR_CLOSE | AUG_NO_LOAD; - aug = aug_init (lvm_system_dir, "/usr/share/guestfs/", flags); + aug = aug_init (lvm_system_dir, NULL, flags); if (!aug) { reply...

Hi, newer lvm2 releases don't have have uncommented "filter" lines, so the current way to edit lvm.conf doesn't work anymore. Instead, switch to augeas (with a "custom" len) for a cleaner and working way to set the lvm filter. Pino Toscano (3): daemon: add add_sprintf daemon: move AUGEAS_ERROR to the common header daemon: lvm-filter: use augeas for setting the

Hi, this series improves the way LVM is used in the appliance: in particular, now lvmetad can eventually run at all, and with the correct configuration. Also improve the listing strategies. Changes in v2: - dropped patch #5, will be sent separately - move lvmetad statup in own function (patch #2) Thanks, Pino Toscano (4): daemon: lvm-filter: set also global_filter daemon: lvm-filter:

Hi, this series improves the way LVM is used in the appliance: in particular, now lvmetad can eventually run at all, and with the correct configuration. Also improve the listing strategies. Thanks, Pino Toscano (5): daemon: lvm-filter: set also global_filter daemon: lvm-filter: start lvmetad better daemon: lvm: improve filter for LVs with activationskip flag set daemon: lvm: list

v3: - Don't remove the LVM transform.

v2 of previous patch, which fixes some missing bits. For now I'm going to go with Pino's RHEL 7.1 patch, since it is at least smaller than this. So I'm sending this to the list just to have it archived for later. Rich.

...atch attached for it. This patch could be okay for me (modulo change below) once Augeas >= 1.2.1 is released. > diff --git a/daemon/lvm-filter.c b/daemon/lvm-filter.c > index 72fe6ac..d119f9e 100644 > --- a/daemon/lvm-filter.c > +++ b/daemon/lvm-filter.c > @@ -133,18 +133,6 @@ set_filter (char *const *filters) > return -1; > } > > - r = aug_transform (aug, "guestfs_lvm_conf", "/lvm/lvm.conf", > - 0 /* = included */); > - if (r == -1) { > - AUGEAS_ERROR ("aug_transform"); > - return -1; >...

...system (cmd)); + lvm_system_dir = getenv ("LVM_SYSTEM_DIR"); + if (!lvm_system_dir) + lvm_system_dir = "/etc/lvm"; + fprintf (stderr, "lvm_system_dir = %s\n", lvm_system_dir); } /* Rewrite the 'filter = [ ... ]' line in lvm.conf. */ @@ -112,7 +61,7 @@ set_filter (char *const *filters) FILE *fp; size_t i, j; - if (asprintf (&conf, "%s/lvm/lvm.conf", lvm_system_dir) == -1) { + if (asprintf (&conf, "%s/lvm.conf", lvm_system_dir) == -1) { reply_with_perror ("asprintf"); return -1; } @@ -177,7 +126,...

...rCtrl#get_path":#GenericDirCtrl_getpath </span><span class="cx"> * "GenericDirCtrl#get_file_path":#GenericDirCtrl_getfilepath </span><span class="lines">@@ -52,6 +53,7 @@ </span><span class="cx"> * "GenericDirCtrl#set_filter":#GenericDirCtrl_setfilter </span><span class="cx"> * "GenericDirCtrl#set_filter_index":#GenericDirCtrl_setfilterindex </span><span class="cx"> * "GenericDirCtrl#set_path":#GenericDirCtrl_setpath </span><ins>+* &quot...

Simplify how we handle lvm.conf.

Augeas 1.7.0 was released a couple of days ago. By encouraging everyone to upgrade to this we can drop several calls to aug_transform and also our custom copies of two lenses, and a lot of related code. Rich.