search for: set_fil

...still has a lot of code in common with Unix. This code should be pulled out into a common file. Second, some of the functions leave me scratching me head. What purpose does create_file serve? Is there really a need to create empty files? (It also leaks an open file handle, BTW). I would expect set_file to alter only the file name portion of the path and leave the directory portion unchanged, and the opposite for set_directory. set_directory obliterates the file name portion of the path (OK, I guess) but set_file doesn't make any sense at all. -------------- next part -------------- A non-te...

...fix = - let domain = ref None in - let file = ref None in - let libvirturi = ref "" in - let format = ref "" in - let output = ref "" in - let machine_readable = ref false in - let unversioned = ref false in - let prefix = ref None in - - let set_file arg = - if !file <> None then - error (f_"--add option can only be given once"); - let uri = - try URI.parse_uri arg - with Invalid_argument "URI.parse_uri" -> - error (f_"error parsing URI '%s'. Look for error messa...

Jeff, Your patch has been committed. Thanks! Reid. Jeff Cohen wrote: > Alas, you missed a serious bug in that same function. Patch attached to > fix it and improve some comments. No more late night coding for me :) > > That leaves Path.cpp. Once that's done I can actually try and execute > this stuff. > > > On Thu, 16 Sep 2004 08:55:28 -0700 > Reid Spencer

Alas, you missed a serious bug in that same function. Patch attached to fix it and improve some comments. No more late night coding for me :) That leaves Path.cpp. Once that's done I can actually try and execute this stuff. On Thu, 16 Sep 2004 08:55:28 -0700 Reid Spencer <reid at x10sys.com> wrote: > This version has been committed to CVS with one minor change: > I made the

...n common with Unix. > This code should be pulled out into a common file. > > Second, some of the functions leave me scratching me head. What purpose > does create_file serve? Is there really a need to create empty files? > (It also leaks an open file handle, BTW). I would expect set_file to > alter only the file name portion of the path and leave the directory > portion unchanged, and the opposite for set_directory. set_directory > obliterates the file name portion of the path (OK, I guess) but set_file > doesn't make any sense at all. > > _________________...

...() = + let blocksize = ref 0 in let domain = ref None in let file = ref None in let libvirturi = ref "" in @@ -52,14 +53,14 @@ let parse_cmdline () = prefix := Some p in let argspec = [ - [ S 'a'; L"add" ], Getopt.String (s_"file", set_file), s_"Add disk image file"; - [ S 'c'; L"connect" ], Getopt.Set_string (s_"uri", libvirturi), s_"Set libvirt URI"; - [ S 'd'; L"domain" ], Getopt.String (s_"domain", set_domain), s_"Set...

...+open Printf + +(* Main program. *) +let main () = + let add, output = + let domain = ref None in + let file = ref None in + let libvirturi = ref "" in + let format = ref "" in + let output = ref "" in + let machine_readable = ref false in + + let set_file arg = + if !file <> None then + error (f_"--add option can only be given once"); + let uri = + try URI.parse_uri arg + with Invalid_argument "URI.parse_uri" -> + error (f_"error parsing URI '%s'. Look for error messa...

In the TODO file there's a discussion of perhaps writing a new 'virt-customize' tool. I think it's probably better (or at any rate, easier) to just add this functionality into virt-sysprep. That is what this small series of patches aims to achieve. Note these are not very well tested at the moment. The first patch adds a generic and useful '--firstboot' flag. The

...{ out <- data.frame(nova="") } return(out) } dlg$model_value_changed <- function(.) { fname <- .$get_file() if(file.exists(fname)) { for(i in c("txt","csv")) { if(grepl(paste("\\.",i,sep=""), fname)) .$set_file.type(c(txt="table",csv="csv")[i]) } } switch(.$get_file.type(), "csv"={.$set_sep(","); .$set_quote('\"')}, "table"={}, {} ) .$set_output(.$do_call("read_file",.$to_R())) } dlg$OK_ha...

...= + let add, output, unversioned = let domain = ref None in let file = ref None in let libvirturi = ref "" in let format = ref "" in let output = ref "" in let machine_readable = ref false in + let unversioned = ref false in let set_file arg = if !file <> None then @@ -60,6 +61,8 @@ let main () = "--machine-readable", Arg.Set machine_readable, " " ^ s_"Make output machine readable"; "-o", Arg.Set_string output, s_"directory" ^ " " ^ s_&qu...

...d, prefix = let domain = ref None in let file = ref None in let libvirturi = ref "" in @@ -33,6 +33,7 @@ let main () = let output = ref "" in let machine_readable = ref false in let unversioned = ref false in + let prefix = ref None in let set_file arg = if !file <> None then @@ -45,7 +46,11 @@ let main () = and set_domain dom = if !domain <> None then error (f_"--domain option can only be given once"); - domain := Some dom in + domain := Some dom + and set_prefix p = + if !...

..._kernel.ml index 58193ab..8ca7ca0 100644 --- a/get-kernel/get_kernel.ml +++ b/get-kernel/get_kernel.ml @@ -53,7 +53,7 @@ let main () = prefix := Some p in let ditto = " -\"-" in - let argspec = Arg.align [ + let argspec = [ "-a", Arg.String set_file, s_"file" ^ " " ^ s_"Add disk image file"; "--add", Arg.String set_file, s_"file" ^ " " ^ s_"Add disk image file"; "-c", Arg.Set_string libvirturi, s_"uri" ^ " "...

...b/get-kernel/get_kernel.ml > @@ -50,24 +50,18 @@ let parse_cmdline () = > error (f_"--prefix option can only be given once"); > prefix := Some p in > > - let ditto = " -\"-" in > let argspec = [ > - "-a", Arg.String set_file, s_"file" ^ " " ^ s_"Add disk image file"; > - "--add", Arg.String set_file, s_"file" ^ " " ^ s_"Add disk image file"; > - "-c", Arg.Set_string libvirturi, s_"uri" ^ "...

...ernel.ml @@ -18,6 +18,7 @@ open Common_gettext.Gettext open Common_utils +open Getopt.OptionName module G = Guestfs @@ -51,15 +52,15 @@ let parse_cmdline () = prefix := Some p in let argspec = [ - [ "-a"; "--add" ], Getopt.String (s_"file", set_file), s_"Add disk image file"; - [ "-c"; "--connect" ], Getopt.Set_string (s_"uri", libvirturi), s_"Set libvirt URI"; - [ "-d"; "--domain" ], Getopt.String (s_"domain", set_domain), s_"...

...--- a/get-kernel/get_kernel.ml +++ b/get-kernel/get_kernel.ml @@ -50,24 +50,18 @@ let parse_cmdline () = error (f_"--prefix option can only be given once"); prefix := Some p in - let ditto = " -\"-" in let argspec = [ - "-a", Arg.String set_file, s_"file" ^ " " ^ s_"Add disk image file"; - "--add", Arg.String set_file, s_"file" ^ " " ^ s_"Add disk image file"; - "-c", Arg.Set_string libvirturi, s_"uri" ^ " " ^ s...

...--- a/get-kernel/get_kernel.ml +++ b/get-kernel/get_kernel.ml @@ -50,24 +50,18 @@ let parse_cmdline () = error (f_"--prefix option can only be given once"); prefix := Some p in - let ditto = " -\"-" in let argspec = [ - "-a", Arg.String set_file, s_"file" ^ " " ^ s_"Add disk image file"; - "--add", Arg.String set_file, s_"file" ^ " " ^ s_"Add disk image file"; - "-c", Arg.Set_string libvirturi, s_"uri" ^ " " ^ s...

...--- a/get-kernel/get_kernel.ml +++ b/get-kernel/get_kernel.ml @@ -50,24 +50,17 @@ let parse_cmdline () = error (f_"--prefix option can only be given once"); prefix := Some p in - let ditto = " -\"-" in let argspec = [ - "-a", Arg.String set_file, s_"file" ^ " " ^ s_"Add disk image file"; - "--add", Arg.String set_file, s_"file" ^ " " ^ s_"Add disk image file"; - "-c", Arg.Set_string libvirturi, s_"uri" ^ " " ^ s...

v1 -> v2: - Further fixes to Getopt int parsing. - Completed the L/S changes. - Fixed the test suite so it passes now. Also we don't need the special-case tests for 64 bit arch. Rich.

v3 -> v4: - Pushed the first patch upstream since it was ACKed. - Prevent use of M except for the special virt-v2v options. - Sort the options after added --help etc. - Make corresponding fixes to the tests. Rich.

v2 -> v3: - Add M variant and test it. Rich.