search for: set_featur

..._get_dma_dev(struct vdpa_device *vdev) { return vdev->dma_dev; } + +static inline void vdpa_reset(struct vdpa_device *vdev) +{ + const struct vdpa_config_ops *ops = vdev->config; + + vdev->features_valid = false; + ops->set_status(vdev, 0); +} + +static inline int vdpa_set_features(struct vdpa_device *vdev, u64 features) +{ + const struct vdpa_config_ops *ops = vdev->config; + + vdev->features_valid = true; + return ops->set_features(vdev, features); +} + + +static inline void vdpa_get_config(struct vdpa_device *vdev, unsigned offset, + void *bu...

..._get_dma_dev(struct vdpa_device *vdev) { return vdev->dma_dev; } + +static inline void vdpa_reset(struct vdpa_device *vdev) +{ + const struct vdpa_config_ops *ops = vdev->config; + + vdev->features_valid = false; + ops->set_status(vdev, 0); +} + +static inline int vdpa_set_features(struct vdpa_device *vdev, u64 features) +{ + const struct vdpa_config_ops *ops = vdev->config; + + vdev->features_valid = true; + return ops->set_features(vdev, features); +} + + +static inline void vdpa_get_config(struct vdpa_device *vdev, unsigned offset, + void *bu...

...c inline void vdpa_reset(struct vdpa_device *vdev) > > +{ > > + const struct vdpa_config_ops *ops = vdev->config; > > + > > + vdev->features_valid = false; > > + ops->set_status(vdev, 0); > > +} > > + > > +static inline int vdpa_set_features(struct vdpa_device *vdev, u64 features) > > +{ > > + const struct vdpa_config_ops *ops = vdev->config; > > + > > + vdev->features_valid = true; > > + return ops->set_features(vdev, features); > > +} > > + > > + > > +stat...

...>dma_dev; > } > + > +static inline void vdpa_reset(struct vdpa_device *vdev) > +{ > + const struct vdpa_config_ops *ops = vdev->config; > + > + vdev->features_valid = false; > + ops->set_status(vdev, 0); > +} > + > +static inline int vdpa_set_features(struct vdpa_device *vdev, u64 features) > +{ > + const struct vdpa_config_ops *ops = vdev->config; > + > + vdev->features_valid = true; > + return ops->set_features(vdev, features); > +} > + > + > +static inline void vdpa_get_config(struct vdpa_de...

...>dma_dev; > } > + > +static inline void vdpa_reset(struct vdpa_device *vdev) > +{ > + const struct vdpa_config_ops *ops = vdev->config; > + > + vdev->features_valid = false; > + ops->set_status(vdev, 0); > +} > + > +static inline int vdpa_set_features(struct vdpa_device *vdev, u64 features) > +{ > + const struct vdpa_config_ops *ops = vdev->config; > + > + vdev->features_valid = true; > + return ops->set_features(vdev, features); > +} > + > + > +static inline void vdpa_get_config(struct vdpa_de...

On Thu, Aug 06, 2020 at 11:23:05AM +0800, Jason Wang wrote: > > On 2020/8/5 ??7:40, Michael S. Tsirkin wrote: > > On Wed, Aug 05, 2020 at 02:14:07PM +0800, Jason Wang wrote: > > > On 2020/8/4 ??5:00, Michael S. Tsirkin wrote: > > > > Some legacy guests just assume features are 0 after reset. > > > > We detect that config space is accessed before

On Thu, Aug 06, 2020 at 03:27:38PM +0800, Jason Wang wrote: > > On 2020/8/6 ??1:53, Michael S. Tsirkin wrote: > > On Thu, Aug 06, 2020 at 11:23:05AM +0800, Jason Wang wrote: > > > On 2020/8/5 ??7:40, Michael S. Tsirkin wrote: > > > > On Wed, Aug 05, 2020 at 02:14:07PM +0800, Jason Wang wrote: > > > > > On 2020/8/4 ??5:00, Michael S. Tsirkin wrote:

...0 DR1: 0000000000000000 DR2: 0000000000000000 > DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400 > Call Trace: > ? preempt_count_add+0x58/0xb0 > ? _raw_spin_lock_irqsave+0x36/0x70 > ? _raw_spin_unlock_irqrestore+0x1a/0x40 > ? __wake_up+0x70/0x190 > virtnet_set_features+0x90/0xf0 [virtio_net] > __netdev_update_features+0x271/0x980 > ? nlmsg_notify+0x5b/0xa0 > dev_disable_lro+0x2b/0x190 > ? inet_netconf_notify_devconf+0xe2/0x120 > devinet_sysctl_forward+0x176/0x1e0 > proc_sys_call_handler+0x1f0/0x250 > proc_sys_write+0xf/0x20 > __v...

...0 DR1: 0000000000000000 DR2: 0000000000000000 > DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400 > Call Trace: > ? preempt_count_add+0x58/0xb0 > ? _raw_spin_lock_irqsave+0x36/0x70 > ? _raw_spin_unlock_irqrestore+0x1a/0x40 > ? __wake_up+0x70/0x190 > virtnet_set_features+0x90/0xf0 [virtio_net] > __netdev_update_features+0x271/0x980 > ? nlmsg_notify+0x5b/0xa0 > dev_disable_lro+0x2b/0x190 > ? inet_netconf_notify_devconf+0xe2/0x120 > devinet_sysctl_forward+0x176/0x1e0 > proc_sys_call_handler+0x1f0/0x250 > proc_sys_write+0xf/0x20 > __v...

On 2020/8/5 ??7:40, Michael S. Tsirkin wrote: > On Wed, Aug 05, 2020 at 02:14:07PM +0800, Jason Wang wrote: >> On 2020/8/4 ??5:00, Michael S. Tsirkin wrote: >>> Some legacy guests just assume features are 0 after reset. >>> We detect that config space is accessed before features are >>> set and set features to 0 automatically. >>> Note: some legacy

On 2020/8/5 ??7:40, Michael S. Tsirkin wrote: > On Wed, Aug 05, 2020 at 02:14:07PM +0800, Jason Wang wrote: >> On 2020/8/4 ??5:00, Michael S. Tsirkin wrote: >>> Some legacy guests just assume features are 0 after reset. >>> We detect that config space is accessed before features are >>> set and set features to 0 automatically. >>> Note: some legacy

...0000000000 > > DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400 > > Call Trace: > > ? preempt_count_add+0x58/0xb0 > > ? _raw_spin_lock_irqsave+0x36/0x70 > > ? _raw_spin_unlock_irqrestore+0x1a/0x40 > > ? __wake_up+0x70/0x190 > > virtnet_set_features+0x90/0xf0 [virtio_net] > > __netdev_update_features+0x271/0x980 > > ? nlmsg_notify+0x5b/0xa0 > > dev_disable_lro+0x2b/0x190 > > ? inet_netconf_notify_devconf+0xe2/0x120 > > devinet_sysctl_forward+0x176/0x1e0 > > proc_sys_call_handler+0x1f0/0x250 > >...

...0ff0 DR7: 0000000000000400 > > > > Call Trace: > > > > ? preempt_count_add+0x58/0xb0 > > > > ? _raw_spin_lock_irqsave+0x36/0x70 > > > > ? _raw_spin_unlock_irqrestore+0x1a/0x40 > > > > ? __wake_up+0x70/0x190 > > > > virtnet_set_features+0x90/0xf0 [virtio_net] > > > > __netdev_update_features+0x271/0x980 > > > > ? nlmsg_notify+0x5b/0xa0 > > > > dev_disable_lro+0x2b/0x190 > > > > ? inet_netconf_notify_devconf+0xe2/0x120 > > > > devinet_sysctl_forward+0x176/0x1e0 >...

On 2020/8/6 ??1:53, Michael S. Tsirkin wrote: > On Thu, Aug 06, 2020 at 11:23:05AM +0800, Jason Wang wrote: >> On 2020/8/5 ??7:40, Michael S. Tsirkin wrote: >>> On Wed, Aug 05, 2020 at 02:14:07PM +0800, Jason Wang wrote: >>>> On 2020/8/4 ??5:00, Michael S. Tsirkin wrote: >>>>> Some legacy guests just assume features are 0 after reset.

On 2020/8/6 ??1:53, Michael S. Tsirkin wrote: > On Thu, Aug 06, 2020 at 11:23:05AM +0800, Jason Wang wrote: >> On 2020/8/5 ??7:40, Michael S. Tsirkin wrote: >>> On Wed, Aug 05, 2020 at 02:14:07PM +0800, Jason Wang wrote: >>>> On 2020/8/4 ??5:00, Michael S. Tsirkin wrote: >>>>> Some legacy guests just assume features are 0 after reset.

...l Trace: > > > > > > ? preempt_count_add+0x58/0xb0 > > > > > > ? _raw_spin_lock_irqsave+0x36/0x70 > > > > > > ? _raw_spin_unlock_irqrestore+0x1a/0x40 > > > > > > ? __wake_up+0x70/0x190 > > > > > > virtnet_set_features+0x90/0xf0 [virtio_net] > > > > > > __netdev_update_features+0x271/0x980 > > > > > > ? nlmsg_notify+0x5b/0xa0 > > > > > > dev_disable_lro+0x2b/0x190 > > > > > > ? inet_netconf_notify_devconf+0xe2/0x120 > > > >...

...0 DR1: 0000000000000000 DR2: 0000000000000000 > DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400 > Call Trace: > ? preempt_count_add+0x58/0xb0 > ? _raw_spin_lock_irqsave+0x36/0x70 > ? _raw_spin_unlock_irqrestore+0x1a/0x40 > ? __wake_up+0x70/0x190 > virtnet_set_features+0x90/0xf0 [virtio_net] > __netdev_update_features+0x271/0x980 > ? nlmsg_notify+0x5b/0xa0 > dev_disable_lro+0x2b/0x190 > ? inet_netconf_notify_devconf+0xe2/0x120 > devinet_sysctl_forward+0x176/0x1e0 > proc_sys_call_handler+0x1f0/0x250 > proc_sys_write+0xf/0x20 > __v...

...Returns virtqueue algin requirement > + * @get_features: Get virtio features supported by the device > + * @mdev: mediated device > + * Returns the virtio features support by the > + * device > + * @get_features: Set virtio features supported by the driver s/get_features/set_features/ > + * configration space > + * @get_mdev_features: Get the feature of virtio mdev device > + * @mdev: mediated device > + * Returns the mdev features (API) support by > + * the device. > + * @get_generation: Get device generaton > + * @mdev: mediated devic...

...oes not need to know about >>> VRITIO_F_ANY_LAYOUT and we reused the bit for other purposes. >> It's the knowledge of vhost_net code it self but not userspace. For >> userspace, it should depends on the value of returned by VHOST_GET_FEATURES. >> So when userspace can set_features with ANY_LAYOUT, vhost may think it wants >> VHOST_NET_F_VIRTIO_NET_HDR. > Yes but that's the admittedly ugly API that we have now. > userspace is supposed to know VRITIO_F_ANY_LAYOUT does > not make sense for vhost. Ok. > > > >>> >>> >>>&g...

...0 DR1: 0000000000000000 DR2: 0000000000000000 > DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400 > Call Trace: > ? preempt_count_add+0x58/0xb0 > ? _raw_spin_lock_irqsave+0x36/0x70 > ? _raw_spin_unlock_irqrestore+0x1a/0x40 > ? __wake_up+0x70/0x190 > virtnet_set_features+0x90/0xf0 [virtio_net] > __netdev_update_features+0x271/0x980 > ? nlmsg_notify+0x5b/0xa0 > dev_disable_lro+0x2b/0x190 > ? inet_netconf_notify_devconf+0xe2/0x120 > devinet_sysctl_forward+0x176/0x1e0 > proc_sys_call_handler+0x1f0/0x250 > proc_sys_write+0xf/0x20 > __v...