search for: session_close

Hi! I am resending the following message about problems with utmp handling. * In the meantime I had some request in private mail from people asking whether I have new information. * The problem is still persistant in 2.9p2. * My own new investigations show, that the problem only appears with protocol 2, not with protocol 1, I therefore only started to note it when protocol 2 became the

...'ControlPath none' still applies and is required, btw. --- openssh/clientloop.c~ 2005-06-17 03:59:35.000000000 +0100 +++ openssh/clientloop.c 2005-06-23 11:05:11.000000000 +0100 @@ -1271,8 +1271,28 @@ static void client_channel_closed(int id, void *arg) { channel_cancel_cleanup(id); - session_closed = 1; leave_raw_mode(); + if (options.control_persist && options.control_path != NULL && control_fd != -1) { + int pid = fork(); + + if (pid < 0) { + error("fork: %.100s", strerror(errno)); + /* Just exit */ + session_closed = 1; + return; + } + if (pid !=...

...ld be redirected from /dev/null. */ extern int stdin_null_flag; @@ -122,7 +123,8 @@ static int connection_in; /* Connection to server (input). */ static int connection_out; /* Connection to server (output). */ static int need_rekeying; /* Set to non-zero if rekeying is requested. */ -static int session_closed = 0; /* In SSH2: login session closed. */ +enum SessionStatus {SessionOpen, SessionClose, SessionWait}; +static int session_status = SessionOpen; /* In SSH2: login session closed. */ static void client_init_dispatch(void); int session_ident = -1; @@ -320,6 +322,10 @@ client_wait_until_can_do_...

...ld be redirected from /dev/null. */ extern int stdin_null_flag; @@ -122,7 +123,8 @@ static int connection_in; /* Connection to server (input). */ static int connection_out; /* Connection to server (output). */ static int need_rekeying; /* Set to non-zero if rekeying is requested. */ -static int session_closed = 0; /* In SSH2: login session closed. */ +enum SessionStatus {SessionOpen, SessionClose, SessionWait}; +static int session_status = SessionOpen; /* In SSH2: login session closed. */ static void client_init_dispatch(void); int session_ident = -1; @@ -320,6 +322,10 @@ client_wait_until_can_do_...

...h acct="<user>" exe="/usr/bin/su" hostname=? addr=? terminal=? res=success' Oct 26 11:01:06 <servername> kernel: type=1106 audit(1477494066.620:642431): pid=108548 uid=0 auid=4294967295 ses=4294967295 subj=system_u:system_r:unconfined_service_t:s0 msg='op=PAM:session_close grantors=pam_keyinit,pam_keyinit,pam_limits,pam_systemd,pam_unix,pam_krb5,pam_xauth acct="<user>" exe="/usr/bin/su" hostname=? addr=? terminal=? res=success' Oct 26 11:01:06 <servername> kernel: type=1104 audit(1477494066.620:642432): pid=108548 uid=0 auid=429496...

...51 2001 +++ openssh-2.9p1S/clientloop.c Thu May 17 21:41:44 2001 @@ -121,8 +121,8 @@ static int connection_in; /* Connection to server (input). */ static int connection_out; /* Connection to server (output). */ static int need_rekeying; /* Set to non-zero if rekeying is requested. */ -static int session_closed = 0; /* In SSH2: login session closed. */ - +enum SessionStatus {SessionOpen, SessionClose, SessionWait}; +static int session_status = SessionOpen; /* In SSH2: login session closed. */ void client_init_dispatch(void); int session_ident = -1; @@ -324,6 +324,10 @@ client_wait_until_can_do_somet...

...ork even if system integer types are 'long', not 'int'. * entropy.c (prng_check_seedfile, prng_write_seedfile, prng_read_seedfile): Likewise. * serverloop.c (server_loop, server_loop2): Likewise. * session.c (session_dump, session_by_pid, session_exit_message, session_close_by_pid, session_have_children, session_close_by_channel): Likewise. * ssh-agent.c, sshd.c (main): Likewise. * sshpty.c (pty_setowner): Likewise. * uidswap.c: (temporarily_use_uid): Likewise. =================================================================== RCS file: authfile.c,v ret...

...ld be redirected from /dev/null. */ extern int stdin_null_flag; @@ -122,7 +123,8 @@ static int connection_in; /* Connection to server (input). */ static int connection_out; /* Connection to server (output). */ static int need_rekeying; /* Set to non-zero if rekeying is requested. */ -static int session_closed = 0; /* In SSH2: login session closed. */ +enum SessionStatus {SessionOpen, SessionClose, SessionWait}; +static int session_status = SessionOpen; /* In SSH2: login session closed. */ static void client_init_dispatch(void); int session_ident = -1; @@ -320,6 +322,10 @@ client_wait_until_can_do_...

Hi, I noticed that Markus has fixed the temporary file cleanup problems in OpenSSH cvs. What files need patching for this ? I only noticed changes in: session.c, channels.h and channels.c. -Jarno -- Jarno Huuskonen <Jarno.Huuskonen at uku.fi>

http://bugzilla.mindrot.org/show_bug.cgi?id=160 ------- Additional Comments From Nicolas.Williams at ubsw.com 2002-03-13 09:10 ------- Created an attachment (id=40) Debug output, lsof output, etc... ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee.

Hi all, After the memory leaks (bug 1967 <https://bugzilla.mindrot.org/show_bug.cgi?id=1967>) I reported in bugzilla are fixed, I also applied melton(http://lcs.ios.ac.cn/~xuzb/melton.html) to detect the potential bugs in sshd (openssh-5.9p1). The url below is the index of bug reports that are checked as real bugs manually.

Hi, I search in archive list if there any reason why is removed in openssh newer than 2.9.9 from function 'void session_close_by_channel(int id, void *arg)' sending of SIGTEMR and SIGHUP signals to child as was in 2.9.9 version? See follow sniped code from 2.9.9 sources: ---- openssh-2.9.9/session.c ---------------------------------------- void session_close_by_channel(int id, void *arg) ... debug("ses...

In the changelog, there is an entry: 20001129 - (djm) Back out all the serverloop.c hacks. sshd will now hang again if there are background children with open fds. Does this mean that this is regarded as expected (and correct) behavior, that should not change in the future, or does it mean that this behavior is a known problem that someone will eventually fix? --Adam -- Adam McKenna

...log("User %.100s not allowed because none of user's group are listed in AllowGroups", + pw->pw_name); return 0; } ga_free(); *** session.c.O Mon Jun 18 13:59:57 2001 --- session.c Mon Jun 18 14:15:29 2001 *************** *** 93,98 **** --- 93,99 ---- void session_close(Session *s); void do_exec_pty(Session *s, const char *command); void do_exec_no_pty(Session *s, const char *command); + void do_exec(Session *s, const char *command); void do_login(Session *s, const char *command); void do_child(Session *s, const char *command); void do_motd(void); ******...

...s = &sessions[i]; if (s->used && s->pid == pid) return s; } - error("session_by_pid: unknown pid %d", pid); + error("session_by_pid: unknown pid %ld", (long)pid); session_dump(); return NULL; } @@ -1905,8 +1905,8 @@ if (c == NULL) fatal("session_close: session %d: no channel %d", s->self, s->chanid); - debug("session_exit_message: session %d channel %d pid %d", - s->self, s->chanid, s->pid); + debug("session_exit_message: session %d channel %d pid %ld", + s->self, s->chanid, (long)s-&g...

...BUG sshd[534]: debug2: channel 98: rcvd close May 29 14:43:07 DEBUG sshd[534]: debug2: channel 98: is dead May 29 14:43:07 DEBUG sshd[534]: debug2: channel 98: gc: notify user May 29 14:43:07 DEBUG sshd[534]: debug1: session_by_channel: session 98 channel 98 May 29 14:43:07 DEBUG sshd[534]: debug1: session_close_by_channel: channel 98 child 0 May 29 14:43:07 DEBUG sshd[534]: debug1: session_close: session 98 pid 0 May 29 14:43:07 DEBUG sshd[534]: debug2: channel 98: gc: user detached May 29 14:43:07 DEBUG sshd[534]: debug2: channel 98: is dead May 29 14:43:07 DEBUG sshd[534]: debug2: channel 98: garbage co...

...ion 0 alloc debug: server_input_channel_req: channel 0 request shell reply 1 debug: session_by_channel: session 0 channel 0 debug: session_input_channel_req: session 0 req shell Secure shell client connected Secure shell client disconnected debug: channel 0: free: server-session, nchannels 1 debug: session_close: session 0 pid 0 000110.999|SSHD |3|01|Closing connection to 172.23.1.174 <Connection 2.............> debug: Enabling compatibility mode for protocol 2.0 debug: SSH2_MSG_KEXINIT sent debug: kex: client->server aes256-cbc hmac-sha1 none debug: kex: server->client aes256-cbc hmac-sha1 no...

...ng PAM_TTY to "/dev/pts/1" debug1: PAM: establishing credentials debug1: Setting controlling tty using TIOCSCTTY. debug1: Received SIGCHLD. debug1: session_by_pid: pid 17636 debug1: session_exit_message: session 0 channel 0 pid 17636 debug1: session_exit_message: release channel 0 debug1: session_close: session 0 pid 17636 debug1: session_pty_cleanup: session 0 release /dev/pts/1 debug1: channel 0: free: server-session, nchannels 1 Connection closed by x.x.x.x Closing connection to x.x.x.x debug1: PAM: cleanup Thanks for the help. Forster

...r>" exe="/usr/bin/su" hostname=? addr=? terminal=? res=success' > Oct 26 11:01:06 <servername> kernel: type=1106 > audit(1477494066.620:642431): pid=108548 uid=0 auid=4294967295 > ses=4294967295 subj=system_u:system_r:unconfined_service_t:s0 > msg='op=PAM:session_close > grantors=pam_keyinit,pam_keyinit,pam_limits,pam_ > systemd,pam_unix,pam_krb5,pam_xauth > acct="<user>" exe="/usr/bin/su" hostname=? addr=? terminal=? res=success' > Oct 26 11:01:06 <servername> kernel: type=1104 > audit(1477494066.620:642432): pi...

In the following code snippit from session.c: void session_close_by_pid(pid_t pid, int status) { Session *s = session_by_pid(pid); if (s == NULL) { debug("session_close_by_pid: no session for pid %d", s->pid); return; } if (s->chanid != -1) session_exit_message(s, sta...